Skip to content

Conversation

@stevemunk
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/maps/armmaps
JavaScript @azure/arm-maps
Swagger Microsoft.Maps-Maps

@stevemunk stevemunk requested a review from faterceros October 17, 2025 22:45
@mikekistler mikekistler added the BreakingChange-Approved-Retired Service is retired - removing API definitions label Oct 21, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 21, 2025
@mikeharder
Copy link
Member

mikeharder commented Oct 21, 2025

This PR removes the "creators" paths, but only from some (not all) API versions. All stable versions, and the latest preview version, were updated. However, 7 older previews (from 2020-02-01-preview to 2024-07-01-preview) were not updated. This is causing the Avocado error MISSING_APIS_IN_DEFAULT_TAG, since it expects all APIs in all versions, to also be in the default tag version.

To maintain consistency, I think this PR should be updated in one of two ways:

  1. Remove "creators" paths from older previews
  2. Remove older previews completely from the repo

@mikekistler: What do you think?

@ramoka178
Copy link
Contributor

This PR removes the "creators" paths, but only from some (not all) API versions. All stable versions, and the latest preview version, were updated. However, 7 older previews (from 2020-02-01-preview to 2024-07-01-preview) were not updated. This is causing the Avocado error MISSING_APIS_IN_DEFAULT_TAG, since it expects all APIs in all versions, to also be in the default tag version.

To maintain consistency, I think this PR should be updated in one of two ways:

  1. Remove "creators" paths from older previews
  2. Remove older previews completely from the repo

@mikekistler: What do you think?

Waiting on this response for further review

@ramoka178
Copy link
Contributor

Please fix the conflicts too

@ramoka178 ramoka178 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 23, 2025
@github-actions github-actions bot removed the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMChangesRequested ARMReview BreakingChange-Approved-Retired Service is retired - removing API definitions BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Maps resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants