-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Remove NonSensitivity for DDoS ruleset #38246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kamboj-prjwl/release-network-2025-03-01
Are you sure you want to change the base?
Remove NonSensitivity for DDoS ruleset #38246
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
...ication/network/resource-manager/Microsoft.Network/stable/2025-01-01/applicationGateway.json
Outdated
Show resolved
Hide resolved
|
Can we check with Prajjwal if we can make Medium as default value |
|
Can you confirm the set of rule sets include Bot and Http DDoS so that we can get CLI fixed when the SDK is released |
| "description": "The string representation of the web application firewall rule sensitivity.", | ||
| "enum": [ | ||
| "None", | ||
| "Low", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "None" being removed ? Will this not cause issues to existing customers who used this enum ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramoka178 None is not available to the customer. Only the DDoS ruleset can be able to configure the Sensitivity field and the feature is private preview only. None of the private preview customers config the 'None' value for their DDoS ruleset Sensitivity field.
...ication/network/resource-manager/Microsoft.Network/stable/2025-01-01/applicationGateway.json
Outdated
Show resolved
Hide resolved
I think we are okay to not add examples, since one with Block action and High Sensitivity already exist for Httpddosruleset. |
|
Let's see if we can test these changes out. Rest looks good to me. |
…g/DDoSRuleset_removeNonSensitivity
|
@baoqihuang0326 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
|
@baoqihuang0326 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.