-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[NetAppFiles] Update to 2025-08-01 #38227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetAppFiles] Update to 2025-08-01 #38227
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
|
This is for completness. We will not release SDKs for this version, since we have a new api-version 2025-09-01 being released very soon, service is being deployed, and will release SDKs based on that for this release cycle. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
Braking change flag is for a change that was needed for bugfix where the spec was not mathcing the service behavior. Swagger avocado is for APIs that were deprecated long time ago. The tools does not seem to detect that. [MISSING_APIS_IN_DEFAULT_TAG] False positive on deprecated APIs Can we set
|
…into release-Microsoft.NetApp-2025-08-01
| /** | ||
| * Bucket resource | ||
| */ | ||
| @removed(Versions.v2025_08_01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is staying in preview and not moving to stable in this version. We are newly converted over to TypeSpec and we are trying to modeal that behavior in TypeSpec for the first time.
If there is another better way to experss this in TypeSpec would love to see that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reach out TypeSpec Discussion | Azure SDK | Microsoft Teams channel for better guidance on this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramoka178 Sure, asked this on the channel, The AI bot seems to agree with this approach.
Seems our mistake is not adding it again in the next preview, adding now.
example pattern
model FeatureX {
@added(Versions.v1)
@removed(Versions.v2)
@added(Versions.v3Preview)
previewProperty: string;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramoka178 updated
…into release-Microsoft.NetApp-2025-08-01
…into release-Microsoft.NetApp-2025-08-01
…into release-Microsoft.NetApp-2025-08-01
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.