Skip to content

[DAPR] Add support for configuring max-concurrency #33651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 2, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Apr 2, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@v-shenoy v-shenoy changed the title [DAPR] Add support for configurating max-concurrency [DAPR] Add support for configuring max-concurrency Apr 2, 2025
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 9, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 9, 2025
@najian najian merged commit 90011b6 into Azure:release-app-Microsoft.App-preview/2025-02-02-Preview Apr 10, 2025
33 checks passed
najian added a commit that referenced this pull request May 9, 2025
* Copy files from preview/2024-10-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-02-02-preview

Updated the API version from preview/2024-10-02-preview to preview/2025-02-02-preview.

* Added tag for 2025-02-02-preview in readme file

* Adding Ingress Configuration to Managed Environment API  (#33057)

* Adding Ingress Configuration to Managed Env

* Adding to lists

* Wrong name

* Prettier updates

* Update

* Moving to own definition

* Removing default cause linter doesn't like it

* [Microsoft.App] Label history Delete API and Label History Status (#32738)

* added label history delete api and status field

* fixed missing }

* updating label history delete in the correct folder

* reverting 10-02-02 to original version

* fixing CI erros

* fixing CI errors

* updating tspconfig for dynamicsessions

* Reverting tspconfig

* fix tag for new preview release

---------

Co-authored-by: Gurpreet Singh <[email protected]>

* Add app health check configuration for DAPR (#32653)

* Add app health check configuration for DAPR

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Linting

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Fix ResourceNameRestriction, NoErrorCodeResponse, DeleteResponseCode lint checks

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Revert "Fix ResourceNameRestriction, NoErrorCodeResponse, DeleteResponseCode lint checks"

This reverts commit 785dfd6.

* Lint

Signed-off-by: Vighnesh Shenoy <[email protected]>

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Support getting storage account key from key vault for environment storage (#32701)

* Support getting storage account key from key vault for environment storage

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Fix CI

Signed-off-by: Vighnesh Shenoy <[email protected]>

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>

* [Azure ContainerApps] Fix missing payload for Patch connected environ… (#33303)

* [Azure ContainerApps] Fix missing payload for Patch connected environments

* Fix example

---------

Co-authored-by: Layla Liu <[email protected]>

* Add uri format for keyvaulturl (#33615)

* [DAPR] Add support for configurating max-concurrency (#33651)

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Add closing code block in readme.md

* Add deleting provisioningstate for resources storage/cerificate/dapr … (#32746)

* Add deleting provisioningstate for resources storage/cerificate/dapr component of connected environments

* Fix swagger format

---------

Co-authored-by: Layla Liu <[email protected]>

* Update SessionPool api 2025-02-02-preview (#34120)

* Update SessionPool api 2025-02-02-preview

* Fix examples

* Prettier

* Prettier

* Prettier

* [Microsoft.App]fix Swagger PrettierCheck (#34005)

* fix format

* add where to suppress

---------

Co-authored-by: Nan Jiang <[email protected]>

* Fix Prettier error and LintDiff (#34153)

Co-authored-by: Nan Jiang <[email protected]>

* Update readme.md

* Update readme.md

* Add where to Lint Suppression (#34200)

Co-authored-by: Nan Jiang <[email protected]>

* Fix Lint where (#34203)

Co-authored-by: Nan Jiang <[email protected]>

* Adding disk encryption configuration (#33646)

* Adding disk encryption configuration.

* missing character

* add format modifier

* prettier

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Yi Xian Soo <[email protected]>
Co-authored-by: Gurpreet Singh <[email protected]>
Co-authored-by: Gurpreet Singh <[email protected]>
Co-authored-by: Vighnesh Shenoy <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Layla Liu <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: Yitao Pan <[email protected]>
Co-authored-by: Vaclav Turecek <[email protected]>
@v-shenoy v-shenoy deleted the vshenoy/dapr-concurrency branch June 8, 2025 20:06
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
* Copy files from preview/2024-10-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-02-02-preview

Updated the API version from preview/2024-10-02-preview to preview/2025-02-02-preview.

* Added tag for 2025-02-02-preview in readme file

* Adding Ingress Configuration to Managed Environment API  (Azure#33057)

* Adding Ingress Configuration to Managed Env

* Adding to lists

* Wrong name

* Prettier updates

* Update

* Moving to own definition

* Removing default cause linter doesn't like it

* [Microsoft.App] Label history Delete API and Label History Status (Azure#32738)

* added label history delete api and status field

* fixed missing }

* updating label history delete in the correct folder

* reverting 10-02-02 to original version

* fixing CI erros

* fixing CI errors

* updating tspconfig for dynamicsessions

* Reverting tspconfig

* fix tag for new preview release

---------

Co-authored-by: Gurpreet Singh <[email protected]>

* Add app health check configuration for DAPR (Azure#32653)

* Add app health check configuration for DAPR

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Linting

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Fix ResourceNameRestriction, NoErrorCodeResponse, DeleteResponseCode lint checks

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Revert "Fix ResourceNameRestriction, NoErrorCodeResponse, DeleteResponseCode lint checks"

This reverts commit 785dfd6.

* Lint

Signed-off-by: Vighnesh Shenoy <[email protected]>

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Support getting storage account key from key vault for environment storage (Azure#32701)

* Support getting storage account key from key vault for environment storage

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Fix CI

Signed-off-by: Vighnesh Shenoy <[email protected]>

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>

* [Azure ContainerApps] Fix missing payload for Patch connected environ… (Azure#33303)

* [Azure ContainerApps] Fix missing payload for Patch connected environments

* Fix example

---------

Co-authored-by: Layla Liu <[email protected]>

* Add uri format for keyvaulturl (Azure#33615)

* [DAPR] Add support for configurating max-concurrency (Azure#33651)

Signed-off-by: Vighnesh Shenoy <[email protected]>

* Add closing code block in readme.md

* Add deleting provisioningstate for resources storage/cerificate/dapr … (Azure#32746)

* Add deleting provisioningstate for resources storage/cerificate/dapr component of connected environments

* Fix swagger format

---------

Co-authored-by: Layla Liu <[email protected]>

* Update SessionPool api 2025-02-02-preview (Azure#34120)

* Update SessionPool api 2025-02-02-preview

* Fix examples

* Prettier

* Prettier

* Prettier

* [Microsoft.App]fix Swagger PrettierCheck (Azure#34005)

* fix format

* add where to suppress

---------

Co-authored-by: Nan Jiang <[email protected]>

* Fix Prettier error and LintDiff (Azure#34153)

Co-authored-by: Nan Jiang <[email protected]>

* Update readme.md

* Update readme.md

* Add where to Lint Suppression (Azure#34200)

Co-authored-by: Nan Jiang <[email protected]>

* Fix Lint where (Azure#34203)

Co-authored-by: Nan Jiang <[email protected]>

* Adding disk encryption configuration (Azure#33646)

* Adding disk encryption configuration.

* missing character

* add format modifier

* prettier

---------

Signed-off-by: Vighnesh Shenoy <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Yi Xian Soo <[email protected]>
Co-authored-by: Gurpreet Singh <[email protected]>
Co-authored-by: Gurpreet Singh <[email protected]>
Co-authored-by: Vighnesh Shenoy <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Layla Liu <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: Yitao Pan <[email protected]>
Co-authored-by: Vaclav Turecek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants