Cognitive Services 2023-10-01-preview #26054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/2023-05-01 to version 2023-10-01-preview
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @tianxin-ms! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Oct 2, 2023
tianxin-ms
changed the title
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
tianxin-ms
removed
the
BreakingChangeReviewRequired
|
Hi @tianxin-ms and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected]. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @ms-zhenhua, @rkmanda, can you please help review this PR and I reverted the changes that cause breaking-change, added suppressions to readme file, who will help with Suppression Review? |
|
Hi @tianxin-ms please also suppress ResourceNameRestriction in https://github.com/Azure/azure-rest-api-specs/pull/26054/checks?check_run_id=17588226340 with the breaking change reason. |
ms-zhenhua
added
ARMChangesRequested
and removed
WaitForARMFeedback
|
Hi @ms-zhenhua, thank you for the review, suppressions were updated, please help review again. Thank you! |
AzureRestAPISpecReview
added
the
ReadyForApiTest
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
added
Approved-Suppression
ARMSignedOff
|
/pr RequestMerge |
ms-zhenhua
approved these changes
Oct 12, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 12, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Adds base for updating Microsoft.CognitiveServices from version stable/2023-05-01 to version 2023-10-01-preview * Updates readme * Updates API version in new specs and examples * Cognitive Services 2023-10-01-preview * address failed items * remove addition response code 200 of delete apis * Add list deployment sku api * Address check items * Address check items * small contract changes * updated contract * Added EncryptionScope APIs and address comments * Fixed EncryptionScope and address failed check * address failed check * fix some examples * remove identity from ES * update suppressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.