Skip to content

Conversation

@ChenxiJiang333
Copy link
Member

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 29, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 29, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(d870e29) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 29, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 2ae4f1a. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.RecoveryServicesBackup [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.String Azure.ResourceManager.RecoveryServicesBackup.Models.RecoveryServicesBackupPrivateLinkServiceConnectionState.ActionRequired.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.RecoveryServicesBackup.Models.RecoveryServicesBackupPrivateLinkServiceConnectionState.ActionRequired.set(System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.RecoveryServicesBackup.Models.VmWorkloadSapHanaHsr' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.RecoveryServicesBackup/Debug/netstandard2.0/Azure.ResourceManager.RecoveryServicesBackup.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 2ae4f1a. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation RecoveryPointsCrrOperations.get
    info	[Changelog]   - Model AzureVmWorkloadProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSAPAseSystemProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaDBInstance has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaDBInstanceProtectedItem has a new parameter nodes_list
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaDBInstanceProtectedItem has a new parameter soft_delete_retention_period_in_days
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaDatabaseProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaHSRProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaSystemProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSQLAvailabilityGroupProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSQLAvailabilityGroupProtectableItem has a new parameter nodes_list
    info	[Changelog]   - Model AzureVmWorkloadSQLDatabaseProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model AzureVmWorkloadSQLInstanceProtectableItem has a new parameter is_protectable
    info	[Changelog]   - Model BackupResourceVaultConfig has a new parameter soft_delete_retention_period_in_days
    info	[Changelog]   - Model DistributedNodesInfo has a new parameter source_resource_id
    info	[Changelog]   - Model InquiryValidation has a new parameter protectable_item_count
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model AzureVmWorkloadSAPHanaDBInstanceProtectedItem no longer has parameter soft_delete_retention_period
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 2ae4f1a. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `*AzureVMWorkloadSAPHanaHSR.GetAzureVMWorkloadProtectableItem` has been removed
    info	[Changelog] - Function `*AzureVMWorkloadSAPHanaHSR.GetWorkloadProtectableItem` has been removed
    info	[Changelog] - Struct `AzureVMWorkloadSAPHanaHSR` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureFileshareProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSClassicComputeVMProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSComputeVMProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSVMProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureSQLProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPAseDatabaseProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPHanaDBInstanceProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPHanaDatabaseProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSQLDatabaseProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `DPMProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `GenericProtectedItem` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `MabFileFolderProtectedItem` has been removed
    info	[Changelog] - Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
    info	[Changelog] - Field `SoftDeleteRetentionPeriod` of struct `ProtectedItem` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `SoftDeleteFeatureStateAlwaysON` added to enum type `SoftDeleteFeatureState`
    info	[Changelog] - New enum type `VaultSubResourceType` with values `VaultSubResourceTypeAzureBackup`, `VaultSubResourceTypeAzureBackupSecondary`, `VaultSubResourceTypeAzureSiteRecovery`
    info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSRProtectableItem.GetAzureVMWorkloadProtectableItem() *AzureVMWorkloadProtectableItem`
    info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSRProtectableItem.GetWorkloadProtectableItem() *WorkloadProtectableItem`
    info	[Changelog] - New struct `AzureVMWorkloadSAPHanaHSRProtectableItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `AzureFileshareProtectedItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `AzureIaaSClassicComputeVMProtectedItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `AzureIaaSComputeVMProtectedItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `AzureIaaSVMProtectedItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `AzureSQLProtectedItem`
    info	[Changelog] - New field `NodesList`, `SoftDeleteRetentionPeriodInDays` in struct `AzureVMWorkloadProtectedItem`
    info	[Changelog] - New field `NodesList`, `SoftDeleteRetentionPeriodInDays` in struct `AzureVMWorkloadSAPAseDatabaseProtectedItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSAPAseSystemProtectableItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSAPHanaDBInstance`
    info	[Changelog] - New field `NodesList`, `SoftDeleteRetentionPeriodInDays` in struct `AzureVMWorkloadSAPHanaDBInstanceProtectedItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSAPHanaDatabaseProtectableItem`
    info	[Changelog] - New field `NodesList`, `SoftDeleteRetentionPeriodInDays` in struct `AzureVMWorkloadSAPHanaDatabaseProtectedItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSAPHanaSystemProtectableItem`
    info	[Changelog] - New field `IsProtectable`, `NodesList` in struct `AzureVMWorkloadSQLAvailabilityGroupProtectableItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSQLDatabaseProtectableItem`
    info	[Changelog] - New field `NodesList`, `SoftDeleteRetentionPeriodInDays` in struct `AzureVMWorkloadSQLDatabaseProtectedItem`
    info	[Changelog] - New field `IsProtectable` in struct `AzureVMWorkloadSQLInstanceProtectableItem`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `BackupResourceVaultConfig`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `DPMProtectedItem`
    info	[Changelog] - New field `SourceResourceID` in struct `DistributedNodesInfo`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `GenericProtectedItem`
    info	[Changelog] - New field `ProtectableItemCount` in struct `InquiryValidation`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `MabFileFolderProtectedItem`
    info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnection`
    info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
    info	[Changelog] - New field `SoftDeleteRetentionPeriodInDays` in struct `ProtectedItem`
    info	[Changelog]
    info	[Changelog] Total 19 breaking change(s), 35 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 2ae4f1a. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-recoveryservicesbackup [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface AzureVmWorkloadSAPHanaHSRProtectableItem
    info	[Changelog]   - Added Type Alias VaultSubResourceType
    info	[Changelog]   - Interface AzureVmWorkloadProtectableItem has a new optional parameter isProtectable
    info	[Changelog]   - Interface AzureVmWorkloadProtectedItem has a new optional parameter nodesList
    info	[Changelog]   - Interface AzureVmWorkloadSQLAvailabilityGroupProtectableItem has a new optional parameter nodesList
    info	[Changelog]   - Interface BackupResourceVaultConfig has a new optional parameter softDeleteRetentionPeriodInDays
    info	[Changelog]   - Interface DistributedNodesInfo has a new optional parameter sourceResourceId
    info	[Changelog]   - Interface InquiryValidation has a new optional parameter protectableItemCount
    info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
    info	[Changelog]   - Interface PrivateLinkServiceConnectionState has a new optional parameter actionsRequired
    info	[Changelog]   - Interface ProtectedItem has a new optional parameter softDeleteRetentionPeriodInDays
    info	[Changelog]   - Added Enum KnownVaultSubResourceType
    info	[Changelog]   - Enum KnownSoftDeleteFeatureState has a new value AlwaysON
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Interface PrivateLinkServiceConnectionState no longer has parameter actionRequired
    info	[Changelog]   - Interface ProtectedItem no longer has parameter softDeleteRetentionPeriod
    info	[Changelog]   - Type of parameter protectableItemType of interface AzureVmWorkloadProtectableItem is changed from "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"
    info	[Changelog]   - Type of parameter protectableItemType of interface WorkloadProtectableItem is changed from "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 2ae4f1a. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️recoveryservicesbackup [View full logs
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 2ae4f1a. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.recoveryservicesbackup.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.recoveryservicesbackup.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 29, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup https://apiview.dev/Assemblies/Review/947ad010344f402993ff6627c88270f5
Java azure-resourcemanager-recoveryservicesbackup https://apiview.dev/Assemblies/Review/a85efe5644e142ec80fb083f0a193f84
.Net Azure.ResourceManager.RecoveryServicesBackup https://apiview.dev/Assemblies/Review/a61aa4484323431cb78ad9cc8cc4d442
JavaScript @azure/arm-recoveryservicesbackup https://apiview.dev/Assemblies/Review/b1ec1083f722467b8b922cd1bf14979b

@msyyc msyyc marked this pull request as ready for review August 29, 2023 09:38
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 29, 2023
@msyyc msyyc added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 30, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2023
@msyyc msyyc merged commit 2ae4f1a into Azure:main Aug 30, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
* Update readme.python.md

* Update readme.python.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants