Skip to content

Conversation

@XiaofeiCao
Copy link
Contributor

To avoid breaking change in convenience layer code.

generated code: https://github.com/Azure/azure-sdk-for-java/pull/35553/files

@openapi-pipeline-app
Copy link

Swagger pipeline started successfully, please wait for status update in this comment.

@openapi-workflow-bot
Copy link

Hi @XiaofeiCao, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to Service API Toolset Introduction for details.
  • Please contact service focal contacts or Service API Toolset Support Channel if need further help.
  • @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot openapi-workflow-bot bot added ShiftLeftViolation DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jun 25, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @XiaofeiCao Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @XiaofeiCao XiaofeiCao changed the title appplatform, add directive to change map value type readme.java.md for AppPlatform, add directive to change map value type Jun 25, 2023
    @XiaofeiCao XiaofeiCao marked this pull request as ready for review June 25, 2023 06:43
    @XiaofeiCao XiaofeiCao removed DoNotMerge <valid label in PR review process> use to hold merge after approval ShiftLeftViolation labels Jun 25, 2023
    @XiaofeiCao
    Copy link
    Contributor Author

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 25, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.3) new version base version
    default default(8cc85cf) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 25, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-js - @azure/arm-appplatform - 3.0.0-beta.2
    +	Class AppPlatformManagementClient has a new signature

    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 4b74815. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.appplatform.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.appplatform.DefaultTag
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b74815. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appplatform [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation BuildServiceOperations.begin_create_or_update
      info	[Changelog]   - Added operation BuildServiceOperations.begin_delete_build
      info	[Changelog]   - Added operation GatewaysOperations.begin_restart
      info	[Changelog]   - Added operation ServicesOperations.begin_disable_apm_globally
      info	[Changelog]   - Added operation ServicesOperations.begin_enable_apm_globally
      info	[Changelog]   - Added operation ServicesOperations.list_globally_enabled_apms
      info	[Changelog]   - Added operation ServicesOperations.list_supported_apm_types
      info	[Changelog]   - Added operation group ApmsOperations
      info	[Changelog]   - Added operation group ContainerRegistriesOperations
      info	[Changelog]   - Added operation group EurekaServersOperations
      info	[Changelog]   - Model AcceleratorBasicAuthSetting has a new parameter ca_cert_resource_id
      info	[Changelog]   - Model AcceleratorPublicSetting has a new parameter ca_cert_resource_id
      info	[Changelog]   - Model AppResourceProperties has a new parameter workload_profile_name
      info	[Changelog]   - Model BuildProperties has a new parameter apms
      info	[Changelog]   - Model BuildProperties has a new parameter certificates
      info	[Changelog]   - Model BuildResultProperties has a new parameter image
      info	[Changelog]   - Model BuildServiceProperties has a new parameter container_registry
      info	[Changelog]   - Model ConfigServerProperties has a new parameter enabled_state
      info	[Changelog]   - Model ConfigurationServiceGitRepository has a new parameter ca_cert_resource_id
      info	[Changelog]   - Model ConfigurationServiceGitRepository has a new parameter git_implementation
      info	[Changelog]   - Model ConfigurationServiceProperties has a new parameter generation
      info	[Changelog]   - Model DeploymentSettings has a new parameter apms
      info	[Changelog]   - Model GatewayCorsProperties has a new parameter allowed_origin_patterns
      info	[Changelog]   - Model GatewayProperties has a new parameter addon_configs
      info	[Changelog]   - Model GatewayProperties has a new parameter client_auth
      info	[Changelog]   - Model ServiceVNetAddons has a new parameter data_plane_public_endpoint
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 4b74815. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.AppPlatform [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IDictionary<System.String, System.Collections.Generic.IDictionary<System.String, System.BinaryData>> Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProperties.AddonConfigs.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.AppPlatform.Models.AppPlatformAzureFileVolume..ctor(System.String, System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IDictionary<System.String, System.BinaryData> Azure.ResourceManager.AppPlatform.Models.AppPlatformBindingProperties.BindingParameters.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.AppPlatform.Models.AppPlatformBuildServiceProperties.KPackVersion.set(System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IDictionary<System.String, System.Collections.Generic.IDictionary<System.String, System.BinaryData>> Azure.ResourceManager.AppPlatform.Models.AppPlatformDeploymentSettings.AddonConfigs.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<System.Boolean> Azure.ResourceManager.AppPlatform.Models.AppPlatformServiceProperties.IsLogStreamPublicEndpoint.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.AppPlatform.Models.AppPlatformServiceProperties.IsLogStreamPublicEndpoint.set(System.Nullable<System.Boolean>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.AppPlatform/Debug/netstandard2.0/Azure.ResourceManager.AppPlatform.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Azure.ResourceManager.AppPlatform.csproj::TargetFramework=netstandard2.0]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4b74815. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias GatewayRouteConfigsListResponse
      info	[Changelog]   - Added Type Alias GatewaysCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GatewaysGetResponse
      info	[Changelog]   - Added Type Alias GatewaysListEnvSecretsResponse
      info	[Changelog]   - Added Type Alias GatewaysListNextResponse
      info	[Changelog]   - Added Type Alias GatewaysListResponse
      info	[Changelog]   - Added Type Alias GatewaysUpdateCapacityResponse
      info	[Changelog]   - Added Type Alias GatewaysValidateDomainResponse
      info	[Changelog]   - Added Type Alias GitImplementation
      info	[Changelog]   - Added Type Alias HttpSchemeType
      info	[Changelog]   - Added Type Alias PowerState
      info	[Changelog]   - Added Type Alias PredefinedAcceleratorProvisioningState
      info	[Changelog]   - Added Type Alias PredefinedAcceleratorsGetResponse
      info	[Changelog]   - Added Type Alias PredefinedAcceleratorsListNextResponse
      info	[Changelog]   - Added Type Alias PredefinedAcceleratorsListResponse
      info	[Changelog]   - Added Type Alias PredefinedAcceleratorState
      info	[Changelog]   - Added Type Alias ProbeActionType
      info	[Changelog]   - Added Type Alias ProbeActionUnion
      info	[Changelog]   - Added Type Alias ServicesListGloballyEnabledApmsResponse
      info	[Changelog]   - Added Type Alias ServicesListSupportedApmTypesNextResponse
      info	[Changelog]   - Added Type Alias ServicesListSupportedApmTypesResponse
      info	[Changelog]   - Added Type Alias SessionAffinity
      info	[Changelog]   - Added Type Alias StoragePropertiesUnion
      info	[Changelog]   - Added Type Alias StoragesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias StoragesGetResponse
      info	[Changelog]   - Added Type Alias StoragesListNextResponse
      info	[Changelog]   - Added Type Alias StoragesListResponse
      info	[Changelog]   - Added Type Alias StorageType
      info	[Changelog]   - Added Type Alias Type
      info	[Changelog]   - Interface AppResourceProperties has a new optional parameter customPersistentDisks
      info	[Changelog]   - Interface AppResourceProperties has a new optional parameter ingressSettings
      info	[Changelog]   - Interface AppResourceProperties has a new optional parameter secrets
      info	[Changelog]   - Interface AppResourceProperties has a new optional parameter vnetAddons
      info	[Changelog]   - Interface AppResourceProperties has a new optional parameter workloadProfileName
      info	[Changelog]   - Interface BuildProperties has a new optional parameter apms
      info	[Changelog]   - Interface BuildProperties has a new optional parameter certificates
      info	[Changelog]   - Interface BuildProperties has a new optional parameter resourceRequests
      info	[Changelog]   - Interface BuildResultProperties has a new optional parameter error
      info	[Changelog]   - Interface BuildResultProperties has a new optional parameter image
      info	[Changelog]   - Interface BuildServiceProperties has a new optional parameter containerRegistry
      info	[Changelog]   - Interface BuildStageProperties has a new optional parameter exitCode
      info	[Changelog]   - Interface BuildStageProperties has a new optional parameter reason
      info	[Changelog]   - Interface CertificateProperties has a new optional parameter provisioningState
      info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter infraResourceGroup
      info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter managedEnvironmentId
      info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter marketplaceResource
      info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter powerState
      info	[Changelog]   - Interface ClusterResourceProperties has a new optional parameter vnetAddons
      info	[Changelog]   - Interface ConfigServerProperties has a new optional parameter enabledState
      info	[Changelog]   - Interface ConfigurationServiceGitRepository has a new optional parameter caCertResourceId
      info	[Changelog]   - Interface ConfigurationServiceGitRepository has a new optional parameter gitImplementation
      info	[Changelog]   - Interface ConfigurationServiceProperties has a new optional parameter generation
      info	[Changelog]   - Interface CustomDomainProperties has a new optional parameter provisioningState
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter apms
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter containerProbeSettings
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter livenessProbe
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter readinessProbe
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter scale
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter startupProbe
      info	[Changelog]   - Interface DeploymentSettings has a new optional parameter terminationGracePeriodSeconds
      info	[Changelog]   - Interface ManagedIdentityProperties has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface NetworkProfile has a new optional parameter ingressConfig
      info	[Changelog]   - Interface NetworkProfile has a new optional parameter outboundType
      info	[Changelog]   - Type of parameter type of interface UserSourceInfo is changed from "UploadedUserSourceInfo" | "Jar" | "Source" | "NetCoreZip" | "BuildResult" to "UploadedUserSourceInfo" | "Jar" | "Source" | "NetCoreZip" | "BuildResult" | "Container"
      info	[Changelog]   - Added Enum KnownApiPortalProvisioningState
      info	[Changelog]   - Added Enum KnownApmProvisioningState
      info	[Changelog]   - Added Enum KnownApmType
      info	[Changelog]   - Added Enum KnownApplicationAcceleratorProvisioningState
      info	[Changelog]   - Added Enum KnownApplicationLiveViewProvisioningState
      info	[Changelog]   - Added Enum KnownBackendProtocol
      info	[Changelog]   - Added Enum KnownCertificateResourceProvisioningState
      info	[Changelog]   - Added Enum KnownConfigServerEnabledState
      info	[Changelog]   - Added Enum KnownConfigurationServiceGeneration
      info	[Changelog]   - Added Enum KnownContainerRegistryProvisioningState
      info	[Changelog]   - Added Enum KnownCustomDomainResourceProvisioningState
      info	[Changelog]   - Added Enum KnownCustomizedAcceleratorProvisioningState
      info	[Changelog]   - Added Enum KnownCustomizedAcceleratorValidateResultState
      info	[Changelog]   - Added Enum KnownDevToolPortalFeatureState
      info	[Changelog]   - Added Enum KnownDevToolPortalProvisioningState
      info	[Changelog]   - Added Enum KnownEurekaServerEnabledState
      info	[Changelog]   - Added Enum KnownEurekaServerState
      info	[Changelog]   - Added Enum KnownGatewayCertificateVerification
      info	[Changelog]   - Added Enum KnownGatewayProvisioningState
      info	[Changelog]   - Added Enum KnownGatewayRouteConfigProtocol
      info	[Changelog]   - Added Enum KnownGitImplementation
      info	[Changelog]   - Added Enum KnownHttpSchemeType
      info	[Changelog]   - Added Enum KnownPowerState
      info	[Changelog]   - Added Enum KnownPredefinedAcceleratorProvisioningState
      info	[Changelog]   - Added Enum KnownPredefinedAcceleratorState
      info	[Changelog]   - Added Enum KnownProbeActionType
      info	[Changelog]   - Added Enum KnownSessionAffinity
      info	[Changelog]   - Added Enum KnownStorageType
      info	[Changelog]   - Added Enum KnownType
      info	[Changelog]   - Enum KnownBindingType has a new value CACertificates
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class AppPlatformManagementClient has a new signature
      info	[Changelog]   - Interface DeploymentsListForClusterNextOptionalParams no longer has parameter version
      info	[Changelog]   - Interface DeploymentsListNextOptionalParams no longer has parameter version
      info	[Changelog]   - Type of parameter addonConfigs of interface AppResourceProperties is changed from {
      info	[Changelog]         [propertyName: string]: {
      info	[Changelog]             [propertyName: string]: Record<string, unknown>;
      info	[Changelog]         };
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter bindingParameters of interface BindingResourceProperties is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: string;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter addonConfigs of interface DeploymentSettings is changed from {
      info	[Changelog]         [propertyName: string]: {
      info	[Changelog]             [propertyName: string]: Record<string, unknown>;
      info	[Changelog]         };
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     }
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4b74815. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appplatform/armappplatform [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `ApmProvisioningState` with values `ApmProvisioningStateCanceled`, `ApmProvisioningStateCreating`, `ApmProvisioningStateDeleting`, `ApmProvisioningStateFailed`, `ApmProvisioningStateSucceeded`, `ApmProvisioningStateUpdating`
      info	[Changelog] - New enum type `ConfigServerEnabledState` with values `ConfigServerEnabledStateDisabled`, `ConfigServerEnabledStateEnabled`
      info	[Changelog] - New enum type `ConfigurationServiceGeneration` with values `ConfigurationServiceGenerationGen1`, `ConfigurationServiceGenerationGen2`
      info	[Changelog] - New enum type `ContainerRegistryProvisioningState` with values `ContainerRegistryProvisioningStateCanceled`, `ContainerRegistryProvisioningStateCreating`, `ContainerRegistryProvisioningStateDeleting`, `ContainerRegistryProvisioningStateFailed`, `ContainerRegistryProvisioningStateSucceeded`, `ContainerRegistryProvisioningStateUpdating`
      info	[Changelog] - New enum type `EurekaServerEnabledState` with values `EurekaServerEnabledStateDisabled`, `EurekaServerEnabledStateEnabled`
      info	[Changelog] - New enum type `EurekaServerState` with values `EurekaServerStateCanceled`, `EurekaServerStateFailed`, `EurekaServerStateSucceeded`, `EurekaServerStateUpdating`
      info	[Changelog] - New enum type `GatewayCertificateVerification` with values `GatewayCertificateVerificationDisabled`, `GatewayCertificateVerificationEnabled`
      info	[Changelog] - New enum type `GitImplementation` with values `GitImplementationGoGit`, `GitImplementationLibgit2`
      info	[Changelog] - New function `NewApmsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ApmsClient, error)`
      info	[Changelog] - New function `*ApmsClient.BeginCreateOrUpdate(context.Context, string, string, string, ApmResource, *ApmsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ApmsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ApmsClient.BeginDelete(context.Context, string, string, string, *ApmsClientBeginDeleteOptions) (*runtime.Poller[ApmsClientDeleteResponse], error)`
      info	[Changelog] - New function `*ApmsClient.Get(context.Context, string, string, string, *ApmsClientGetOptions) (ApmsClientGetResponse, error)`
      info	[Changelog] - New function `*ApmsClient.NewListPager(string, string, *ApmsClientListOptions) *runtime.Pager[ApmsClientListResponse]`
      info	[Changelog] - New function `*ApmsClient.ListSecretKeys(context.Context, string, string, string, *ApmsClientListSecretKeysOptions) (ApmsClientListSecretKeysResponse, error)`
      info	[Changelog] - New function `*BuildServiceClient.BeginCreateOrUpdate(context.Context, string, string, string, BuildService, *BuildServiceClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildServiceClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*BuildServiceClient.BeginDeleteBuild(context.Context, string, string, string, string, *BuildServiceClientBeginDeleteBuildOptions) (*runtime.Poller[BuildServiceClientDeleteBuildResponse], error)`
      info	[Changelog] - New function `*ClientFactory.NewApmsClient() *ApmsClient`
      info	[Changelog] - New function `*ClientFactory.NewContainerRegistriesClient() *ContainerRegistriesClient`
      info	[Changelog] - New function `*ClientFactory.NewEurekaServersClient() *EurekaServersClient`
      info	[Changelog] - New function `NewContainerRegistriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ContainerRegistriesClient, error)`
      info	[Changelog] - New function `*ContainerRegistriesClient.BeginCreateOrUpdate(context.Context, string, string, string, ContainerRegistryResource, *ContainerRegistriesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ContainerRegistriesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ContainerRegistriesClient.BeginDelete(context.Context, string, string, string, *ContainerRegistriesClientBeginDeleteOptions) (*runtime.Poller[ContainerRegistriesClientDeleteResponse], error)`
      info	[Changelog] - New function `*ContainerRegistriesClient.Get(context.Context, string, string, string, *ContainerRegistriesClientGetOptions) (ContainerRegistriesClientGetResponse, error)`
      info	[Changelog] - New function `*ContainerRegistriesClient.NewListPager(string, string, *ContainerRegistriesClientListOptions) *runtime.Pager[ContainerRegistriesClientListResponse]`
      info	[Changelog] - New function `*ContainerRegistriesClient.BeginValidate(context.Context, string, string, string, ContainerRegistryProperties, *ContainerRegistriesClientBeginValidateOptions) (*runtime.Poller[ContainerRegistriesClientValidateResponse], error)`
      info	[Changelog] - New function `*ContainerRegistryBasicCredentials.GetContainerRegistryCredentials() *ContainerRegistryCredentials`
      info	[Changelog] - New function `*ContainerRegistryCredentials.GetContainerRegistryCredentials() *ContainerRegistryCredentials`
      info	[Changelog] - New function `NewEurekaServersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*EurekaServersClient, error)`
      info	[Changelog] - New function `*EurekaServersClient.Get(context.Context, string, string, *EurekaServersClientGetOptions) (EurekaServersClientGetResponse, error)`
      info	[Changelog] - New function `*EurekaServersClient.List(context.Context, string, string, *EurekaServersClientListOptions) (EurekaServersClientListResponse, error)`
      info	[Changelog] - New function `*EurekaServersClient.BeginUpdatePatch(context.Context, string, string, EurekaServerResource, *EurekaServersClientBeginUpdatePatchOptions) (*runtime.Poller[EurekaServersClientUpdatePatchResponse], error)`
      info	[Changelog] - New function `*EurekaServersClient.BeginUpdatePut(context.Context, string, string, EurekaServerResource, *EurekaServersClientBeginUpdatePutOptions) (*runtime.Poller[EurekaServersClientUpdatePutResponse], error)`
      info	[Changelog] - New function `*GatewaysClient.BeginRestart(context.Context, string, string, string, *GatewaysClientBeginRestartOptions) (*runtime.Poller[GatewaysClientRestartResponse], error)`
      info	[Changelog] - New function `*ServicesClient.BeginDisableApmGlobally(context.Context, string, string, ApmReference, *ServicesClientBeginDisableApmGloballyOptions) (*runtime.Poller[ServicesClientDisableApmGloballyResponse], error)`
      info	[Changelog] - New function `*ServicesClient.BeginEnableApmGlobally(context.Context, string, string, ApmReference, *ServicesClientBeginEnableApmGloballyOptions) (*runtime.Poller[ServicesClientEnableApmGloballyResponse], error)`
      info	[Changelog] - New function `*ServicesClient.ListGloballyEnabledApms(context.Context, string, string, *ServicesClientListGloballyEnabledApmsOptions) (ServicesClientListGloballyEnabledApmsResponse, error)`
      info	[Changelog] - New function `*ServicesClient.NewListSupportedApmTypesPager(string, string, *ServicesClientListSupportedApmTypesOptions) *runtime.Pager[ServicesClientListSupportedApmTypesResponse]`
      info	[Changelog] - New struct `ApmProperties`
      info	[Changelog] - New struct `ApmReference`
      info	[Changelog] - New struct `ApmResource`
      info	[Changelog] - New struct `ApmResourceCollection`
      info	[Changelog] - New struct `ApmSecretKeys`
      info	[Changelog] - New struct `CertificateReference`
      info	[Changelog] - New struct `ContainerRegistryBasicCredentials`
      info	[Changelog] - New struct `ContainerRegistryProperties`
      info	[Changelog] - New struct `ContainerRegistryResource`
      info	[Changelog] - New struct `ContainerRegistryResourceCollection`
      info	[Changelog] - New struct `ContainerRegistryValidateResult`
      info	[Changelog] - New struct `EurekaServerProperties`
      info	[Changelog] - New struct `EurekaServerResource`
      info	[Changelog] - New struct `EurekaServerResourceCollection`
      info	[Changelog] - New struct `GatewayPropertiesClientAuth`
      info	[Changelog] - New struct `GloballyEnabledApms`
      info	[Changelog] - New struct `SupportedApmType`
      info	[Changelog] - New struct `SupportedApmTypes`
      info	[Changelog] - New field `CaCertResourceID` in struct `AcceleratorBasicAuthSetting`
      info	[Changelog] - New field `CaCertResourceID` in struct `AcceleratorPublicSetting`
      info	[Changelog] - New field `WorkloadProfileName` in struct `AppResourceProperties`
      info	[Changelog] - New field `Apms`, `Certificates` in struct `BuildProperties`
      info	[Changelog] - New field `Image` in struct `BuildResultProperties`
      info	[Changelog] - New field `ContainerRegistry` in struct `BuildServiceProperties`
      info	[Changelog] - New field `EnabledState` in struct `ConfigServerProperties`
      info	[Changelog] - New field `CaCertResourceID`, `GitImplementation` in struct `ConfigurationServiceGitRepository`
      info	[Changelog] - New field `Generation` in struct `ConfigurationServiceProperties`
      info	[Changelog] - New field `Apms` in struct `DeploymentSettings`
      info	[Changelog] - New field `AllowedOriginPatterns` in struct `GatewayCorsProperties`
      info	[Changelog] - New field `AddonConfigs`, `ClientAuth` in struct `GatewayProperties`
      info	[Changelog] - New field `DataPlanePublicEndpoint` in struct `ServiceVNetAddons`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 113 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b74815. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️appplatform [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 25, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/appplatform/armappplatform https://apiview.dev/Assemblies/Review/8790ce3c6ca94583b473ac54da890c59
    Java azure-resourcemanager-appplatform-generated https://apiview.dev/Assemblies/Review/1909c93cae2f4968a5043351f45c77a5
    .Net Azure.ResourceManager.AppPlatform https://apiview.dev/Assemblies/Review/24f7170e3f13469dbc51ea9f29396c11
    JavaScript @azure/arm-appplatform https://apiview.dev/Assemblies/Review/6ad98247de1f4fa3b7536b2175a3c0a2

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @weidongxu-microsoft
    Copy link
    Member

    You may need to check with service, whether they need to do it in their ADO.

    Hi @XiaofeiCao, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

    @ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 26, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2023
    @v-xuto
    Copy link
    Member

    v-xuto commented Jun 26, 2023

    @qiaozha Please help review JS breaking change.

    @XiaofeiCao XiaofeiCao added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 26, 2023
    @XiaofeiCao
    Copy link
    Contributor Author

    Service will initialize PR from their ADO repo. Close this one.

    @XiaofeiCao XiaofeiCao closed this Jun 27, 2023
    @XiaofeiCao XiaofeiCao reopened this Jun 27, 2023
    @XiaofeiCao
    Copy link
    Contributor Author

    According to service, we can get this PR merged.

    @XiaofeiCao XiaofeiCao removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 27, 2023
    @openapi-pipeline-app openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 27, 2023
    @weidongxu-microsoft weidongxu-microsoft merged commit 4b74815 into Azure:main Jun 27, 2023
    @weidongxu-microsoft
    Copy link
    Member

    No need for JS breaking change review. The PR only change Java option, won't affect JS.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript DoNotMerge <valid label in PR review process> use to hold merge after approval ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants