Skip to content

mgmt, resources subscriptions, revert SubscriptionIdParameter x-ms-parameter-location #24088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

mgmt, resources subscriptions, revert SubscriptionIdParameter x-ms-parameter-location #24088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...ation/resources/resource-manager/Microsoft.Resources/stable/2022-12-01/subscriptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"description": "This operation provides all the locations that are available for resource providers; however, each resource provider may support a subset of this list.",
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -126,7 +126,7 @@
"description": "Gets details about a specified subscription.",
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -234,7 +234,7 @@
"description": "Compares a subscriptions logical zone mapping",
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -934,6 +934,14 @@
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The ID of the target subscription.",
"x-ms-parameter-location": "method"
},
Comment on lines +937 to +944
Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert it to be same as previous stable api-version 2021-01-01
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2021-01-01/subscriptions.json#L821-L828

Copy link
Contributor

@gauravkumar1491 gauravkumar1491 May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weidongxu-microsoft This looks good. Please go ahead if you can get approval from Mike on Breaking Changes

"CheckResourceNameParameter": {
"description": "Resource object with values for resource name and resource type",
"in": "body",
Expand Down