[Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview #23745

koderjoker · 2023-04-27T08:07:21Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

… to version 2023-05-01-preview

openapi-workflow-bot · 2023-04-27T08:07:24Z

Hi, @koderjoker Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-27T08:07:25Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 16 Errors, 27 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
redis.json	2023-05-01-preview(d70671f)	2023-04-01(main)
redis.json	2023-05-01-preview(d70671f)	2019-07-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2169:11 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1900:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2169:11 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1900:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2169:11 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1900:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2732:7 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2467:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2707:7 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2438:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'storage-subscription-id' renamed or removed? New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2169:11 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1900:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L760:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L818:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L806:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L866:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L869:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L937:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L917:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L993:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L967:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1057:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1432:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1547:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1477:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1600:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1521:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1652:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1579:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1718:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1624:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L1771:11

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listUpgradeNotifications' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L103:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L155:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L354:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/Redis' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L394:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listKeys' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L427:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/regenerateKey' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L471:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/forceReboot' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L524:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/import' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L577:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/export' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L634:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L691:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules/{ruleName}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L739:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/patchSchedules' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L906:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/patchSchedules/{default}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L954:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers/{linkedServerName}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1142:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1304:5
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L61:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L106:11
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2242:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2242:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2242:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2242:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2249:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2249:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2249:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2249:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2245:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1485:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2530:5 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1708:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 2 Errors, 6 Warnings failed [Detail]

compared tags (via openapi-validator v2.0.1)	new version	base version
package-preview-2023-05	package-preview-2023-05(d70671f)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1708	RPC-Async-V1-01
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1916	RPC-Async-V1-01
⚠️ RequiredReadOnlySystemData	The response of operation:'AccessPolicy_CreateUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1708
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1708	RPC-Async-V1-06
⚠️ RequiredReadOnlySystemData	The response of operation:'AccessPolicy_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1824
⚠️ RequiredReadOnlySystemData	The response of operation:'AccessPolicyAssignment_CreateUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1916
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1916	RPC-Async-V1-06
⚠️ RequiredReadOnlySystemData	The response of operation:'AccessPolicyAssignment_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2032

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L57
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L73
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L173
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L285
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L299
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L333
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L630
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L670
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L689
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L729
`❌` ResourceNameRestriction	The resource name parameter 'ruleName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L793
`❌` TrackedResourcePatchOperation	Tracked resource 'RedisPatchSchedule' must have patch operation that at least supports the update of tags. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1000
`❌` ResourceNameRestriction	The resource name parameter 'linkedServerName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1194
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1195
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1262
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' . Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1420
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1465
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L1509
`❌` MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2125
`❌` MissingTypeObject	The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2165
`❌` MissingTypeObject	The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2306
`❌` MissingTypeObject	The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2338
`❌` MissingTypeObject	The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2353
`❌` ProvisioningStateValidation	ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2355
`❌` MissingTypeObject	The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2436
`❌` MissingTypeObject	The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2476
`❌` MissingTypeObject	The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2497
`❌` MissingTypeObject	The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2512
`❌` MissingTypeObject	The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2538
`❌` MissingTypeObject	The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/preview/2023-05-01-preview/redis.json#L2555

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-27T08:07:26Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Redis [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Redis.1.2.0-alpha.20230505.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-redis [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ExportRDBParameters has a new parameter storage_subscription_id
info	[Changelog]   - Model ImportRDBParameters has a new parameter storage_subscription_id
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter storage_subscription_id

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redis-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/redis/armredis [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `StorageSubscriptionID` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog] - New field `StorageSubscriptionID` in struct `ExportRDBParameters`
info	[Changelog] - New field `StorageSubscriptionID` in struct `ImportRDBParameters`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-rediscache [View full logs] [Release SDK Changes]

azure-arm-rediscache-7.2.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface ExportRDBParameters has a new optional parameter storageSubscriptionId
info	[Changelog]   - Interface ImportRDBParameters has a new optional parameter storageSubscriptionId
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter storageSubscriptionId

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 54cdb78. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️redis [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 54cdb78. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.redis.DefaultTag [View full logs]

Az.Redis.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.redis.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-27T08:07:26Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/redis/armredis	https://apiview.dev/Assemblies/Review/9e6608338000474dacc7616f1b83aecf
Java	azure-resourcemanager-redis-generated	https://apiview.dev/Assemblies/Review/2950c7b271fe4d14a2c86ae1a94159f7
.Net	Azure.ResourceManager.Redis	https://apiview.dev/Assemblies/Review/1f49d4823d5549aaaf594beebe9f5d38
JavaScript	@azure/arm-rediscache	https://apiview.dev/Assemblies/Review/a4048b7c5e704f8dbf3ee8e538994b8b

openapi-workflow-bot · 2023-04-27T08:14:40Z

Hi @koderjoker, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2023-04-27T08:16:00Z

Hi, @koderjoker your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json

koderjoker · 2023-05-04T05:40:32Z

@live1206 @raych1 could you please help us get the approved labels?

v-xuto · 2023-05-04T05:46:09Z

@raych1 Please help review Go breaking change.

v-xuto · 2023-05-05T03:27:10Z

@koderjoker Please resolve the conflict.

koderjoker · 2023-05-05T05:49:20Z

@v-xuto resolved the conflict

koderjoker and others added 7 commits April 27, 2023 12:09

Adds base for updating Microsoft.Cache from version stable/2022-06-01…

59ab42b

… to version 2023-05-01-preview

Updates readme

b5e7f37

Updates API version in new specs and examples

c7387e8

Take base changes from approved release branch 2023-05-01 preview

85ea26b

Update api version label to 2023-05-01-preview

8037093

Address PR suggestions from release branch

b758924

Spec validation correction

d43bb80

ghost added the Redis Cache label Apr 27, 2023

azure-sdk mentioned this pull request Apr 27, 2023

[AutoPR sdk/resourcemanager/redis/armredis] [Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview azure-sdk/azure-sdk-for-go#5533

Closed

koderjoker marked this pull request as ready for review April 27, 2023 08:14

koderjoker requested a review from TimLovellSmith as a code owner April 27, 2023 08:14

azure-sdk mentioned this pull request Apr 27, 2023

[AutoPR redis] [Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview azure-sdk/azure-resource-manager-schemas#2500

Closed

openapi-assignment-bot bot assigned ArcturusZhang Apr 27, 2023

AzureRestAPISpecReview added CI-FixRequiredOnFailure new-api-version resource-manager labels Apr 27, 2023

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 27, 2023

koderjoker mentioned this pull request Apr 27, 2023

Release redis microsoft.cache 2023-05-01 preview #23406

Closed

11 tasks

koderjoker requested a review from pilor April 27, 2023 08:22

qiaozha reviewed May 4, 2023

View reviewed changes

specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json Show resolved Hide resolved

qiaozha reviewed May 4, 2023

View reviewed changes

specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json Show resolved Hide resolved

Add add x-ms-parameter-location method

0dbb520

qiaozha removed the CI-BreakingChange-JavaScript label May 4, 2023

koderjoker force-pushed the koderjoker-redis-Microsoft.Cache-2023-05-01-preview branch from d97221d to 0dbb520 Compare May 5, 2023 05:19

Merge in latest main

0603cc2

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label May 5, 2023

Update redis readme

d70671f

AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels May 5, 2023

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label May 5, 2023

v-xuto removed the Approved-Avocado label May 5, 2023

v-xuto approved these changes May 5, 2023

View reviewed changes

v-xuto added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 5, 2023

ArcturusZhang approved these changes May 5, 2023

View reviewed changes

ArcturusZhang merged commit 54cdb78 into main May 5, 2023

ArcturusZhang deleted the koderjoker-redis-Microsoft.Cache-2023-05-01-preview branch May 5, 2023 07:12

openapi-pipeline-app bot added the Approved-Avocado label May 5, 2023

ajtiwari07 mentioned this pull request May 5, 2023

Update 2023-05-01-preview version with changes from 2023-04-01 version. #23835

Merged

11 tasks

mikekistler mentioned this pull request Aug 21, 2023

[Hub Generated] Review request for Microsoft.Cache to add version stable/2023-08-01 #25215

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview #23745

[Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview #23745

Uh oh!

koderjoker commented Apr 27, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

Uh oh!

Uh oh!

koderjoker commented May 4, 2023

Uh oh!

v-xuto commented May 4, 2023

Uh oh!

v-xuto commented May 5, 2023

Uh oh!

koderjoker commented May 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

[Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview #23745

[Hub Generated] Review request for Microsoft.Cache to add version preview/2023-05-01-preview #23745

Uh oh!

Conversation

koderjoker commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 27, 2023

Uh oh!

Uh oh!

Uh oh!

koderjoker commented May 4, 2023

Uh oh!

v-xuto commented May 4, 2023

Uh oh!

v-xuto commented May 5, 2023

Uh oh!

koderjoker commented May 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

koderjoker commented Apr 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 27, 2023 •

edited

Loading