-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2022-05-01 #22916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2022-05-01 #22916
Conversation
|
Hi, @abhayohri Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hey this request is to fix the following s360 items: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=260F1CBF-7480-46E2-B8E1-2C5C518FD39A The properties seem to have been added to the code but never made it to swagger events endpoints: added to response code on 5/16/2019 for all api version Availability status endpoints: (adding this last property seems to be triggering a linter exception for DefinitionsPropertiesNamesCamelCase but the name cannot be changed as it is been served to clients for years) I sent an email to breaking change team asking for guidance and they said to create the pr and that they would approve the fixes. for the other api versions should i create separate prs for each or can i update the within this pr? |
|
NewApiVersionRequired reason: |
|
Hi, @abhayohri your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
The main validation error I see is "Property name should be camel case." I assume that if this is a S360 fix, then that is by design? I don't see any other problem from API POV. |
@TimLovellSmith yeah its a fix for https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=647F3368-7670-4ADF-9D8D-6A6F02006D3F |
|
Hi @abhayohri, Your PR has some issues. Please fix the CI sequentially by following the order of
|
…rsion stable/2022-05-01 (Azure#22916) * make fixes for s360 items * spelling fix * added missing properties to all stable api versions * fix model validation errors
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.