Skip to content

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[Hub Generated] Review request for Microsoft.Network to update version preview/2021-02-01-preview for NSP Link feature #21617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bdf653
Update NSP Link Swagger
vineetmimrot Nov 21, 2022
4f9f6a3
fix model validation
vineetmimrot Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"resourceGroupName": "rg1",
"networkSecurityPerimeterName": "nsp1",
"profileName": "profile1",
"accessRuleName": "accessRule1",
Copy link
Contributor Author

@vineetmimrot vineetmimrot Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is done to fix model validation check . No change is made in its API swagger.

"parameters": {
"properties": {}
}
Expand Down
1 change: 1 addition & 0 deletions ...rk/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"provisioningState": "Succeeded",
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand Down
1 change: 1 addition & 0 deletions ...k/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"provisioningState": "Succeeded",
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand Down
2 changes: 2 additions & 0 deletions ...rk/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"provisioningState": "Succeeded",
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand All @@ -48,6 +49,7 @@
"provisioningState": "Succeeded",
"autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand Down
1 change: 1 addition & 0 deletions ...ce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"provisioningState": "Succeeded",
"remotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand Down
1 change: 1 addition & 0 deletions ...e-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"provisioningState": "Succeeded",
"remotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1",
"remotePerimeterGuid": "guid",
"remotePerimeterLocation": "westus2",
"localInboundProfiles": [
"*"
],
Expand Down
32 changes: 30 additions & 2 deletions ...source-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,24 @@
"modelAsString": true
}
},
"NSPLinkProvisioningState": {
"type": "string",
"readOnly": true,
"description": "The current provisioning state of NSP Link/LinkReference.",
"enum": [
"Succeeded",
"Creating",
"Updating",
"Deleting",
"Accepted",
"Failed",
"WaitForRemoteCompletion"
],
"x-ms-enum": {
"name": "nspLinkProvisioningState",
"modelAsString": true
}
},
"NspAccessRuleReconcile": {
"type": "object",
"properties": {},
Expand Down Expand Up @@ -1779,7 +1797,7 @@
"properties": {
"provisioningState": {
"readOnly": true,
"$ref": "#/definitions/NSPProvisioningState",
"$ref": "#/definitions/NSPLinkProvisioningState",
"description": "The provisioning state of the NSP Link resource."
},
"autoApprovedRemotePerimeterResourceId": {
Expand All @@ -1795,6 +1813,11 @@
"type": "string",
"description": "Remote NSP Guid with which the link gets created."
},
"remotePerimeterLocation": {
"readOnly": true,
"type": "string",
"description": "Remote NSP location with which the link gets created."
},
"localInboundProfiles": {
"type": "array",
"items": {
Expand Down Expand Up @@ -1889,7 +1912,7 @@
"properties": {
"provisioningState": {
"readOnly": true,
"$ref": "#/definitions/NSPProvisioningState",
"$ref": "#/definitions/NSPLinkProvisioningState",
"description": "The provisioning state of the NSP LinkReference resource."
},
"remotePerimeterResourceId": {
Expand All @@ -1902,6 +1925,11 @@
"type": "string",
"description": "Remote NSP Guid with which the link is created."
},
"remotePerimeterLocation": {
"readOnly": true,
"type": "string",
"description": "Remote NSP location with which the link gets created."
},
"localInboundProfiles": {
"type": "array",
"items": {
Expand Down