Skip to content

[Hub Generated] Review request for Microsoft.Devices to add version preview/2022-11-01-preview #21547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Hub Generated] Review request for Microsoft.Devices to add version preview/2022-11-01-preview #21547

wants to merge 4 commits into from

Conversation

@vikramadityab72
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vikramadityab72 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 14, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.2)] new version base version
    iothub.json 2022-11-01-preview(0b16a99) 2021-07-02(main)
    iothub.json 2022-11-01-preview(0b16a99) 2022-04-30-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-11 package-preview-2022-11(0b16a99) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L2468


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Devices/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L60
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L64
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L76
    ❌ ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L76
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L110
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L119
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L181
    ❌ PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L221
    ❌ PatchSkuProperty The patch operation body parameter schema should contains property 'sku'.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L221
    ❌ LroPatch202 The async patch operation should return 202.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L234
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L234
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L255
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L284
    ❌ DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L297
    ❌ MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L304
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L310
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L320
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L348
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L361
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L392
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubStats'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L405
    ❌ ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L405
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L439
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/skus'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L449
    ❌ ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L449
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L483
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/eventHubEndpoints/{eventHubEndpointName}/ConsumerGroups'
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L496
    ❌ ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L496
    ❌ ResourceNameRestriction The resource name parameter 'eventHubEndpointName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L496
    ❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-11-01-preview/iothub.json#L537
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Devices' for api version '2022-11-01-preview'. The supported api-versions are '2015-08-15-preview,
    2016-02-03,
    2017-01-19,
    2017-07-01,
    2018-01-22,
    2018-04-01,
    2018-12-01-preview,
    2019-03-22-preview,
    2019-03-22,
    2019-07-01-preview,
    2019-11-04,
    2020-03-01,
    2020-04-01,
    2020-06-15,
    2020-07-10-preview,
    2020-08-01,
    2020-08-31-preview,
    2020-08-31,
    2021-02-01-preview,
    2021-03-03-preview,
    2021-03-31,
    2021-07-01-preview,
    2021-07-01,
    2021-07-02-preview,
    2021-07-02,
    2022-04-30-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 14, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.IotHub [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-iothub [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/iothub/armiothub [View full logs]  [Preview SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `RoutingSourceDigitalTwinChangeEvents`
info	[Changelog] - New const `RoutingSourceMqttBrokerMessages`
info	[Changelog] - New struct `EncryptionPropertiesDescription`
info	[Changelog] - New struct `KeyVaultKeyProperties`
info	[Changelog] - New struct `PropertiesDeviceStreams`
info	[Changelog] - New struct `RootCertificateProperties`
info	[Changelog] - New struct `RoutingCosmosDBSQLAPIProperties`
info	[Changelog] - New field `CosmosDBSQLCollections` in struct `RoutingEndpoints`
info	[Changelog] - New field `Encryption` in struct `Properties`
info	[Changelog] - New field `RootCertificate` in struct `Properties`
info	[Changelog] - New field `DeviceStreams` in struct `Properties`
info	[Changelog] - New field `AllowDataPlanePreviewFeatures` in struct `Properties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 14 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-iothub [View full logs]  [Preview SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface EncryptionPropertiesDescription
info	[Changelog]   - Added Interface IotHubManualFailoverHeaders
info	[Changelog]   - Added Interface IotHubPropertiesDeviceStreams
info	[Changelog]   - Added Interface IotHubResourceCreateOrUpdateHeaders
info	[Changelog]   - Added Interface IotHubResourceDeleteHeaders
info	[Changelog]   - Added Interface IotHubResourceUpdateHeaders
info	[Changelog]   - Added Interface KeyVaultKeyProperties
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
info	[Changelog]   - Added Interface PrivateEndpointConnectionsUpdateHeaders
info	[Changelog]   - Added Interface RootCertificateProperties
info	[Changelog]   - Added Interface RoutingCosmosDBSqlApiProperties
info	[Changelog]   - Interface IotHubProperties has a new optional parameter allowDataPlanePreviewFeatures
info	[Changelog]   - Interface IotHubProperties has a new optional parameter deviceStreams
info	[Changelog]   - Interface IotHubProperties has a new optional parameter encryption
info	[Changelog]   - Interface IotHubProperties has a new optional parameter rootCertificate
info	[Changelog]   - Interface RoutingEndpoints has a new optional parameter cosmosDBSqlCollections
info	[Changelog]   - Add parameters of IotHubResourceUpdateHeaders to TypeAlias IotHubResourceUpdateResponse
info	[Changelog]   - Enum KnownRoutingSource has a new value DigitalTwinChangeEvents
info	[Changelog]   - Enum KnownRoutingSource has a new value MqttBrokerMessages
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️iothub [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs] Generate from 862ab058af4a9183577c94444c51b97ffffabc5e. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 14, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.Devices Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/iothub/armiothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.IotHub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the IoTHub label Nov 14, 2022
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2022
    This was referenced Nov 14, 2022
    Closed
    Draft
    Closed
    Closed
    Closed
    Closed
    TimLovellSmith
    TimLovellSmith approved these changes Nov 19, 2022
    View reviewed changes
    Copy link
    Member

    @TimLovellSmith TimLovellSmith left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 19, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2022
    @ghost
    Copy link

    ghost commented Dec 4, 2022

    Hi, @vikramadityab72. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Dec 4, 2022
    @ghost ghost closed this Dec 19, 2022
    @ghost
    Copy link

    ghost commented Dec 19, 2022

    Hi, @vikramadityab72. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @TimLovellSmith TimLovellSmith TimLovellSmith approved these changes

    @rkmanda rkmanda Awaiting requested review from rkmanda rkmanda is a code owner

    Assignees

    @ruowan ruowan

    Labels

    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review IoTHub new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @vikramadityab72 @TimLovellSmith @ruowan @AzureRestAPISpecReview