Skip to content

Conversation

@sougatac
Copy link
Contributor

@sougatac sougatac commented Nov 8, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@sougatac
Copy link
Contributor Author

sougatac commented Nov 8, 2022

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/9583

@openapi-workflow-bot
Copy link

Hi, @sougatac Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 8, 2022

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.1)] new version base version
    datafactory.json 2018-06-01(e67a729) 2018-06-01(main)
    Rule Message
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3965:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4010:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2018-06 package-2018-06(e67a729) package-2018-06(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7303
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'credentials' with immediate parent 'Factory', must have a list by immediate parent operation.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7294


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5074
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6283
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6408
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6867
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6871
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6903
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7028
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7122
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7126
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7142
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L36
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4760
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4801
    R4037 - MissingTypeObject The schema 'SubResourceDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4827
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4958
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4958
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4958
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4982
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4999
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeStatusResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5016
    R4037 - MissingTypeObject The schema 'FactoryRepoUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5513
    R4037 - MissingTypeObject The schema 'GitHubAccessTokenRequest' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5526
    R4037 - MissingTypeObject The schema 'GitHubAccessTokenResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5551
    R4037 - MissingTypeObject The schema 'UserAccessPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5560
    R4037 - MissingTypeObject The schema 'AccessPolicyResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5585
    R4037 - MissingTypeObject The schema 'FactoryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5602
    R4037 - MissingTypeObject The schema 'EncryptionConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5669
    R4037 - MissingTypeObject The schema 'CMKIdentityDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5694
    R4037 - MissingTypeObject The schema 'PipelineReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5762
    R4037 - MissingTypeObject The schema 'PipelineReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5762
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1168:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1217:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1497:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1168:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1217:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1497:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 8, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/datafactory/armdatafactory - 3.0.0
    +	Type of `SynapseSparkJobReference.ReferenceName` has been changed from `*string` to `interface{}`


    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:698
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 698 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.DataFactory [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.19.2 -> 8.19.3
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.3>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group CredentialOperationsOperations
      info	[Changelog]   - Model ScriptActivity has a new parameter script_block_execution_timeout
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datafactory/armdatafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SynapseSparkJobReference.ReferenceName` has been changed from `*string` to `interface{}`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*ServicePrincipalCredential.GetCredential() *Credential`
      info	[Changelog] - New function `NewCredentialOperationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CredentialOperationsClient, error)`
      info	[Changelog] - New function `*CredentialOperationsClient.CreateOrUpdate(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions) (CredentialOperationsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ManagedIdentityCredential.GetCredential() *Credential`
      info	[Changelog] - New function `*Credential.GetCredential() *Credential`
      info	[Changelog] - New function `*CredentialOperationsClient.NewListByFactoryPager(string, string, *CredentialOperationsClientListByFactoryOptions) *runtime.Pager[CredentialOperationsClientListByFactoryResponse]`
      info	[Changelog] - New function `*CredentialOperationsClient.Get(context.Context, string, string, string, *CredentialOperationsClientGetOptions) (CredentialOperationsClientGetResponse, error)`
      info	[Changelog] - New function `*CredentialOperationsClient.Delete(context.Context, string, string, string, *CredentialOperationsClientDeleteOptions) (CredentialOperationsClientDeleteResponse, error)`
      info	[Changelog] - New struct `Credential`
      info	[Changelog] - New struct `CredentialListResponse`
      info	[Changelog] - New struct `CredentialOperationsClient`
      info	[Changelog] - New struct `CredentialOperationsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `CredentialOperationsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `CredentialOperationsClientDeleteOptions`
      info	[Changelog] - New struct `CredentialOperationsClientDeleteResponse`
      info	[Changelog] - New struct `CredentialOperationsClientGetOptions`
      info	[Changelog] - New struct `CredentialOperationsClientGetResponse`
      info	[Changelog] - New struct `CredentialOperationsClientListByFactoryOptions`
      info	[Changelog] - New struct `CredentialOperationsClientListByFactoryResponse`
      info	[Changelog] - New struct `ManagedIdentityCredential`
      info	[Changelog] - New struct `ManagedIdentityCredentialResource`
      info	[Changelog] - New struct `ManagedIdentityTypeProperties`
      info	[Changelog] - New struct `ServicePrincipalCredential`
      info	[Changelog] - New struct `ServicePrincipalCredentialTypeProperties`
      info	[Changelog] - New field `DisablePublish` in struct `FactoryGitHubConfiguration`
      info	[Changelog] - New field `ScriptBlockExecutionTimeout` in struct `ScriptActivityTypeProperties`
      info	[Changelog] - New field `DisablePublish` in struct `FactoryVSTSConfiguration`
      info	[Changelog] - New field `DisablePublish` in struct `FactoryRepoConfiguration`
      info	[Changelog] - New field `WorkspaceResourceID` in struct `AzureSynapseArtifactsLinkedServiceTypeProperties`
      info	[Changelog] - New field `PythonCodeReference` in struct `SynapseSparkJobActivityTypeProperties`
      info	[Changelog] - New field `FilesV2` in struct `SynapseSparkJobActivityTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 47 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group CredentialOperations
      info	[Changelog]   - Added Interface CredentialListResponse
      info	[Changelog]   - Added Interface CredentialOperationsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface CredentialOperationsDeleteOptionalParams
      info	[Changelog]   - Added Interface CredentialOperationsGetOptionalParams
      info	[Changelog]   - Added Interface CredentialOperationsListByFactoryNextOptionalParams
      info	[Changelog]   - Added Interface CredentialOperationsListByFactoryOptionalParams
      info	[Changelog]   - Added Interface ManagedIdentityCredentialResource
      info	[Changelog]   - Added Type Alias CredentialOperationsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias CredentialOperationsGetResponse
      info	[Changelog]   - Added Type Alias CredentialOperationsListByFactoryNextResponse
      info	[Changelog]   - Added Type Alias CredentialOperationsListByFactoryResponse
      info	[Changelog]   - Interface ScriptActivity has a new optional parameter scriptBlockExecutionTimeout
      info	[Changelog]   - Class DataFactoryManagementClient has a new parameter credentialOperations
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a7ae206. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from a7ae206. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.datafactory [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 8, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datafactory/armdatafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-datafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-datafactory Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @sougatac, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @leniatgh leniatgh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation labels Nov 8, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2022
    @leniatgh leniatgh merged commit a7ae206 into main Nov 8, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    …_Swagger' (Azure#21460)
    
    * [AutoSync] d54a7e8518 Swagger update for Credential - Register Credential API-s
    
    * [AutoSync] 03b2cb0141 Add referenced payload and response example files
    
    * [AutoSync] 1ab6348327 Add credential definition
    
    * [AutoSync] 0d9b0cea02 Fix duplicate key issue
    
    * [AutoSync] 6565da4d52 Fix missing quote
    
    * [AutoSync] f6049ee8ef Add ref for Credential Name
    
    * [AutoSync] 2f9d1ef4d6 Add type and update references
    
    * [AutoSync] 1095d23613 Fix prettier check
    
    Co-authored-by: swagger-automation <[email protected]>
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    …_Swagger' (Azure#21460)
    
    * [AutoSync] d54a7e8518 Swagger update for Credential - Register Credential API-s
    
    * [AutoSync] 03b2cb0141 Add referenced payload and response example files
    
    * [AutoSync] 1ab6348327 Add credential definition
    
    * [AutoSync] 0d9b0cea02 Fix duplicate key issue
    
    * [AutoSync] 6565da4d52 Fix missing quote
    
    * [AutoSync] f6049ee8ef Add ref for Credential Name
    
    * [AutoSync] 2f9d1ef4d6 Add type and update references
    
    * [AutoSync] 1095d23613 Fix prettier check
    
    Co-authored-by: swagger-automation <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-FixRequiredOnFailure Data Factory NewApiVersionRequired resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants