-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add Replicas_ListByServer to postgres flexible server 2022-03-08-preview #21424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ruowan
merged 5 commits into
Azure:main
from
alanenriqueo:postgresql-flex-add-replicas_listbyserver
Nov 14, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b9dbea9
Add Replicas_ListByServer to postgres package-flexibleserver-2022-03-…
alanenriqueo 5b0c90b
Fix lintDiff
alanenriqueo d350c2a
Fix lintDiff
alanenriqueo 6c5c214
Move Replicas_ListByServer to Replicas.json
alanenriqueo ef004ed
Add 202 response to Administrators_Create
alanenriqueo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
...resql/resource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Replicas.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "title": "PostgreSQLServerManagementClient", | ||
| "description": "The Microsoft Azure management API provides create, read, update, and delete functionality for Azure PostgreSQL resources including servers, databases, firewall rules, VNET rules, security alert policies, log files and configurations with new business model.", | ||
| "version": "2022-03-08-preview" | ||
| }, | ||
| "host": "management.azure.com", | ||
| "schemes": [ | ||
| "https" | ||
| ], | ||
| "consumes": [ | ||
| "application/json" | ||
| ], | ||
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "security": [ | ||
| { | ||
| "azure_auth": [ | ||
| "user_impersonation" | ||
| ] | ||
| } | ||
| ], | ||
| "securityDefinitions": { | ||
| "azure_auth": { | ||
| "type": "oauth2", | ||
| "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
| "flow": "implicit", | ||
| "description": "Azure Active Directory OAuth2 Flow", | ||
| "scopes": { | ||
| "user_impersonation": "impersonate your user account" | ||
| } | ||
| } | ||
| }, | ||
| "paths": { | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/flexibleServers/{serverName}/replicas": { | ||
| "get": { | ||
| "tags": [ | ||
| "Replicas" | ||
| ], | ||
| "operationId": "Replicas_ListByServer", | ||
| "x-ms-examples": { | ||
| "ReplicasListByServer": { | ||
| "$ref": "./examples/ReplicasListByServer.json" | ||
| } | ||
| }, | ||
| "description": "List all the replicas for a given server.", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "$ref": "./common-types.json#/parameters/ServerNameParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "./FlexibleServers.json#/definitions/ServerListResult" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": null | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,7 @@ | |
| "name": "[email protected]", | ||
| "type": "Microsoft.DBforPostgreSQL/flexibleServers/administrators" | ||
| } | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } | ||
66 changes: 66 additions & 0 deletions
66
...r/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/examples/ReplicasListByServer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| { | ||
| "parameters": { | ||
| "serverName": "sourcepgservername", | ||
| "resourceGroupName": "testrg", | ||
| "api-version": "2022-03-08-preview", | ||
| "subscriptionId": "ffffffff-ffff-ffff-ffff-ffffffffffff" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "sku": { | ||
| "name": "Standard_D4s_v3", | ||
| "tier": "GeneralPurpose" | ||
| }, | ||
| "properties": { | ||
| "fullyQualifiedDomainName": "pgtestsvc5rep.postgres.database.azure.com", | ||
| "version": "12", | ||
| "minorVersion": "6", | ||
| "administratorLogin": "cloudsa", | ||
| "state": "Ready", | ||
| "availabilityZone": "2", | ||
| "storage": { | ||
| "storageSizeGB": 512 | ||
| }, | ||
| "dataEncryption": { | ||
| "type": "SystemManaged" | ||
| }, | ||
| "authConfig": { | ||
| "activeDirectoryAuthEnabled": false | ||
| }, | ||
| "backup": { | ||
| "backupRetentionDays": 7, | ||
| "geoRedundantBackup": "Disabled", | ||
| "earliestRestoreDate": "2021-05-27T00:28:17.7279547+00:00" | ||
| }, | ||
| "network": { | ||
| "publicNetworkAccess": "Enabled" | ||
| }, | ||
| "highAvailability": { | ||
| "mode": "Disabled", | ||
| "state": "NotEnabled" | ||
| }, | ||
| "maintenanceWindow": { | ||
| "customWindow": "Disabled", | ||
| "dayOfWeek": 0, | ||
| "startHour": 0, | ||
| "startMinute": 0 | ||
| }, | ||
| "replicationRole": "AsyncReplica", | ||
| "replicaCapacity": 0 | ||
| }, | ||
| "location": "westus", | ||
| "tags": { | ||
| "ElasticServer": "1" | ||
| }, | ||
| "id": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.DBforPostgreSQL/flexibleServers/pgtestsvc5rep", | ||
| "name": "pgtestsvc5rep", | ||
| "type": "Microsoft.DBforPostgreSQL/flexibleServers" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT MUST not return a 202
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our RP we have a lot of PUT operations that return 202. We'll fix it later, but for now we need to keep 202 in this API, and we've had this issue before: #21234 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkmanda looped you in the chat history we had earlier with Tim during earlier review regarding PUT calls returning 202.