Skip to content

Conversation

@sumitkumams
Copy link
Contributor

Reverts #20675

These changes are just for preview now, it's not the final one.

Please revert it ASAP.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 23, 2022

Swagger Validation Report

️❌BreakingChange: 11 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.9.7)] new version base version
2022-08-01-privatepreview 2022-08-01-privatepreview(566b668) 2022-08-01-privatepreview(main)
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/backupAndExport' removed or restructured?
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L34:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/validateBackup' removed or restructured?
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L92:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BackupAndExportRequest' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L25:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L144:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ValidateBackupRequest' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L25:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L144:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BackupStoreDetails' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L25:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L144:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'FullBackupStoreDetails' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L25:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L144:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BackupSettings' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L25:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L144:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ServerNameParameter' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?
New: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
Old: Microsoft.DBforMySQL/preview/2022-08-01-privatepreview/BackupAndExport.json#L23:3
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v1.13.0) new version base version
default default(566b668) default(main)
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/mysql/resource-manager/readme.md
tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️~[Staging] TrafficValidation succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @sumitkumams Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 23, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/mysql/armmysql - 2.0.0
    +	Struct `CloudError` has been removed
    azure-sdk-for-go - sdk/resourcemanager/mysql/armmysqlflexibleservers - 2.0.0-beta.1
    +	Struct `CloudError` has been removed

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 1d9c9c6. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 515 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.MySql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.MySql.FlexibleServers.Models.MySqlFlexibleServerNameAvailabilityContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/mysql/Azure.ResourceManager.MySql/src/Azure.ResourceManager.MySql.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.MySql/Debug/netstandard2.0/Azure.ResourceManager.MySql.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/mysql/Azure.ResourceManager.MySql/src/Azure.ResourceManager.MySql.csproj]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1d9c9c6. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1d9c9c6. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mysql/armmysql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/mysql/armmysqlflexibleservers [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `AdministratorTypeActiveDirectory`
      info	[Changelog] - New const `ResetAllToDefaultFalse`
      info	[Changelog] - New const `ResetAllToDefaultTrue`
      info	[Changelog] - New const `AdministratorNameActiveDirectory`
      info	[Changelog] - New type alias `AdministratorName`
      info	[Changelog] - New type alias `AdministratorType`
      info	[Changelog] - New type alias `ResetAllToDefault`
      info	[Changelog] - New function `NewCheckNameAvailabilityWithoutLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CheckNameAvailabilityWithoutLocationClient, error)`
      info	[Changelog] - New function `PossibleResetAllToDefaultValues() []ResetAllToDefault`
      info	[Changelog] - New function `PossibleAdministratorNameValues() []AdministratorName`
      info	[Changelog] - New function `*LogFilesClient.NewListByServerPager(string, string, *LogFilesClientListByServerOptions) *runtime.Pager[LogFilesClientListByServerResponse]`
      info	[Changelog] - New function `NewAzureADAdministratorsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureADAdministratorsClient, error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.NewListByServerPager(string, string, *AzureADAdministratorsClientListByServerOptions) *runtime.Pager[AzureADAdministratorsClientListByServerResponse]`
      info	[Changelog] - New function `NewLogFilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LogFilesClient, error)`
      info	[Changelog] - New function `*BackupsClient.Put(context.Context, string, string, string, *BackupsClientPutOptions) (BackupsClientPutResponse, error)`
      info	[Changelog] - New function `PossibleAdministratorTypeValues() []AdministratorType`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginDelete(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientBeginDeleteOptions) (*runtime.Poller[AzureADAdministratorsClientDeleteResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginCreateOrUpdate(context.Context, string, string, AdministratorName, AzureADAdministrator, *AzureADAdministratorsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureADAdministratorsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.Get(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientGetOptions) (AzureADAdministratorsClientGetResponse, error)`
      info	[Changelog] - New function `*CheckNameAvailabilityWithoutLocationClient.Execute(context.Context, NameAvailabilityRequest, *CheckNameAvailabilityWithoutLocationClientExecuteOptions) (CheckNameAvailabilityWithoutLocationClientExecuteResponse, error)`
      info	[Changelog] - New struct `AdministratorListResult`
      info	[Changelog] - New struct `AdministratorProperties`
      info	[Changelog] - New struct `AzureADAdministrator`
      info	[Changelog] - New struct `AzureADAdministratorsClient`
      info	[Changelog] - New struct `AzureADAdministratorsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `AzureADAdministratorsClientBeginDeleteOptions`
      info	[Changelog] - New struct `AzureADAdministratorsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `AzureADAdministratorsClientDeleteResponse`
      info	[Changelog] - New struct `AzureADAdministratorsClientGetOptions`
      info	[Changelog] - New struct `AzureADAdministratorsClientGetResponse`
      info	[Changelog] - New struct `AzureADAdministratorsClientListByServerOptions`
      info	[Changelog] - New struct `AzureADAdministratorsClientListByServerResponse`
      info	[Changelog] - New struct `BackupsClientPutOptions`
      info	[Changelog] - New struct `BackupsClientPutResponse`
      info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClient`
      info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClientExecuteOptions`
      info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClientExecuteResponse`
      info	[Changelog] - New struct `LogFile`
      info	[Changelog] - New struct `LogFileListResult`
      info	[Changelog] - New struct `LogFileProperties`
      info	[Changelog] - New struct `LogFilesClient`
      info	[Changelog] - New struct `LogFilesClientListByServerOptions`
      info	[Changelog] - New struct `LogFilesClientListByServerResponse`
      info	[Changelog] - New field `ResetAllToDefault` in struct `ConfigurationListForBatchUpdate`
      info	[Changelog] - New field `Version` in struct `ServerPropertiesForUpdate`
      info	[Changelog] - New field `Location` in struct `VirtualNetworkSubnetUsageResult`
      info	[Changelog] - New field `SubscriptionID` in struct `VirtualNetworkSubnetUsageResult`
      info	[Changelog] - New field `Keyword` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Page` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `PageSize` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Tags` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 70 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1d9c9c6. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1d9c9c6. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️mysql [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 1d9c9c6. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 23, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mysql/armmysql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/mysql/armmysqlflexibleservers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-rdbms Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-mysqlflexibleserver Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.MySql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 23, 2022
    @ghost
    Copy link

    ghost commented Sep 23, 2022

    Thank you for your contribution sumitkumams! We will review the pull request and get back to you soon.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    CI-BreakingChange-Go customer-reported Issues that are reported by GitHub users external to the Azure organization. MySQL ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants