[Compute] Disk 2022-03-02 #19116
Merged
[Compute] Disk 2022-03-02 #19116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update diskRPCommon.json * Update diskRPCommon.json
* add cross-tenant feature * fix filename typo * prettier
* Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <[email protected]>
…Disk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <[email protected]>
* add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties
* add cross-tenant feature * fix filename typo * prettier
* Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <[email protected]>
…Disk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <[email protected]>
* add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties
|
Hi, @haagha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-02 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 49 Errors, 20 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:2022-03-02/DiskRP/disk.json compared with base:stable/2021-12-01/disk.json
- current:2022-03-02/DiskRP/disk.json compared with base:preview/2016-04-30-preview/disk.json
- current:stable/2022-03-02/common.json compared with base:stable/2022-03-01/common.json
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L444:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L630:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L666:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/beginGetAccess' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L699:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/endGetAccess' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L751:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskEncryptionSets/{diskEncryptionSetName}' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L791:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskEncryptionSets' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1001:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/diskEncryptionSets' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1043:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskEncryptionSets/{diskEncryptionSetName}/associatedResources' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1082:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskAccesses/{diskAccessName}' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1127:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskAccesses' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1328:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/diskAccesses' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1370:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskAccesses/{diskAccessName}/privateLinkResources' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1409:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskAccesses/{diskAccessName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1445:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/diskAccesses/{diskAccessName}/privateEndpointConnections' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1596:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/restorePointCollections/{restorePointCollectionName}/restorePoints/{vmRestorePointName}/diskRestorePoints/{diskRestorePointName}' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1641:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/restorePointCollections/{restorePointCollectionName}/restorePoints/{vmRestorePointName}/diskRestorePoints' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1692:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/restorePointCollections/{restorePointCollectionName}/restorePoints/{vmRestorePointName}/diskRestorePoints/{diskRestorePointName}/beginGetAccess' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1740:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/restorePointCollections/{restorePointCollectionName}/restorePoints/{vmRestorePointName}/diskRestorePoints/{diskRestorePointName}/endGetAccess' removed or restructured? Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1804:5 |
|
The new version is missing a definition that was found in the old version. Was 'SnapshotSku' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'SnapshotProperties' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'EncryptionSetProperties' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'KeyForDiskEncryptionSet' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'DiskEncryptionSetType' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'SnapshotUpdateProperties' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'DiskEncryptionSetUpdateProperties' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'Snapshot' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'SnapshotUpdate' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'EncryptionSetIdentity' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
|
The new version is missing a definition that was found in the old version. Was 'DiskEncryptionSet' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/stable/2021-12-01/disk.json#L1857:3 |
The following breaking changes are detected by comparison with latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L368:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L541:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/snapshots' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L577:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/beginGetAccess' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L610:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/snapshots/{snapshotName}/endGetAccess' removed or restructured? Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L654:5 |
|
| The new version is missing a definition that was found in the old version. Was 'EncryptionSettings' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L693:3 |
|
| The new version is missing a definition that was found in the old version. Was 'Snapshot' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L693:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SnapshotUpdate' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L457:3 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L693:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'SnapshotNameParameter' removed or renamed? New: stable/2022-03-02/DiskRP/disk.json#L863:3 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L1201:3 |
|
| The new version has a different 'allOf' property than the previous one. New: stable/2022-03-02/DiskRP/disk.json#L171:13 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L108:13 |
|
| The new version has a different 'allOf' property than the previous one. New: stable/2022-03-02/DiskRP/disk.json#L499:5 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L755:5 |
|
| The new version is missing a property found in the old version. Was 'accountType' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L595:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L789:7 |
|
| The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L595:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L789:7 |
|
| The new version is missing a property found in the old version. Was 'ownerId' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L595:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L789:7 |
|
| The new version is missing a property found in the old version. Was 'accountType' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L752:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L910:7 |
|
| The new version is missing a property found in the old version. Was 'creationData' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L752:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L910:7 |
|
| The new version is missing a property found in the old version. Was 'encryptionSettings' renamed or removed? New: stable/2022-03-02/DiskRP/disk.json#L752:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L910:7 |
|
| The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: stable/2022-03-02/DiskRP/diskRPCommon.json#L546:7 Old: Microsoft.Compute/preview/2016-04-30-preview/disk.json#L1034:7 |
| Rule | Message |
|---|---|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:DiskRestorePoint_RevokeAccess;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/diskRestorePoint.json" |
|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:Snapshots_RevokeAccess;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/snapshot.json" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- compute/resource-manager/readme.md#package-2022-01-03
- compute/resource-manager/readme.md#package-2022-01-03-only
- compute/resource-manager/readme.md#package-2022-03-01
- compute/resource-manager/readme.md#package-2022-03-01-only
- compute/resource-manager/readme.md#package-2022-03-02
- compute/resource-manager/readme.md#package-2022-03-02-only
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
haagha
requested review from
ArcturusZhang,
MS-syh2qs,
Sandido,
dkulkarni-ms,
grizzlytheodore,
hyonholee and
madewithsmiles
as code owners
Co-authored-by: Karan Manish Thakkar <[email protected]>
…st-api-specs into diskrp-2022-03-02
ArcturusZhang
approved these changes
May 30, 2022
|
The cross-version breaking change is not working since the structure of the swagger files has been changed |
This was referenced May 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.