-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update resource association swagger #18432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
204a07a
update access mode values
bbbc594
update examples
782579a
Add 202 in delete spec
2569e4a
Add provisioning issues changes
e3c2462
update schema
f87f480
review changs
42d3ac4
update
69b4b9b
typo in model fix
2c1d1da
make provisioning issues readonly
ec28bd6
Add one example in list association, provisioning state enum update
3a066d9
Add logggin categories in profile
a956cdf
examples update
b0d7f87
update
9b51e98
update examples
aeb90a3
reformat code
21a01b1
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
ab52ce4
Add x-msidentifier for logger
726f3b8
update
13ed110
provisioning state fix
8cd0af0
Fix provisioning state
7498882
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
8d48fe1
Add location header in delete nsp association
4a12dab
update location header
fc6f224
update location header
134bcd8
location header update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -668,6 +668,15 @@ | |
| "200": { | ||
| "description": "Delete Succeed." | ||
| }, | ||
| "202": { | ||
| "description": "Delete in progress.", | ||
| "headers": { | ||
| "location": { | ||
| "description": "location header", | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "204": { | ||
| "description": "Request successful. The resource does not exist." | ||
| }, | ||
|
|
@@ -678,6 +687,7 @@ | |
| } | ||
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-examples": { | ||
| "NspAssociationDelete": { | ||
| "$ref": "./examples/NspAssociationDelete.json" | ||
|
|
@@ -846,7 +856,7 @@ | |
| }, | ||
| "provisioningState": { | ||
| "readOnly": true, | ||
| "$ref": "./network.json#/definitions/ProvisioningState", | ||
| "$ref": "#/definitions/NSPProvisioningState", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the difference between these two provisioningState?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NSPProvisioningState has two extra field: Accepting, Created. |
||
| "description": "The provisioning state of the scope assignment resource." | ||
| } | ||
| }, | ||
|
|
@@ -906,6 +916,16 @@ | |
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "Version number that increases with every update to access rules within the profile." | ||
| }, | ||
| "enabledLogCategories": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/LoggingCategory" | ||
| }, | ||
| "x-ms-identifiers": [ | ||
| "name" | ||
| ], | ||
| "description": "Gets the enabled log categories." | ||
| } | ||
| }, | ||
| "description": "Properties of NSP profile." | ||
|
|
@@ -962,7 +982,7 @@ | |
| "properties": { | ||
| "provisioningState": { | ||
| "readOnly": true, | ||
| "$ref": "./network.json#/definitions/ProvisioningState", | ||
| "$ref": "#/definitions/NSPProvisioningState", | ||
| "description": "The provisioning state of the scope assignment resource." | ||
| }, | ||
| "direction": { | ||
|
|
@@ -1080,7 +1100,7 @@ | |
| "properties": { | ||
| "provisioningState": { | ||
| "readOnly": true, | ||
| "$ref": "./network.json#/definitions/ProvisioningState", | ||
| "$ref": "#/definitions/NSPProvisioningState", | ||
| "description": "The provisioning state of the resource association resource." | ||
| }, | ||
| "privateLinkResource": { | ||
|
|
@@ -1094,16 +1114,20 @@ | |
| "accessMode": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "Unspecified", | ||
| "EnforceMode", | ||
| "LearningMode", | ||
| "DryRunMode" | ||
| "Learning", | ||
| "Enforced", | ||
| "Audit" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "AssociationAccessMode", | ||
| "modelAsString": true | ||
| }, | ||
| "description": "Access mode on the association." | ||
| }, | ||
| "hasProvisioningIssues": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "Specifies if there are provisioning issues" | ||
| } | ||
| } | ||
| }, | ||
|
|
@@ -1177,6 +1201,33 @@ | |
| } | ||
| }, | ||
| "description": "Properties of the perimeter associable resources." | ||
| }, | ||
| "LoggingCategory": { | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "type": "string", | ||
| "description": "The name of the logging category." | ||
| } | ||
| }, | ||
| "description": "Logging Category" | ||
| }, | ||
| "NSPProvisioningState": { | ||
| "type": "string", | ||
| "readOnly": true, | ||
| "description": "The current provisioning state.", | ||
| "enum": [ | ||
| "Succeeded", | ||
| "Creating", | ||
| "Updating", | ||
| "Deleting", | ||
| "Accepted", | ||
| "Failed" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "nspProvisioningState", | ||
| "modelAsString": true | ||
| } | ||
| } | ||
| }, | ||
| "parameters": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.