Dev desktopvirtualization microsoft.desktop virtualization 2022 02 10 preview #17807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review/2021-09-03-preview to version 2022-02-10-preview
|
Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 10, 2022
sampa-msft
approved these changes
Feb 10, 2022
datr93
force-pushed
the
dev-desktopvirtualization-Microsoft.DesktopVirtualization-2022-02-10-preview
branch
from
5f23472 to
405d5b4
Compare
datr93
force-pushed
the
dev-desktopvirtualization-Microsoft.DesktopVirtualization-2022-02-10-preview
branch
from
405d5b4 to
9b18345
Compare
|
Hi @datr93, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
- added the read only collection array of private endpoint connections to hostpool & workspace
- added new enum values for hostpool
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
JeffreyRichter
added
the
Approved-BreakingChange
j5lim
added
ARMSignedOff
This was referenced Mar 1, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 1, 2022
….desktop virtualization 2022 02 10 preview (#2217) Create to sync Azure/azure-rest-api-specs#17807 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/desktopvirtualization?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
… preview (Azure#17807) * Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-09-03-preview to version 2022-02-10-preview * Updates readme * Updates API version in new specs and examples * add agent update properties * change parameter length restrictions * fix identifiers * change mininum for scaling * - added new enum values for hostpool - added the read only collection array of private endpoint connections to hostpool & workspace * friendly name * remove length requiremetns * split patch properties Co-authored-by: Paul McDaniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.