Skip to content

Conversation

@a-santamaria
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'OperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L631


    The following errors/warnings exist before current PR submission:

    Rule Message
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1228
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1507
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1869
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1984
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2067
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1124
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1135
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1142
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1153
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1204
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1220
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1227
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1611
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1729
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L762
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L770
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L792
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L799
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L806
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L998
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L1053
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2197
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1270
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.ServiceFabric' for api version '2022-01-01'. The supported api-versions are '2016-03-01,
    2016-09-01,
    2017-07-01-preview,
    2017-07-01-privatepreview,
    2018-02-01,
    2018-02-01-privatepreview,
    2019-03-01-privatepreview,
    2019-03-01-preview,
    2019-03-01,
    2019-06-01-preview,
    2019-11-01-preview,
    2019-11-01-privatepreview,
    2020-02-01-preview,
    2020-02-01-privatepreview,
    2020-03-01,
    2020-12-01-preview,
    2020-12-01-privatepreview,
    2020-12-15-preview,
    2020-12-15-privatepreview,
    2021-06-01'."
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 6 Errors, 246 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1862:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1862:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1862:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2325:5
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2294:5
    1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L697:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/nodetype.json#L591:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'minimum' value than the previous one.
    New: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L697:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/nodetype.json#L591:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L45:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L45:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L89:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L89:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L143:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L143:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L196:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L196:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L249:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L249:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L295:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L295:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L342:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L342:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L409:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L409:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L465:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L465:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L521:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L521:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L570:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L570:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L614:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L614:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L681:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L681:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L734:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L734:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L787:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L787:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L833:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L833:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L880:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L880:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L950:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L950:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1006:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1006:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1062:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1062:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2661:5
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L2620:5
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L42:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedcluster.json#L42:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L85:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedcluster.json#L85:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L128:9
    Old: Microsoft.ServiceFabric/stable/2021-05-01/managedcluster.json#L128:9


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'location' removed or renamed?
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1773:3
    Old: Microsoft.ServiceFabric/preview/2021-11-01-preview/managedcluster.json#L1644:3
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/preview/2021-11-01-preview/managedapplication.json#L1884:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/preview/2021-11-01-preview/managedapplication.json#L1884:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L1884:9
    Old: Microsoft.ServiceFabric/preview/2021-11-01-preview/managedapplication.json#L1884:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AveragePartitionLoad, AverageServiceLoad' from the old version.
    New: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2325:5
    Old: Microsoft.ServiceFabric/preview/2021-11-01-preview/managedapplication.json#L2325:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 5, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-servicefabricmanagedclusters - 1.0.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b7ceedc. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ManagedUnsupportedVMSizesOperations
      info	[Changelog]   - Added operation group NodeTypeSkusOperations
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]   - Added operation group OperationStatusOperations
      info	[Changelog]   - Model LoadBalancingRule has a new parameter load_distribution
      info	[Changelog]   - Model ManagedCluster has a new parameter auxiliary_subnets
      info	[Changelog]   - Model ManagedCluster has a new parameter enable_ipv6
      info	[Changelog]   - Model ManagedCluster has a new parameter enable_service_public_ip
      info	[Changelog]   - Model ManagedCluster has a new parameter ip_tags
      info	[Changelog]   - Model ManagedCluster has a new parameter ipv6_address
      info	[Changelog]   - Model ManagedCluster has a new parameter service_endpoints
      info	[Changelog]   - Model ManagedCluster has a new parameter subnet_id
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_address_prefix
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_port_range
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_address_prefix
      info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_port_range
      info	[Changelog]   - Model NodeType has a new parameter additional_data_disks
      info	[Changelog]   - Model NodeType has a new parameter data_disk_letter
      info	[Changelog]   - Model NodeType has a new parameter enable_accelerated_networking
      info	[Changelog]   - Model NodeType has a new parameter enable_encryption_at_host
      info	[Changelog]   - Model NodeType has a new parameter enable_over_provisioning
      info	[Changelog]   - Model NodeType has a new parameter frontend_configurations
      info	[Changelog]   - Model NodeType has a new parameter network_security_rules
      info	[Changelog]   - Model NodeType has a new parameter sku
      info	[Changelog]   - Model NodeType has a new parameter use_default_public_load_balancer
      info	[Changelog]   - Model NodeType has a new parameter use_temp_data_disk
      info	[Changelog]   - Model NodeTypeUpdateParameters has a new parameter sku
      info	[Changelog]   - Model VMSSExtension has a new parameter enable_automatic_upgrade
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ManagedClusterVersionOperations.get_by_environment has a new signature
      info	[Changelog]   - Operation ManagedClusterVersionOperations.list_by_environment has a new signature
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b7ceedc. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 5, 2022
    @openapi-workflow-bot
    Copy link

    Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    adding new api to readme
    "description": "Enumerates the ways that a service can be partitioned.",
    "enum": [
    "AveragePartitionLoadTrigger",
    "AverageServiceLoadTrigger"
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Changing enum names is a breaking change. Please get a review from breaking change board as well.

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Copy link
    Member

    @RamyasreeChakka RamyasreeChakka left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested labels Jan 10, 2022
    @RamyasreeChakka
    Copy link
    Member

    @a-santamaria Signed off from ARM side.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 11, 2022
    @ghost
    Copy link

    ghost commented Feb 13, 2022

    Hi, @a-santamaria. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @a-santamaria
    Copy link
    Member Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @a-santamaria
    Copy link
    Member Author

    @jianyexi please complete the pr. The new api is already deployed in our service

    @jianyexi jianyexi merged commit b7ceedc into Azure:main Feb 15, 2022
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    * initial commit copy from 2021-11-01-preview
    
    * update files with new api 2022-01-01
    
    adding new api to readme
    
    * rename operation id
    
    * remove location from proxy resource
    
    * revert locationForClusterCodeVersions
    
    * add x-ms-enum to environment param
    
    Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants