Skip to content

[QuotaRP] Fix LimitObject polymorphism #16438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2021
Merged

[QuotaRP] Fix LimitObject polymorphism #16438

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb0ca76
Fix LimitObject polymorphism
stephenbudhi-msft Oct 18, 2021
62067e5
move properties out of allOf
stephenbudhi-msft Oct 18, 2021
b1c9a2b
add type to LimitObject
stephenbudhi-msft Oct 18, 2021
c9c7f6a
value is required
stephenbudhi-msft Oct 18, 2021
1a3be7d
Updating Operations Tag to QuotaOperations.
rahuls-microsoft Oct 19, 2021
1884a8e
Update quota.json
rahuls-microsoft Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions specification/quota/resource-manager/Microsoft.Quota/preview/2021-03-15-preview/quota.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,9 @@
},
"/providers/Microsoft.Quota/operations": {
"get": {
"summary": "GET operations.",
"summary": "GET quota operations.",
"description": "List all the operations supported by the Microsoft.Quota resource provider.",
"operationId": "Operation_List",
"operationId": "QuotaOperation_List",
"x-ms-examples": {
"GetOperations": {
"$ref": "./examples/GetOperations.json"
Expand Down Expand Up @@ -868,15 +868,18 @@
"LimitObject": {
"description": "The resource quota limit value.",
"type": "object",
"x-ms-discriminator-value": "LimitValue",
"allOf": [
{
"$ref": "#/definitions/LimitJsonObject"
}
],
"properties": {
"value": {
"type": "integer",
"format": "int32",
"description": "The quota/limit value"
},
"limitObjectType": {
"$ref": "#/definitions/LimitObjectTypes"
},
"limitType": {
"$ref": "#/definitions/LimitTypes"
}
Expand All @@ -885,19 +888,6 @@
"value"
]
},
"LimitValue": {
"x-ms-discriminator-value": "LimitValue",
"type": "object",
"description": "The resource quota limit.",
"allOf": [
{
"$ref": "#/definitions/LimitJsonObject"
},
{
"$ref": "#/definitions/LimitObject"
}
]
},
"QuotaRequestOneResourceSubmitResponse": {
"description": "Quota request response.",
"type": "object",
Expand Down