Skip to content

Conversation

@giakas
Copy link
Contributor

@giakas giakas commented Sep 20, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 20, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 16 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1200
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1295
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L20
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationResults' with immediate parent 'PrivateEndpointConnection', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L20
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L103
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pipelineTopologies' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L900
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'livePipelines' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1112
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pipelineJobs' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1295
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'LivePipeline', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1327
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'PipelineJob', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1347
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'PrivateEndpointConnection', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L811
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UserAssignedManagedIdentity' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L621
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInUse
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L80
    ⚠️ R4021 - DescriptionAndTitleMissing 'LivePipelineOperationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1327
    ⚠️ R4021 - DescriptionAndTitleMissing 'PipelineJobOperationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1347
    ⚠️ R4021 - DescriptionAndTitleMissing 'VideoEntity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L412


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L289
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L906
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VideoAnalyzers_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L937
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VideoAnalyzers_ListBySubscription' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1788
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'edgeModules' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/EdgeModules.json#L75
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'videos' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L412
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'accessPolicies' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L427
    ⚠️ R3017 - GuidUsage Guid used in model definition 'EdgeModuleProperties' for property 'edgeModuleId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/preview/2021-11-01-preview/EdgeModules.json#L32
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L64
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L193
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L293
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: common-types/resource-management/v3/types.json#L626
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: canStream
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L72
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hasData
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L76
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 24 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/videoAnalyzers/{accountName}/syncStorageKeys' removed or restructured?
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L875:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/videoAnalyzers/{accountName}/videos/{videoName}/listStreamingToken' removed or restructured?
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L698:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SyncStorageKeysInput' removed or renamed?
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L29:3
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L29:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VideoStreaming' removed or renamed?
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L29:3
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L29:3
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1136:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L621:9
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L472:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L628:9
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L477:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L549:9
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L395:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L345:5
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L377:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L549:9
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L395:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L345:5
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L377:5
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'isRecording' renamed or removed?
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L71:7
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L41:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'streaming' renamed or removed?
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L123:7
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L93:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'id' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L349:11
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L356:11
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'id' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L449:11
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L356:11
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'id' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L323:5
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L323:5
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'isInUse' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L71:7
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L41:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'isInUse' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L156:9
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L121:9
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'isInUse' that was not found in the old version.
    New: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L70:5
    Old: Microsoft.Media/preview/2021-05-01-preview/Videos.json#L40:5
    ⚠️ 1042 - ChangedParameterOrder The order of parameter '$top' was changed.
    New: Microsoft.Media/preview/2021-11-01-preview/EdgeModules.json#L129:9
    Old: Microsoft.Media/preview/2021-05-01-preview/EdgeModules.json#L134:9
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1016:7
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L724:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1131:7
    Old: Microsoft.Media/preview/2021-05-01-preview/VideoAnalyzers.json#L823:7
    ⚠️ 1046 - RemovedOptionalParameter The optional parameter '$filter' was removed in the new version.
    Old: Microsoft.Media/preview/2021-05-01-preview/EdgeModules.json#L147:11
    ⚠️ 1046 - RemovedOptionalParameter The optional parameter '$orderby' was removed in the new version.
    Old: Microsoft.Media/preview/2021-05-01-preview/EdgeModules.json#L162:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 20, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - preview/videoanalyzer/mgmt/2021-05-01-preview/videoanalyzer - v58.0.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-videoanalyzer - Approved - 1.0.0b2
    +	Model VideoEntity no longer has parameter streaming
    +	Model VideoFlags has a new required parameter is_in_use
    +	Model VideoFlags no longer has parameter is_recording
    +	Operation EdgeModulesOperations.list has a new signature
    +	Operation EdgeModulesOperations.list has a new signature
    +	Parameter id of model StorageAccount is now required
    +	Removed operation VideoAnalyzersOperations.create_or_update
    +	Removed operation VideoAnalyzersOperations.sync_storage_keys
    +	Removed operation VideoAnalyzersOperations.update
    +	Removed operation VideosOperations.list_streaming_token
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c481083. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-videoanalyzer [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model VideoAnalyzer has a new parameter public_network_access
      info	[Changelog]   - Model VideoAnalyzer has a new parameter network_access_control
      info	[Changelog]   - Model VideoAnalyzer has a new parameter provisioning_state
      info	[Changelog]   - Model VideoAnalyzer has a new parameter private_endpoint_connections
      info	[Changelog]   - Model VideoAnalyzer has a new parameter iot_hubs
      info	[Changelog]   - Model VideoEntity has a new parameter content_urls
      info	[Changelog]   - Model VideoEntity has a new parameter archival
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter public_network_access
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter network_access_control
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter provisioning_state
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter private_endpoint_connections
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter iot_hubs
      info	[Changelog]   - Added operation VideoAnalyzersOperations.begin_create_or_update
      info	[Changelog]   - Added operation VideoAnalyzersOperations.begin_update
      info	[Changelog]   - Added operation VideosOperations.list_content_token
      info	[Changelog]   - Added operation group LivePipelinesOperations
      info	[Changelog]   - Added operation group PipelineJobOperationStatusesOperations
      info	[Changelog]   - Added operation group VideoAnalyzerOperationStatusesOperations
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]   - Added operation group OperationStatusesOperations
      info	[Changelog]   - Added operation group PipelineJobsOperations
      info	[Changelog]   - Added operation group VideoAnalyzerOperationResultsOperations
      info	[Changelog]   - Added operation group PipelineTopologiesOperations
      info	[Changelog]   - Added operation group LivePipelineOperationStatusesOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter id of model StorageAccount is now required
      info	[Changelog]   - Operation EdgeModulesOperations.list has a new signature
      info	[Changelog]   - Operation EdgeModulesOperations.list has a new signature
      info	[Changelog]   - Model VideoEntity no longer has parameter streaming
      info	[Changelog]   - Model VideoFlags no longer has parameter is_recording
      info	[Changelog]   - Model VideoFlags has a new required parameter is_in_use
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.update
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.sync_storage_keys
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.create_or_update
      info	[Changelog]   - Removed operation VideosOperations.list_streaming_token
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c481083. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-30 06:02:58 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-videoanalyzer;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-09-30 06:02:58 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-09-30 06:02:58 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/videoanalyzer/azure-resourcemanager-videoanalyzer --java.namespace=com.azure.resourcemanager.videoanalyzer   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/videoanalyzer/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-videoanalyzer
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Skip] pom already has module azure-resourcemanager-videoanalyzer
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Skip] pom already has module sdk/videoanalyzer
      cmderr	[generate.py] 2021-09-30 06:03:41 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-videoanalyzer [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-30 06:05:41 DEBUG Got artifact_id: azure-resourcemanager-videoanalyzer
      cmderr	[Inst] 2021-09-30 06:05:41 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-30 06:05:41 DEBUG Got artifact: azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-09-30 06:05:41 DEBUG Match jar package: azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-09-30 06:05:41 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16089/azure-sdk-for-java/azure-resourcemanager-videoanalyzer/azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar\" -o azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-videoanalyzer -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c481083. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/videoanalyzer/mgmt/2021-05-01-preview/videoanalyzer [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c481083. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/videoanalyzer/resource-manager/readme.md
    • ️✔️@azure/arm-videoanalyzer [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/videoAnalyzer.js → ./dist/arm-videoanalyzer.js...
      cmderr	[npmPack] created ./dist/arm-videoanalyzer.js in 494ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c481083. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @giakas, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @giakas giakas marked this pull request as ready for review September 21, 2021 06:02
    @giakas giakas added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @giakas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    Copy link

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @akning-ms
    Copy link
    Contributor

    @msyyc to confirm python SDK breaking change

    @msyyc
    Copy link
    Member

    msyyc commented Sep 30, 2021

    approve for python breaking change.

    @akning-ms akning-ms assigned akning-ms and unassigned qwordy Sep 30, 2021
    @akning-ms akning-ms merged commit c481083 into Azure:main Sep 30, 2021
    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    …view/2021-11-01-preview (Azure#16089)
    
    * Adds base for updating Microsoft.Media from version preview/2021-05-01-preview to version 2021-11-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Update to use 2021-11-01 version of the swaggers and examples
    
    * Remove unused examples and fix prettier errors.
    
    * fix patch  where required is empty.
    
    * fix some lint errors
    
    * fix a json parse issue.
    
    * fix enum casing
    
    * fix missing 204 on endpointconnections delete
    
    * create entities for Patch operation
    
    * updating descriptions
    
    * fixed a bad commit.
    
    * fix validation errors
    
    * fix few more validation issues.
    
    * fix sample validaitons
    
    * fix examples
    
    * Update PrivateEndpoints to use v3 version of commonTypes to use systemData
    
    * change all commontypes to v3
    
    * add long running operation to operations
    
    * update missing descriptions
    
    * fix a parameter name to operationId
    
    * Update few more descriptions
    
    * adding supressions for few failed validations
    
    * fix suppreesions
    
    * add few more descriptions
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …view/2021-11-01-preview (Azure#16089)
    
    * Adds base for updating Microsoft.Media from version preview/2021-05-01-preview to version 2021-11-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Update to use 2021-11-01 version of the swaggers and examples
    
    * Remove unused examples and fix prettier errors.
    
    * fix patch  where required is empty.
    
    * fix some lint errors
    
    * fix a json parse issue.
    
    * fix enum casing
    
    * fix missing 204 on endpointconnections delete
    
    * create entities for Patch operation
    
    * updating descriptions
    
    * fixed a bad commit.
    
    * fix validation errors
    
    * fix few more validation issues.
    
    * fix sample validaitons
    
    * fix examples
    
    * Update PrivateEndpoints to use v3 version of commonTypes to use systemData
    
    * change all commontypes to v3
    
    * add long running operation to operations
    
    * update missing descriptions
    
    * fix a parameter name to operationId
    
    * Update few more descriptions
    
    * adding supressions for few failed validations
    
    * fix suppreesions
    
    * add few more descriptions
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-SdkBreakingChange-Python ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants