Skip to content

Enabling Customer Initiated Diagnostic Log Collection #16071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2021
Merged

Enabling Customer Initiated Diagnostic Log Collection #16071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd9434f
Enabling Customer Initiated Log Collection
visingl Sep 16, 2021
2426fef
Update deviceupdate.json
visingl Sep 16, 2021
d059fb3
Update Instances_Create.json
visingl Sep 16, 2021
0a051ce
pretty
visingl Sep 16, 2021
642870a
Update deviceupdate.json
visingl Sep 29, 2021
7c86853
Update readme.go.md
visingl Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...date/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,9 @@
"enableDiagnostics": {
"description": "Enables or Disables the diagnostic logs collection",
"type": "boolean"
},
"diagnosticStorageProperties": {
"$ref": "#/definitions/DiagnosticStorageProperties"
}
}
}
Expand All @@ -1095,6 +1098,37 @@
"properties"
]
},
"DiagnosticStorageProperties": {
"description": "Customer-initiated diagnostic log collection storage properties",
"type": "object",
"properties": {
"authenticationType": {
"description": "Authentication Type",
"enum": [
"KeyBased"
],
"type": "string",
"readOnly": false,
"x-ms-enum": {
"name": "AuthenticationType",
"modelAsString": true
}
},
"connectionString": {
"description": "ConnectionString of the diagnostic storage account",
"x-ms-secret": true,
"type": "string"
},
"resourceId": {
"description": "ResourceId of the diagnostic storage account",
"type": "string"
}
},
"required": [
"authenticationType",
"resourceId"
]
},
"InstanceList": {
"description": "List of Instances.",
"type": "object",
Expand Down
13 changes: 11 additions & 2 deletions ...icrosoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
"eventHubConnectionString": "string"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount",
"connectionString": "string"
}
}
}
},
Expand All @@ -34,7 +39,11 @@
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
}
}
}
}
Expand Down
6 changes: 5 additions & 1 deletion ...r/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
}
}
}
}
Expand Down
12 changes: 10 additions & 2 deletions ...t.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_ListByAccount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
}
}
},
{
Expand All @@ -39,7 +43,11 @@
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/red-contoso-hub"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
}
}
}
]
Expand Down
6 changes: 5 additions & 1 deletion ...icrosoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
}
],
"enableDiagnostics": false
"enableDiagnostics": false,
"diagnosticStorageProperties": {
"authenticationType": "KeyBased",
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
}
},
"tags": {
"tagKey": "tagValue"
Expand Down
2 changes: 1 addition & 1 deletion specification/deviceupdate/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ These settings apply only when `--go` is specified on the command line.
```yaml $(go)
go:
license-header: MICROSOFT_MIT_NO_VERSION
namespace: deviceupdate
clear-output-folder: true
```

Expand All @@ -21,6 +22,5 @@ These settings apply only when `--tag=package-2020-03-01-preview --go` is specif
Please also specify `--go-sdks-folder=<path to the root directory of your azure-sdk-for-go clone>`.

```yaml $(tag) == 'package-2020-03-01-preview' && $(go)
namespace: deviceupdate
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2020-03-01-preview/$(namespace)
```