Skip to content

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2021
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a97dc0
Added exportable attribute and release policy to CP Swagger doc
susolank Sep 14, 2021
0082761
Specify type as object for ReleasePolicy
susolank Sep 14, 2021
e63de79
Address code review comments
susolank Sep 14, 2021
4352993
Add suppression code for camelCase
susolank Sep 15, 2021
8379e90
Prettier check
susolank Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,10 @@
"rotationPolicy": {
"$ref": "#/definitions/RotationPolicy",
"description": "Key rotation policy in response. It will be used for both output and input. Omitted if empty"
},
"release_policy": {
"$ref": "#/definitions/KeyReleasePolicy",
"description": "Key release policy in response. It will be used for both output and input. Omitted if empty"
}
},
"description": "The properties of the key.",
Expand Down Expand Up @@ -473,6 +477,10 @@
},
"readOnly": true,
"x-nullable": false
},
"exportable": {
"type": "boolean",
"description": "Indicates if the private key can be exported."
}
},
"description": "The object attributes managed by the Azure Key Vault service.",
Expand Down Expand Up @@ -614,6 +622,21 @@
}
},
"type": "object"
},
"KeyReleasePolicy": {
"properties": {
"contentType": {
"description": "Content type and version of key release policy",
"type": "string",
"default": "application/json; charset=utf-8"
},
"data": {
"description": "Blob encoding the policy rules under which the key can be released.",
"type": "string",
"format": "base64url"
}
},
"type": "object"
}
},
"parameters": {
Expand Down
5 changes: 3 additions & 2 deletions specification/keyvault/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,12 @@ input-file:
``` yaml
directive:
- suppress:
- R3016 # The 'release_policy' property for KeyCreateParameters does not support camelCase.
- R3026 # The 'PrivateEndpointConnection' and 'PrivateLinkResource' sub-resources don't define PATCH as per Network Team's specification.
- R3025 # The 'PrivateLinkResource' is only accessible via List operation; does not define GET as per Network Team's specification.
- R4015 # The 'MHSMPrivateEndpointConnection' sub-resource doesn't define List as per Network Team's specification.
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- R4009 # Vault object is the only one that need to be tracked with SystemData
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- R4009 # Vault object is the only one that need to be tracked with SystemData
```

---
Expand Down