Skip to content

Dev desktopvirtualization microsoft.desktop virtualization 2021 08 04 preview #15796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Dev desktopvirtualization microsoft.desktop virtualization 2021 08 04 preview #15796

wants to merge 4 commits into from

Conversation

@dallinlmag
Copy link

@dallinlmag dallinlmag commented Aug 25, 2021 •
edited by nakranimohit0
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. September 2021
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dallinlmag Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021 •
    edited
    Loading

    Swagger pipeline can not start as the pull request has merge conflicts.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 25, 2021 •
    edited
    Loading

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-workflow-bot
    Copy link

    Hi @dallinlmag, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    This was referenced Aug 25, 2021
    Draft
    Draft
    Draft
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 25, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @dallinlmag your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 30, 2021
    Draft
    @dallinlmag dallinlmag force-pushed the dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-08-04-preview branch from 21b51fd to 8ad3899 Compare August 30, 2021 21:22
    @dallinlmag dallinlmag force-pushed the dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-08-04-preview branch from 8ad3899 to 7bffd45 Compare August 30, 2021 23:13
    @dallinlmag dallinlmag marked this pull request as ready for review August 31, 2021 23:12
    @dallinlmag dallinlmag requested a review from datr93 August 31, 2021 23:12
    @zhenglaizhang
    Copy link
    Contributor

    Hi @dallinlmag there are cross version breaking change per #15796 (comment), please go through breaking change review process

    @dallinlmag
    Copy link
    Author

    Hi @zhenglaizhang Based on previous discussion around this, I was under the impression that we could push a new API preview version containing a change like this if it is in private preview and not yet used by customers. We need these changes in order to go to public preview. Thanks for your help.

    @zhenglaizhang
    Copy link
    Contributor

    Hi @zhenglaizhang Based on previous discussion around this, I was under the impression that we could push a new API preview version containing a change like this if it is in private preview and not yet used by customers. We need these changes in order to go to public preview. Thanks for your help.

    this spec repo is public preview or GA, and for private preview you need do on https://github.com/azure/azure-rest-api-specs-pr

    @dallinlmag
    Update Virtual Desktop Scaling Plan time format to be more user friendly
    5870999 
        - Change Date-Time format to an object specifying the hour and minute
    - Update naming length requirements to match those in the greater Azure virtual desktop
    - Adjust time zone to match ID in examples
    - Updated examples to reflect the change and be more readable for customers.
    - Remove ability to patch hostPoolType for Scaling
    - Change objectID in responses to 0 so customers won't think they need to use it.
    - Change HostPoolType property name to distinguish from different enum
    @dallinlmag dallinlmag force-pushed the dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-08-04-preview branch from 7bffd45 to 5870999 Compare September 2, 2021 21:19
    @zhenglaizhang
    Copy link
    Contributor

    Hi @dallinlmag please help resolve the conflicts; and as you are adding new API version, please get ARM signed off, if you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

    @ghost
    Copy link

    ghost commented Sep 19, 2021

    Hi, @dallinlmag. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 19, 2021
    @chiragg4u chiragg4u removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2021
    @chiragg4u chiragg4u added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 20, 2021
    @ghost ghost removed the no-recent-activity label Sep 20, 2021
    @chiragg4u
    Copy link
    Contributor

    Thank you for copying the existing version into new folder for first commit. It helps in reviewing the change.
    Changes looks fine from ARM perspective. Please resolve other warnings/errors to continue.

    @dallinlmag
    Copy link
    Author

    Closing this Pull request as the changes were rolled into a different API version. #15913

    @dallinlmag dallinlmag closed this Sep 20, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @datr93 datr93 Awaiting requested review from datr93

    Assignees

    @zhenglaizhang zhenglaizhang

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @dallinlmag @zhenglaizhang @chiragg4u