Skip to content

HanaOnAzure: correctly annotate read-only properties with readOnly #15205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2021
Merged

HanaOnAzure: correctly annotate read-only properties with readOnly #15205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
747b5e0
HanaOnAzure: correctly annotate read-only properties with readOnly
lagalbra Jul 14, 2021
32e9325
Correct labels on examples
lagalbra Jul 19, 2021
5b7ff62
Correct request for Create example
lagalbra Jul 19, 2021
b6cf031
Correct usage of readonly hwRevision in Create exammple
lagalbra Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions ...nager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,33 +10,18 @@
"key": "value"
},
"properties": {
"hanaInstanceId": "00000000-0000-0000-0000-000000000000",
"powerState": "started",
"proximityPlacementGroup": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Compute/proximityPlacementGroups/myplacementgroup",
"hwRevision": "Rev 3",
"hardwareProfile": {
"hardwareType": "Cisco_UCS",
"hanaInstanceSize": "S72"
},
"networkProfile": {
"networkInterfaces": [
{
"ipAddress": "100.100.100.100"
}
],
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.200"
]
},
"osProfile": {
"computerName": "myComputerName",
"osType": "SUSE",
"version": "12 SP1",
"sshPublicKey": "AAAAB3NzaC1yc2EAAAABJQAAAQB/nAmOjTmezNUDKYvEeIRf2YnwM9/uUG1d0BYsc8/tRtx+RGi7N2lUbp728MXGwdnL9od4cItzky/zVdLZE2cycOa18xBK9cOWmcKS0A8FYBxEQWJ/q9YVUgZbFKfYGaGQxsER+A0w/fX8ALuk78ktP31K69LcQgxIsl7rNzxsoOQKJ/CIxOGMMxczYTiEoLvQhapFQMs3FL96didKr/QbrfB1WT6s3838SEaXfgZvLef1YB2xmfhbT9OXFE3FXvh2UPBfN+ffE7iiayQf/2XR+8j4N4bW30DiPtOQLGUrH1y5X/rpNZNlWW2+jGIxqZtgWg7lTy3mXy5x836Sj/6L"
},
"partnerNodeId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance2",
"provisioningState": "Succeeded"
"partnerNodeId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance2"
}
}
},
Expand Down
16 changes: 14 additions & 2 deletions ...nazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
"summary": "Creates a SAP HANA instance.",
"description": "Creates a SAP HANA instance for the specified subscription, resource group, and instance name.",
"x-ms-examples": {
"Get properties of a HANA instance": {
"Create a HANA instance": {
"$ref": "./examples/HanaInstances_Create.json"
}
},
Expand Down Expand Up @@ -254,7 +254,7 @@
"summary": "Deletes a SAP HANA instance.",
"description": "Deletes a SAP HANA instance with the specified subscription, resource group, and instance name.",
"x-ms-examples": {
"Get properties of a HANA instance": {
"Delete a HANA instance": {
"$ref": "./examples/HanaInstances_Delete.json"
}
},
Expand Down Expand Up @@ -569,10 +569,12 @@
"description": "Specifies the network settings for the HANA instance."
},
"hanaInstanceId": {
"readOnly": true,
"type": "string",
"description": "Specifies the HANA instance unique ID."
},
"powerState": {
"readOnly": true,
"type": "string",
"enum": [
"starting",
Expand All @@ -589,10 +591,12 @@
"description": "Resource power state"
},
"proximityPlacementGroup": {
"readOnly": true,
"type": "string",
"description": "Resource proximity placement group"
},
"hwRevision": {
"readOnly": true,
"type": "string",
"description": "Hardware revision of a HANA instance"
},
Expand All @@ -601,6 +605,7 @@
"description": "ARM ID of another HanaInstance that will share a network with this HanaInstance"
},
"provisioningState": {
"readOnly": true,
"type": "string",
"enum": [
"Accepted",
Expand All @@ -623,6 +628,7 @@
"HardwareProfile": {
"properties": {
"hardwareType": {
"readOnly": true,
"type": "string",
"enum": [
"Cisco_UCS",
Expand All @@ -635,6 +641,7 @@
"description": "Name of the hardware type (vendor and/or their product name)"
},
"hanaInstanceSize": {
"readOnly": true,
"type": "string",
"enum": [
"S72m",
Expand Down Expand Up @@ -718,6 +725,7 @@
"description": "Group ID of the HANA database user."
},
"memoryAllocation": {
"readOnly": true,
"type": "string",
"description": "Percent of memory to allocate to this SID."
},
Expand All @@ -739,6 +747,7 @@
"StorageProfile": {
"properties": {
"nfsIpAddress": {
"readOnly": true,
"type": "string",
"description": "IP Address to connect to storage."
},
Expand Down Expand Up @@ -766,10 +775,12 @@
"description": "Specifies the host OS name of the HANA instance."
},
"osType": {
"readOnly": true,
"type": "string",
"description": "This property allows you to specify the type of the OS."
},
"version": {
"readOnly": true,
"type": "string",
"description": "Specifies version of operating system."
},
Expand All @@ -790,6 +801,7 @@
"description": "Specifies the network interfaces for the HANA instance."
},
"circuitId": {
"readOnly": true,
"type": "string",
"description": "Specifies the circuit id for connecting to express route."
}
Expand Down