-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add New Data Model RuleCollection to NetworkManager #13827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
53ad377
Add New Data Model RuleCollection to NetworkManager
yanfa317 7fd214d
fix typo
yanfa317 a950a83
test
yanfa317 0a53f84
test
yanfa317 ffce721
Fix discriminator
yanfa317 dc0371b
fix type
yanfa317 27d83cb
Fix discriminator
yanfa317 2df686b
Fix type
yanfa317 b1c0256
fix type
yanfa317 48a44b1
Fix type
yanfa317 bce950a
Fix discriminator
yanfa317 2637948
Fix discriminator
yanfa317 901bcce
fix type
yanfa317 9c8f6cb
fix type
yanfa317 a5a6735
Fix bug
yanfa317 bcc6fc4
Fix type
yanfa317 9d7dc08
Fix format
yanfa317 3cb0a7c
Fix name
yanfa317 45dc1b3
Fix name
yanfa317 24673af
fix spell
yanfa317 94bf9ba
fix description
yanfa317 2581fcf
Fix spell
yanfa317 fdbe274
change to kind
yanfa317 74e417e
fix lint
yanfa317 f19a644
fix lint
yanfa317 f6a7ec9
fix lint
yanfa317 2b41df4
fix lint
yanfa317 336c14f
fix lint
yanfa317 377017f
fix lint
yanfa317 6752dcb
Fix post body
yanfa317 39393f7
Fix as comments
yanfa317 bd197ed
fix bug
yanfa317 559a74d
fix bug
yanfa317 49be417
fix bug
yanfa317 e3abbfd
fix bug
yanfa317 57d8903
fix bug
yanfa317 0ae33b7
fix bug
yanfa317 3d86b93
change rule kind
yanfa317 5519a9c
Fix as comments
yanfa317 5788ff8
Fix as comments
yanfa317 3529d5e
update lastest version
yanfa317 ee692e4
Update type
yanfa317 0ffe9e3
Update Skiptoken
yanfa317 58c006d
Fix discription
yanfa317 69adaa9
Fix NG
yanfa317 f3893bc
Fix NG
yanfa317 41c008f
add more example
yanfa317 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
....Network/preview/2021-02-01-preview/examples/NetworkManagerAdminRuleCollectionDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkManagerName": "testNetworkManager", | ||
| "configurationName": "myTestSecurityConfig", | ||
| "ruleCollectionName": "testRuleCollection" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } | ||
37 changes: 37 additions & 0 deletions
37
...oft.Network/preview/2021-02-01-preview/examples/NetworkManagerAdminRuleCollectionGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkManagerName": "testNetworkManager", | ||
| "ruleCollectionName": "testRuleCollection", | ||
| "configurationName": "myTestSecurityConfig" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkManagers/testNetworkManager/securityAdminConfigurations/myTestSecurityConfig/ruleCollections/testRuleCollection", | ||
| "name": "testRuleCollection", | ||
| "type": "Microsoft.Network/networkManagers/securityAdminConfigurations/RuleCollections", | ||
| "systemData": { | ||
| "createdBy": "b69a9388-9488-4534-b470-7ec6d41beef5", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-01-11T18:52:27Z", | ||
| "lastModifiedBy": "b69a9388-9488-4534-b470-7ec6d41beef5", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-01-11T18:52:27Z" | ||
| }, | ||
| "properties": { | ||
| "displayName": "testRuleCollection", | ||
yanfa317 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "description": "A sample rule collection", | ||
| "provisioningState": "Succeeded", | ||
| "appliesToGroups": [ | ||
| { | ||
| "networkGroupId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkManagers/testNetworkManager/networkGroups/testGroup" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
41 changes: 41 additions & 0 deletions
41
...ft.Network/preview/2021-02-01-preview/examples/NetworkManagerAdminRuleCollectionList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkManagerName": "testNetworkManager", | ||
| "configurationName": "myTestSecurityConfig" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkManagers/testNetworkManager/securityAdminConfigurations/myTestSecurityConfig/ruleCollections/testRuleCollection", | ||
| "name": "testRuleCollection", | ||
| "type": "Microsoft.Network/networkManagers/securityAdminConfigurations/RuleCollections", | ||
| "systemData": { | ||
| "createdBy": "b69a9388-9488-4534-b470-7ec6d41beef5", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-01-11T18:52:27Z", | ||
| "lastModifiedBy": "b69a9388-9488-4534-b470-7ec6d41beef5", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-01-11T18:52:27Z" | ||
| }, | ||
| "properties": { | ||
| "displayName": "testRuleCollection", | ||
| "description": "A sample rule collection", | ||
| "provisioningState": "Succeeded", | ||
| "appliesToGroups": [ | ||
| { | ||
| "networkGroupId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkManagers/testNetworkManager/networkGroups/testGroup" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkManagers/testNetworkManager/securityAdminConfigurations/myTestSecurityConfig/ruleCollections?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.