Skip to content

ResourceGuard Proxy related changes for MFA MUA #13477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 22, 2021
Merged

ResourceGuard Proxy related changes for MFA MUA #13477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15aef61
MFA MUA V1 swagger changes
madhude Feb 21, 2021
c675cb4
Copying json from 2021-02-01 to 2021-02-01-preview
madhude Feb 22, 2021
4db008b
Moving these details under Preview folder
madhude Feb 24, 2021
9ffaef1
Fixing Avocado errors
madhude Feb 24, 2021
83c5337
updated version in example json files
madhude Mar 10, 2021
e376cf3
ResourceGuardProxy related changes
madhude Mar 17, 2021
eb2ce71
Merge branch 'master' into master
deymadhumanti Mar 17, 2021
79c1c65
Resolved spell check errors
madhude Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
345 changes: 345 additions & 0 deletions ...cesbackup/resource-manager/Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3916,6 +3916,263 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies": {
"get": {
"tags": [
"ResourceGuardProxies"
],
"description": "List the ResourceGuardProxies under vault",
"operationId": "ResourceGuardProxies_Get",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/VaultName"
},
{
"$ref": "#/parameters/ResourceGroupName"
},
{
"$ref": "#/parameters/SubscriptionId"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ResourceGuardProxyBaseResourceList"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"Get VaultGuardProxies": {
"$ref": "./examples/ResourceGuardProxyCRUD/ListResourceGuardProxy.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies/{resourceGuardProxyName}": {
"get": {
"tags": [
"ResourceGuardProxy"
],
"description": "Returns ResourceGuardProxy under vault and with the name referenced in request",
"operationId": "ResourceGuardProxy_Get",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/VaultName"
},
{
"$ref": "#/parameters/ResourceGroupName"
},
{
"$ref": "#/parameters/SubscriptionId"
},
{
"name": "resourceGuardProxyName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ResourceGuardProxyBaseResource"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"Get ResourceGuardProxy": {
"$ref": "./examples/ResourceGuardProxyCRUD/GetResourceGuardProxy.json"
}
}
},
"put": {
"tags": [
"ResourceGuardProxy"
],
"description": "Add or Update ResourceGuardProxy under vault\r\nSecures vault critical operations",
"operationId": "ResourceGuardProxy_Put",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/VaultName"
},
{
"$ref": "#/parameters/ResourceGroupName"
},
{
"$ref": "#/parameters/SubscriptionId"
},
{
"name": "resourceGuardProxyName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ResourceGuardProxyBaseResource"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"Create ResourceGuardProxy": {
"$ref": "./examples/ResourceGuardProxyCRUD/PutResourceGuardProxy.json"
}
}
},
"delete": {
"tags": [
"ResourceGuardProxy"
],
"description": "Delete ResourceGuardProxy under vault",
"operationId": "ResourceGuardProxy_Delete",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/VaultName"
},
{
"$ref": "#/parameters/ResourceGroupName"
},
{
"$ref": "#/parameters/SubscriptionId"
},
{
"name": "resourceGuardProxyName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": {
"200": {
"description": "OK"
},
"204": {
"description": "NoContent"
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"Delete ResourceGuardProxy": {
"$ref": "./examples/ResourceGuardProxyCRUD/DeleteResourceGuardProxy.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupResourceGuardProxies/{resourceGuardProxyName}/unlockDelete": {
"post": {
"tags": [
"ResourceGuardProxy"
],
"description": "Secures delete ResourceGuardProxy operations.",
"operationId": "ResourceGuardProxy_UnlockDelete",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/VaultName"
},
{
"$ref": "#/parameters/ResourceGroupName"
},
{
"$ref": "#/parameters/SubscriptionId"
},
{
"name": "resourceGuardProxyName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "parameters",
"in": "body",
"description": "Request body for operation",
"required": true,
"schema": {
"$ref": "#/definitions/UnlockDeleteRequest"
}
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/UnlockDeleteResponse"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"UnlockDelete ResourceGuardProxy": {
"$ref": "./examples/ResourceGuardProxyCRUD/UnlockDeleteResourceGuardProxy.json"
}
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -8315,6 +8572,13 @@
"name": "SoftDeleteFeatureState",
"modelAsString": true
}
},
"resourceGuardOperationRequests": {
"description": "ResourceGuard Operation Requests",
"type": "array",
"items": {
"type": "string"
}
}
}
},
Expand Down Expand Up @@ -11235,6 +11499,87 @@
}
}
}
},
"UnlockDeleteRequest": {
"description": "Request body of unlock delete API.",
"type": "object",
"properties": {
"resourceGuardOperationRequests": {
"type": "array",
"items": {
"type": "string"
}
}
}
},
"UnlockDeleteResponse": {
"description": "Response of Unlock Delete API.",
"type": "object",
"properties": {
"unlockDeleteExpiryTime": {
"description": "This is the time when unlock delete privileges will get expired.",
"type": "string"
}
}
},
"ResourceGuardOperationDetail": {
"type": "object",
"properties": {
"vaultCriticalOperation": {
Copy link
Contributor

@ravbhatnagar ravbhatnagar Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can any of these properties be enums? read only?

"type": "string"
},
"defaultResourceRequest": {
"type": "string"
}
}
},
"ResourceGuardProxyBase": {
"type": "object",
"properties": {
"resourceGuardResourceId": {
"type": "string"
},
"resourceGuardOperationDetails": {
"type": "array",
"items": {
"$ref": "#/definitions/ResourceGuardOperationDetail"
}
},
"lastUpdatedTime": {
Copy link
Contributor

@ravbhatnagar ravbhatnagar Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark properties as readonly where ever applicable. lastUpdatedTime isnt a property that customer can set. Please mark this and any other such as readOnly

"type": "string"
}
}
},
"ResourceGuardProxyBaseResource": {
"allOf": [
{
"$ref": "#/definitions/Resource"
}
],
"properties": {
"properties": {
"$ref": "#/definitions/ResourceGuardProxyBase",
"description": "ResourceGuardProxyBaseResource properties"
}
}
},
"ResourceGuardProxyBaseResourceList": {
"description": "List of ResourceGuardProxyBase resources",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/ResourceList"
}
],
"properties": {
"value": {
"description": "List of resources.",
"type": "array",
"items": {
"$ref": "#/definitions/ResourceGuardProxyBaseResource"
}
}
}
}
},
"parameters": {
Expand Down
13 changes: 13 additions & 0 deletions .../preview/2021-02-01-preview/examples/ResourceGuardProxyCRUD/DeleteResourceGuardProxy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"parameters": {
"subscriptionId": "0b352192-dcac-4cc7-992e-a96190ccc68c",
"vaultName": "sampleVault",
"resourceGroupName": "SampleResourceGroup",
"resourceGuardProxyName": "swaggerExample",
"api-version": "2021-02-01-preview"
},
"responses": {
"200": {},
"204": {}
}
}
Loading