Skip to content

[Hub Generated] Review request for Microsoft.Devices to add version stable/2020-01-01 #12912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 1, 2021
Merged

[Hub Generated] Review request for Microsoft.Devices to add version stable/2020-01-01 #12912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ddc0f67
fixing swagger correctness for OBJECT_ADDITIONAL_PROPERTIES,
sudeepmsft Feb 9, 2021
2271b4a
resolving validation error - Swagger Correctness fix
sudeepmsft Feb 9, 2021
92d1f08
correcting validation error - swagger corretness fix
sudeepmsft Feb 9, 2021
6c40c99
reverting back changes - swagger correctness
sudeepmsft Feb 9, 2021
67c8f34
reverting some changes as it might require new versioning
sudeepmsft Feb 9, 2021
d9427a0
changing example and bringing api specs to parity
sudeepmsft Feb 14, 2021
9890411
fixing the comments in PR and added the recommendation plus some
sudeepmsft Feb 24, 2021
e11dc07
prettier fix
sudeepmsft Feb 25, 2021
bb028d9
model validation fix
sudeepmsft Feb 25, 2021
1c253a4
model validation fix
sudeepmsft Feb 25, 2021
2c8436b
fixing lintdiff error
sudeepmsft Feb 27, 2021
1548442
removing the package lock file
sudeepmsft Mar 1, 2021
31ebe6c
Revert "removing the package lock file"
sudeepmsft Mar 1, 2021
b860d67
reverting previous commit
sudeepmsft Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ce-manager/Microsoft.Devices/stable/2020-01-01/examples/DPSCertificateCreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": false,
"certificate": "############################",
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
"updated": "Thu, 12 Oct 2017 19:23:50 GMT"
},
Expand Down
1 change: 1 addition & 0 deletions ...ices/resource-manager/Microsoft.Devices/stable/2020-01-01/examples/DPSGetCertificate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": false,
"certificate": "72f988bf-86f1-41af-91ab-2d7cd011db47",
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
"updated": "Thu, 12 Oct 2017 19:23:50 GMT"
},
Expand Down
1 change: 1 addition & 0 deletions ...ces/resource-manager/Microsoft.Devices/stable/2020-01-01/examples/DPSGetCertificates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": false,
"certificate": "#############",
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
"updated": "Thu, 12 Oct 2017 19:23:50 GMT"
},
Expand Down
3 changes: 2 additions & 1 deletion ...s/resource-manager/Microsoft.Devices/stable/2020-01-01/examples/DPSVerifyCertificate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"certificateName": "cert",
"If-Match": "AAAAAAAADGk=",
"request": {
"certificate": "#####################################"
"certificate": "72f988bf-86f1-41af-91ab-2d7cd011db47"
}
},
"responses": {
Expand All @@ -16,6 +16,7 @@
"properties": {
"subject": "CN=andbucdevice1",
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"certificate": "72f988bf-86f1-41af-91ab-2d7cd011db47",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": true,
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
Expand Down
6 changes: 6 additions & 0 deletions ...viceprovisioningservices/resource-manager/Microsoft.Devices/stable/2020-01-01/iotdps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,12 @@
"type": "boolean",
"readOnly": true
},
"certificate": {
"description": "base-64 representation of X509 certificate .cer file or just .pem file content.",
Copy link
Member

@markcowl markcowl Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a base64-encoded string, then this should also have "format": "byte"

Copy link
Contributor Author

@sudeepmsft sudeepmsft Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included the fix in the latest commit.

"type": "string",
"format": "byte",
"readOnly": true
},
"created": {
"description": "The certificate's creation date and time.",
"type": "string",
Expand Down