Skip to content

read replica added #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

read replica added #12567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions ...orPostgreSQL/preview/2020-10-05-privatepreview/examples/ServerGroupCreateReadReplica.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
{
"parameters": {
"subscriptionId": "ffffffff-ffff-ffff-ffff-ffffffffffff",
"resourceGroupName": "TestGroup",
"serverGroupName": "hsctestsg",
"api-version": "2020-10-05-privatepreview",
"parameters": {
"location": "westus",
"properties": {
"createMode": "ReadReplica",
"sourceLocation": "eastus",
"sourceSubscriptionId": "dddddddd-dddd-dddd-dddd-dddddddddddd",
"sourceResourceGroupName": "SourceGroup",
"sourceServerGroupName": "pgtests-source-server-group"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/TestResourceGroup/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/hsctestsg",
"name": "hsctestsg",
"type": "Microsoft.DBforPostgreSQL/serverGroupsv2",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {},
"location": "westus2"
}
},
"201": {
"body": {
"id": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/TestResourceGroup/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/hsctestsg",
"name": "hsctestsg",
"type": "Microsoft.DBforPostgreSQL/serverGroupsv2",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {},
"location": "westus2"
}
},
"202": {}
}
}
5 changes: 5 additions & 0 deletions .../Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/examples/ServerGroupGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@
"startMinute": 0,
"customWindow": "Disabled"
},
"readReplicas": [
"/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.DBForPostgreSQL/serverGroupsv2/hsctestreadreplica-01",
"/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.DBForPostgreSQL/serverGroupsv2/hsctestreadreplica-02"
],
"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down
8 changes: 8 additions & 0 deletions ...Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/examples/ServerGroupList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
"delegatedSubnetArguments": {
"subnetArmResourceId": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/test-vnet-subnet"
},
"readReplicas": [
"/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/TestGroup/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/hsctestsg2"
],
"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down Expand Up @@ -109,6 +113,8 @@
"resourceProviderType": "Meru",
"availabilityZone": "1",
"standbyAvailabilityZone": "2",
"readReplicas": null,
"sourceServerGroup": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/TestGroup/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/hsctestsg1",
"serverRoleGroups": [
{
"name": "",
Expand Down Expand Up @@ -179,6 +185,8 @@
"delegatedSubnetArguments": {
"subnetArmResourceId": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/test-vnet-subnet"
},
"readReplicas": null,
"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down
6 changes: 6 additions & 0 deletions ...PostgreSQL/preview/2020-10-05-privatepreview/examples/ServerGroupListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
"delegatedSubnetArguments": {
"subnetArmResourceId": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/test-vnet-subnet"
},
"readReplicas": null,
"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down Expand Up @@ -110,6 +112,8 @@
"resourceProviderType": "Meru",
"availabilityZone": "1",
"standbyAvailabilityZone": "2",
"readReplicas": null,
Copy link
Contributor

@akning-ms akning-ms Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'null' is typical value here as example for reference?

Copy link
Contributor Author

@furkansahin furkansahin Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Do you think it is better to provode empty array instead of null?

"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down Expand Up @@ -180,6 +184,8 @@
"delegatedSubnetArguments": {
"subnetArmResourceId": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/test-vnet-subnet"
},
"readReplicas": null,
"sourceServerGroup": null,
"serverRoleGroups": [
{
"name": "",
Expand Down
28 changes: 23 additions & 5 deletions ...ce-manager/Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@
},
"Create a new server group as a point in time restore": {
"$ref": "./examples/ServerGroupCreatePITR.json"
},
"Create a new server group as a read replica": {
"$ref": "./examples/ServerGroupCreateReadReplica.json"
}
},
"parameters": [
Expand Down Expand Up @@ -1544,7 +1547,8 @@
"description": "The mode to create a new server group.",
"enum": [
"Default",
"PointInTimeRestore"
"PointInTimeRestore",
"ReadReplica"
],
"x-ms-enum": {
"name": "CreateMode",
Expand Down Expand Up @@ -1653,30 +1657,44 @@
}
}
},
"readReplicas": {
"type": "array",
"description": "The array of read replica server groups.",
"items": {
"type": "string"
},
"readOnly": true,
"uniqueItems": true
},
"sourceServerGroup": {
"type": "string",
"description": "The source server group id for read replica server groups.",
"readOnly": true
},
"sourceSubscriptionId": {
"type": "string",
"description": "The source subscription id to restore from. It's required when 'createMode' is 'PointInTimeRestore'",
"description": "The source subscription id to restore from. It's required when 'createMode' is 'PointInTimeRestore' or 'ReadReplica'",
"x-ms-mutability": [
"create"
]
},
"sourceResourceGroupName": {
"type": "string",
"description": "The source resource group name to restore from. It's required when 'createMode' is 'PointInTimeRestore'",
"description": "The source resource group name to restore from. It's required when 'createMode' is 'PointInTimeRestore' or 'ReadReplica'",
"x-ms-mutability": [
"create"
]
},
"sourceServerGroupName": {
"type": "string",
"description": "The source server group name to restore from. It's required when 'createMode' is 'PointInTimeRestore'",
"description": "The source server group name to restore from. It's required when 'createMode' is 'PointInTimeRestore' or 'ReadReplica'",
"x-ms-mutability": [
"create"
]
},
"sourceLocation": {
"type": "string",
"description": "The source server group location to restore from. It's required when 'createMode' is 'PointInTimeRestore'",
"description": "The source server group location to restore from. It's required when 'createMode' is 'PointInTimeRestore' or 'ReadReplica'",
"x-ms-mutability": [
"create"
]
Expand Down