Skip to content

Conversation

@syhamza
Copy link
Contributor

@syhamza syhamza commented Jan 13, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 13, 2021

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 2 Warnings warning [Detail]

Rule Message
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
New: Microsoft.ConfidentialLedger/preview/2020-12-01-preview/confidentialledger.json#L587
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
New: Microsoft.ConfidentialLedger/preview/2020-12-01-preview/confidentialledger.json#L453
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 13, 2021

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fc21882. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/confidentialledger/mgmt/2020-12-01-preview/confidentialledger [View full logs]  [Release SDK Changes]
    info	[Changelog] This is a new package
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from fc21882. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/confidentialledger/resource-manager/readme.md
  • ⚠️azure-mgmt-confidentialledger [View full logs]  [Release SDK Changes]
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-confidentialledger
    cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-confidentialledger
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-confidentialledger
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.confidentialledger
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.confidentialledger
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.confidentialledger
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/confidentialledger/azure-mgmt-confidentialledger/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-confidentialledger on PyPI
    cmderr	[changelogReportLatest] Traceback (most recent call last):
    cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    cmderr	[changelogReportLatest]     "__main__", mod_spec)
    cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    cmderr	[changelogReportLatest]     exec(code, run_globals)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
    cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 263, in main
    cmderr	[changelogReportLatest]     versions = [str(v) for v in client.get_ordered_versions(package_name)]
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/pypi_tools/pypi.py", line 40, in get_ordered_versions
    cmderr	[changelogReportLatest]     project = self.project(package_name)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/pypi_tools/pypi.py", line 25, in project
    cmderr	[changelogReportLatest]     response.raise_for_status()
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/requests/models.py", line 943, in raise_for_status
    cmderr	[changelogReportLatest]     raise HTTPError(http_error_msg, response=self)
    cmderr	[changelogReportLatest] requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://pypi.org/pypi/azure-mgmt-confidentialledger/json/
    warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
    warn	Not exact 2 reports found:
    warn		code_reports/latest/report.json
    warn	Not generating changelog.
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from fc21882. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/confidentialledger/resource-manager/readme.md
    warn	No file changes detected after generation
    warn	No package detected after generation
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fc21882. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/confidentialledger/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    warn	No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from fc21882. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2021-01-15 03:30:03 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-confidentialledger"
    cmderr	[generate.py] 2021-01-15 03:30:03 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2021-01-15 03:30:03 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/confidentialledger/azure-resourcemanager-confidentialledger --java.namespace=com.azure.resourcemanager.confidentialledger  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/confidentialledger/resource-manager/readme.md
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [POM][Skip] pom already has module azure-resourcemanager-confidentialledger
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2021-01-15 03:30:34 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-confidentialledger [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Got artifact_id: azure-resourcemanager-confidentialledger
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Got artifact: azure-resourcemanager-confidentialledger-1.0.0-beta.1-javadoc.jar
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Got artifact: azure-resourcemanager-confidentialledger-1.0.0-beta.1-sources.jar
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Got artifact: azure-resourcemanager-confidentialledger-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG Match jar package: azure-resourcemanager-confidentialledger-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-01-15 03:32:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12417/azure-sdk-for-java/azure-resourcemanager-confidentialledger/azure-resourcemanager-confidentialledger-1.0.0-beta.1.jar\" -o azure-resourcemanager-confidentialledger-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-confidentialledger -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-confidentialledger-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
    ```"}
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@akning-ms
Copy link
Contributor

according to discussion offline, this version will be changed to date-preview format as public preview. @ArcturusZhang

@openapi-workflow-bot
Copy link

Hi, @syhamza your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ArcturusZhang

@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2021
@openapi-workflow-bot
Copy link

Hi @syhamza, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

TaskHow to fixPrioritySupport (Microsoft alias)
AvocadoFix-AvocadoHighruowan
Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
LintDiffFix-LintDiffhighjianyxi, ruoxuan
If you need further help, please feedback via swagger feedback."

@lirenhe lirenhe removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants