Skip to content

Conversation

@vfedonkin
Copy link
Contributor

@vfedonkin vfedonkin commented Oct 5, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

anpint and others added 24 commits September 29, 2020 09:55
* Adds base for updating Microsoft.StorageSync from version stable/2020-03-01 to version 2020-09-01

* Updates readme

* Updates API version in new specs and examples

* Fix small issues with API version format in readme.md
add publicNetworkAccess property to datafactory
* added incident alerts and incident bookmarks endpoints

* changed definition order

* style changes

* remove labels

* change operation ids

* changing ids back

Co-authored-by: Moran Raz Mizrahi <[email protected]>
)

* Added unmanaged devices quota

* Specify format

* rename field

* Minimum 1000

* Add sentinelWorkspaceResourceIds

Co-authored-by: Liran Chen <[email protected]>
Co-authored-by: Orel Kayam <[email protected]>
Co-authored-by: Vikram Praveen Kumar <[email protected]>
…sion preview/2018-07-15-preview (Azure#10494)

* Adding table map params

* Changing the map to selected tables for now

* Adding prettier changes

Co-authored-by: Artyom Pavlichenko <[email protected]>
* Add sdk_customization.md

* Update doc with detail steps

* Add packageName in generateOutput

* Use propertyNames

* Fix logPrefix

* Update: add dryRun to collect info, fix typo
* Update pull_request_assignment.yml

China National Holiday

* Update pull_request_assignment.yml

* Update pull_request_assignment.yml
…Azure#10995)

* Fix or suppress spec violations
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.

* Try removing 2nd top-level heading, which _may_ have been causing a linter warning.

* Fix extra indention which prevented linter from running.

* Added dataStringComparisonBehavior parameter to reference data put/update spec.

* Fixed grammar.

* adding partitionkeyProperty to environmentInfo

* changing property name

* changing modelAsString

* Initial checkin of spec. Unchanged from GA release other than version.

* Remove .orig files

* Fix validation error by removing IoTHub ES from List ES example response

* Add extra example that was missing from preview spec.

* Add long-term environment to resource hierarchy, and update examples.

* Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource.

* Upsate sku description

* Add new TSI preview api-version to readme.md.

* Add suppressions for false-positive linter failures.

* Test suppression failures

* Adding preview package tag to several other places in readme.md

* Add preview package to the readme.go.md file

* Remove invalid required property from EnvironmentCreateOrUpdateParameters

* Initial version of data plane swagger spec for PAYG (Preview) SKU.

* Added missing Readme.md

* Fixed name of readme

* Fixed path to swagger json

* Attempt to fix readme

* Apply suggestions from code review

Co-Authored-By: dmdenmsft <[email protected]>

* Update timeseriesinsights.json

* Update timeseriesinsights.json

* Added link to oav issue

* instance field description changes and examples

Co-authored-by: Eric Dettinger <[email protected]>
Co-authored-by: Karthik Subramanian <[email protected]>
Co-authored-by: Ravi Kumar Suresh Babu <[email protected]>
Co-authored-by: ravikumarsureshbabu <[email protected]>
Co-authored-by: Dmitry Denisov <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Karthik Subramanian <[email protected]>
Co-authored-by: Ric Serradas <[email protected]>
Co-authored-by: Richard Wydrowski <[email protected]>
Co-authored-by: Sandip Raiyani <[email protected]>
* update all swaggers to 2020-05-01 api

* Fix some validations

* Fixed a few casing issues in examples.

* Fixed one PR comment

* Streaming swagger description updates

* Fixed typos

* Added 1 custom word for spellcheck

* Updates for the deprecated property

Co-authored-by: Ning Lin <[email protected]>
…meters, and adjust API responses. (Azure#11010)

* Update TNM Swagger to Oct 1, 2020

* Prettier fix and example fix

* Fix example configure/unconfigure responses to 200

* Fix spelling errors and update README.

* Fix read me

* .

* Add acceptable spelling errors.

* .

* Rename example resource names and remove nulls from examples
…dexer, datasource and skillset metadata (Azure#10839)

* Add encryption key to indexer, datasource and skillset metadata in 2020-06-30 API version

* Add encryption key to indexer, datasource and skillset metadata in 2020-06-30-preview API version

* change indexer description

* Fix examples

Co-authored-by: Arvind Krishnaa Jagannathan <[email protected]>
…sizes (Azure#10542)

* Copy 2020-06-01 to 2020-08-01

* Update version to 2020-08-01 and update getComputeInstance.json example

* Update readme

* Update vmSizes API

* Adding estimatedVMPrices

* Update the definition

* Update machineLearningServices.json

Fixing validation errors

* Update ListVMSizesResult.json

* Fixed api version

* Update ListVMSizesResult.json

* Merging changes from version 2020-06-01 to 2020-08-01

* Resolve conflicts

* Adding extra line to resolve conflict

* Add extra line

Co-authored-by: ramagott <[email protected]>
* add management group registration description to ARM

* Add response to MG registration description

* fix ID parameter for MG register

* fix API signature linter error

* fix MG register operationID

* fix repsonse schema for MG register

* move MG register to rp section

* update operationId for MG register

* update operationID for MG register
* Adds base for updating Microsoft.AzureStackHCI from version preview/2020-03-01-preview to version 2020-10-01

* Updates readme

* Updates API version in new specs and examples

* Use common-types v2

* Use ListBySubscription instead of List
Related to Azure/azure-sdk-for-js#11473

The JS exporter requires additional polymorphism hints to completely serialize `baseData`. For now, `additionalProperties` should be passed until something like `oneOf` becomes available.
* Add codeowners for Monitor Exporters swagger

* Add more codeowner aliases
* Start stable 2020-10-31 swagger.

* Updates.

* Fix some validation errors.

* Fix prettier error.

* Update swagger.

* Update swagger.

* Add traceparent and tracestate to dictionary.

* Update swagger.

* Update swagger.

* Update error descriptions.

* Update examples.

* Update API descriptions.

* Rename ModelData to DigitalTwinsModelData.

* Update swagger.

* Add tracestate as a custom word.

* Update swagger.
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 5, 2020

Swagger pipeline restarted successfully, please wait for status update in this comment.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 5, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d97efdc with merge commit 57c9da906e0601a8db8e7db6ab365ad03e536d30. SDK Automation 13.0.17.20200918.2
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
  • ️✔️@azure/arm-apimanagement [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
    [npmPack] created ./dist/arm-apimanagement.js in 1.7s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.4kB  esm/operations/api.js                                  
    [npmPack] npm notice 9.8kB   esm/operations/apiDiagnostic.js                        
    [npmPack] npm notice 2.8kB   esm/models/apiDiagnosticMappers.js                     
    [npmPack] npm notice 2.0kB   esm/operations/apiExport.js                            
    [npmPack] npm notice 466B    esm/models/apiExportMappers.js                         
    [npmPack] npm notice 9.6kB   esm/operations/apiIssue.js                             
    [npmPack] npm notice 8.8kB   esm/operations/apiIssueAttachment.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueAttachmentMappers.js                
    [npmPack] npm notice 8.7kB   esm/operations/apiIssueComment.js                      
    [npmPack] npm notice 2.8kB   esm/models/apiIssueCommentMappers.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueMappers.js                          
    [npmPack] npm notice 6.1kB   esm/apiManagementClient.js                             
    [npmPack] npm notice 2.6kB   esm/apiManagementClientContext.js                      
    [npmPack] npm notice 2.4kB   esm/operations/apiManagementOperations.js              
    [npmPack] npm notice 468B    esm/models/apiManagementOperationsMappers.js           
    [npmPack] npm notice 21.7kB  esm/operations/apiManagementService.js                 
    [npmPack] npm notice 3.0kB   esm/models/apiManagementServiceMappers.js              
    [npmPack] npm notice 2.8kB   esm/operations/apiManagementServiceSkus.js             
    [npmPack] npm notice 515B    esm/models/apiManagementServiceSkusMappers.js          
    [npmPack] npm notice 3.1kB   esm/models/apiMappers.js                               
    [npmPack] npm notice 9.8kB   esm/operations/apiOperation.js                         
    [npmPack] npm notice 2.8kB   esm/models/apiOperationMappers.js                      
    [npmPack] npm notice 7.9kB   esm/operations/apiOperationPolicy.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiOperationPolicyMappers.js                
    [npmPack] npm notice 7.1kB   esm/operations/apiPolicy.js                            
    [npmPack] npm notice 2.8kB   esm/models/apiPolicyMappers.js                         
    [npmPack] npm notice 2.8kB   esm/operations/apiProduct.js                           
    [npmPack] npm notice 2.7kB   esm/models/apiProductMappers.js                        
    [npmPack] npm notice 9.7kB   esm/operations/apiRelease.js                           
    [npmPack] npm notice 2.8kB   esm/models/apiReleaseMappers.js                        
    [npmPack] npm notice 2.8kB   esm/operations/apiRevision.js                          
    [npmPack] npm notice 473B    esm/models/apiRevisionMappers.js                       
    [npmPack] npm notice 9.9kB   esm/operations/apiSchema.js                            
    [npmPack] npm notice 2.8kB   esm/models/apiSchemaMappers.js                         
    [npmPack] npm notice 8.5kB   esm/operations/apiTagDescription.js                    
    [npmPack] npm notice 2.8kB   esm/models/apiTagDescriptionMappers.js                 
    [npmPack] npm notice 9.4kB   esm/operations/apiVersionSet.js                        
    [npmPack] npm notice 2.9kB   esm/models/apiVersionSetMappers.js                     
    [npmPack] npm notice 1.3MB   dist/arm-apimanagement.js                              
    [npmPack] npm notice 494.4kB dist/arm-apimanagement.min.js                          
    [npmPack] npm notice 10.8kB  esm/operations/authorizationServer.js                  
    [npmPack] npm notice 2.9kB   esm/models/authorizationServerMappers.js               
    [npmPack] npm notice 10.3kB  esm/operations/backend.js                              
    [npmPack] npm notice 2.8kB   esm/models/backendMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/cache.js                                
    [npmPack] npm notice 2.8kB   esm/models/cacheMappers.js                             
    [npmPack] npm notice 7.9kB   esm/operations/certificate.js                          
    [npmPack] npm notice 2.8kB   esm/models/certificateMappers.js                       
    [npmPack] npm notice 6.4kB   esm/operations/contentType.js                          
    [npmPack] npm notice 8.4kB   esm/operations/contentTypeContentItem.js               
    [npmPack] npm notice 2.8kB   esm/models/contentTypeContentItemMappers.js            
    [npmPack] npm notice 2.8kB   esm/models/contentTypeMappers.js                       
    [npmPack] npm notice 6.8kB   esm/operations/delegationSettings.js                   
    [npmPack] npm notice 2.8kB   esm/models/delegationSettingsMappers.js                
    [npmPack] npm notice 4.4kB   esm/operations/deletedServices.js                      
    [npmPack] npm notice 2.7kB   esm/models/deletedServicesMappers.js                   
    [npmPack] npm notice 9.3kB   esm/operations/diagnostic.js                           
    [npmPack] npm notice 2.8kB   esm/models/diagnosticMappers.js                        
    [npmPack] npm notice 9.2kB   esm/operations/emailTemplate.js                        
    [npmPack] npm notice 2.8kB   esm/models/emailTemplateMappers.js                     
    [npmPack] npm notice 12.9kB  esm/operations/gateway.js                              
    [npmPack] npm notice 6.5kB   esm/operations/gatewayApi.js                           
    [npmPack] npm notice 2.7kB   esm/models/gatewayApiMappers.js                        
    [npmPack] npm notice 8.7kB   esm/operations/gatewayHostnameConfiguration.js         
    [npmPack] npm notice 2.9kB   esm/models/gatewayHostnameConfigurationMappers.js      
    [npmPack] npm notice 2.9kB   esm/models/gatewayMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/group.js                                
    [npmPack] npm notice 2.8kB   esm/models/groupMappers.js                             
    [npmPack] npm notice 6.1kB   esm/operations/groupUser.js                            
    [npmPack] npm notice 2.7kB   esm/models/groupUserMappers.js                         
    [npmPack] npm notice 11.0kB  esm/operations/identityProvider.js                     
    [npmPack] npm notice 2.9kB   esm/models/identityProviderMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                    
    [npmPack] npm notice 2.6kB   esm/operations/index.js                                
    [npmPack] npm notice 3.8kB   esm/operations/issue.js                                
    [npmPack] npm notice 2.7kB   esm/models/issueMappers.js                             
    [npmPack] npm notice 9.1kB   esm/operations/logger.js                               
    [npmPack] npm notice 2.8kB   esm/models/loggerMappers.js                            
    [npmPack] npm notice 326.5kB esm/models/mappers.js                                  
    [npmPack] npm notice 13.3kB  esm/operations/namedValue.js                           
    [npmPack] npm notice 2.9kB   esm/models/namedValueMappers.js                        
    [npmPack] npm notice 3.4kB   esm/operations/networkStatus.js                        
    [npmPack] npm notice 515B    esm/models/networkStatusMappers.js                     
    [npmPack] npm notice 5.0kB   esm/operations/notification.js                         
    [npmPack] npm notice 2.7kB   esm/models/notificationMappers.js                      
    [npmPack] npm notice 5.9kB   esm/operations/notificationRecipientEmail.js           
    [npmPack] npm notice 2.7kB   esm/models/notificationRecipientEmailMappers.js        

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 5, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

tonykslee and others added 5 commits November 5, 2020 18:55
* added new folder for swagger api version

* updated api with current request/responses

* updated api version

* updated readme

* fixed typo

* added operation list

* added error to operation list

* removed redundant files

* removed operations operation from workbooks_api

* added api version parameters

* added references to the new examples

* removed delete since it didn't change from the last api version

* added new operations api file for compatibility

* fixing lint errors

* fix lint errors

* fixing model errors

* model errors

* fixing modeling errors

* fixing model errors

* fixing model errors

* fixing model errors

* fix model errors

* fix model errors

* fix model errors

* ran prettier

* lint error added delete example

* lint error added delete example

* added unreferenced json files

* fixed model errors

* fixed model errors

* removed operations from readme

* updated examples

* resolving lint, avocado, prettier issues

* updated workbook operations api

* changed operation path

* removed aiOperatrions from new api version

* udpated workbook operations name

* pascal case path names

* added myworkbooks

* added exclusions

* updated exclusions to be more specific

* added exclusion and updated operations path

* updated operations path

* Revert "updated operations path"

This reverts commit 832f2f0.

* changed operations path case

* Revert "changed operations path case"

This reverts commit da50e81.

* replaced all lowercase microsoft.insights with Pascal Case

* Revert "replaced all lowercase microsoft.insights with Pascal Case"

This reverts commit 6d9a19a.

* replaced all lowercase microsoft.insights with Pascal Case

* added another exclusijon for webtests default responses

* added exclusion for OperationsAPIImplementation

* updated suppression

* using existing Identity Definition

* remove CDN references from Operations API file

* added errorResponse type object in operations api

* update to use existing common type

* ran prettier

* added enum values to identity types in types.json

* removed use of common type for identity

* updated identity schema

* updated identity schema

* updated identity schema

* updated identity schema

* updated identity schema

* ran prettier
* support discrimitor and readonly at same time

* add trenton file and overrides
* Added TextAnalyticsError to HealthcareJobState

* Update TextAnalytics.json
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 11045 in repo Azure/azure-rest-api-specs

@vfedonkin
Copy link
Contributor Author

Prepared another PR #11549

@vfedonkin vfedonkin closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Management CI-BreakingChange-Python WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.