Skip to content

Conversation

@JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Nov 3, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review November 3, 2025 04:38
Copilot AI review requested due to automatic review settings November 3, 2025 04:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes support for Azure Database for MySQL single-server cmdlets and focuses exclusively on Azure Database for MySQL flexible servers. This is a breaking change that removes approximately 20+ legacy cmdlets and introduces several improvements for flexible server management.

Key changes:

  • Removed all single-server cmdlets (e.g., Get-AzMySqlServer, New-AzMySqlServer, Update-AzMySqlConfiguration)
  • Retained and updated flexible server cmdlets
  • Updated module dependencies, output types, and parameter types
  • Added breaking change exception file with 102 documented breaking changes
  • Updated help documentation and tests

Reviewed Changes

Copilot reviewed 138 out of 217 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/MySql/MySql/ChangeLog.md Added breaking change notice with reference link
src/MySql/MySql/Az.MySql.psd1 Removed single-server cmdlets from exports; updated Az.Accounts dependency to 5.3.0
tools/StaticAnalysis/Exceptions/Az.MySql/BreakingChangeIssues.csv Added 102 breaking change exception entries documenting removed cmdlets and API changes
Multiple help files Removed documentation for single-server cmdlets; updated output types for flexible server cmdlets
Test files Removed tests for single-server cmdlets; updated flexible server test scenarios
src/MySql/MySql.Autorest/test/utils.ps1 Simplified test setup; improved password handling
Various .md files Updated parameter types from enums to strings; removed "To construct" notes for InputObject parameters

@@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249).
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry is too vague for users. It should explicitly state that single-server cmdlets have been removed and list the major breaking changes. Users need to understand what specific cmdlets are no longer available and what alternatives they should use. Consider adding bullet points listing the removed cmdlet categories (e.g., "Removed single-server cmdlets: Get-AzMySqlServer, New-AzMySqlServer, Update-AzMySqlConfiguration, etc.") and guidance to migrate to flexible server cmdlets.

Copilot generated this review using guidance from repository custom instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants