Skip to content

[Az.ServiceFabric] Updating SDK After Typespec Migration #28169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 17, 2025
Merged

[Az.ServiceFabric] Updating SDK After Typespec Migration #28169

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b3fa9bc
sdk after typespec migration
iliu816 Jul 10, 2025
4e05a74
*Cmdlet fixes, text fixes, updated recordings
iliu816 Jul 10, 2025
ca3e58e
update changelog
iliu816 Jul 11, 2025
0943ce8
move update description in changelog under Upcoming Releases
iliu816 Jul 14, 2025
9472e2e
add suppression for case changes
iliu816 Jul 15, 2025
e0e3590
Replacing src/ServiceFabric/ServiceFabric.Management.Sdk/README.md as…
iliu816 Jul 15, 2025
1fb52f1
updated readme.md and reran autorest commands
iliu816 Jul 16, 2025
3595312
remove accidental hypen
iliu816 Jul 16, 2025
86e7789
casing fixes for VM in ServiceFabric
iliu816 Jul 16, 2025
b76645b
add breaking change exceptions for ServiceFabric.Management.Sdk
iliu816 Jul 16, 2025
dd08c4a
mask some sas keys
iliu816 Jul 16, 2025
b5353bb
plaintext password -> random
iliu816 Jul 17, 2025
0df3a41
missed a redaction
iliu816 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/Common.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,12 +382,12 @@ function Get-ManagedAppTypeV2Name

function Get-ManagedAppPackageV1
{
return "https://sfmcsttest.blob.core.windows.net/sfmc-ps/Voting.sfpkg?sp=r&st=2023-09-21T03:04:25Z&se=2023-11-01T11:04:25Z&spr=https&sv=2022-11-02&sr=b&sig=BTFecBFf5%2Bzm5eLH0XjqBt1r%2FknbbaAniftETWddh8A%3D"
return "https://sftestappstorage.blob.core.windows.net/managed-application-deployment/Voting.sfpkg?sp=r&st=2025-07-09T21:48:25Z&se=2025-07-10T06:03:25Z&skoid=d078218f-29d9-4be8-9eb5-7325194a81e9&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2025-07-09T21:48:25Z&ske=2025-07-10T06:03:25Z&sks=b&skv=2024-11-04&spr=https&sv=2024-11-04&sr=b&sig=O6IRHm5WkjTq6ldNfhQyCzKKDfioDdFjr8Bxk8OiE7c%3D"
}

function Get-ManagedAppPackageV2
{
return "https://sfmcsttest.blob.core.windows.net/sfmc-ps/Voting.2.0.0.sfpkg?sp=r&st=2023-09-21T21:45:34Z&se=2023-11-01T05:45:34Z&spr=https&sv=2022-11-02&sr=b&sig=K0NUrFC47kR3OTwVG5rANy88I0eVP9hQ%2F7MXUSDAtsA%3D"
return "https://sftestappstorage.blob.core.windows.net/managed-application-deployment/Voting.2.0.0.sfpkg?sp=r&st=2025-07-09T21:48:50Z&se=2025-07-10T06:03:50Z&skoid=d078218f-29d9-4be8-9eb5-7325194a81e9&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2025-07-09T21:48:50Z&ske=2025-07-10T06:03:50Z&sks=b&skv=2024-11-04&spr=https&sv=2024-11-04&sr=b&sig=nwi9hFbr7nDiZDjbzRdcElxB1JbuAxUsmTUdrm9QNc0%3D"
}

function Get-ManagedStatelessServiceTypeName
Expand Down
33 changes: 21 additions & 12 deletions ...eFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersApplicationTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@ function Test-ManagedAppType
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-ManagedAppType"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

Expand Down Expand Up @@ -81,11 +83,13 @@ function Test-ManagedAppTypeVersion
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-ManagedAppTypeVersion"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

Expand All @@ -108,7 +112,7 @@ function Test-ManagedAppTypeVersion

$tags = @{"test"="tag"}

$appTypeVersion = $appTypeVersionFromGet | Set-AzServiceFabricManagedClusterApplicationTypeVersion -Tag $tags -Verbose
$appTypeVersion = $appTypeVersionFromGet | Set-AzServiceFabricManagedClusterApplicationTypeVersion -Tag $tags -PackageUrl $packageV1 -Verbose
Assert-AreEqual "Succeeded" $appTypeVersion.ProvisioningState

$appTypeVersionFromGet = Get-AzServiceFabricManagedClusterApplicationTypeVersion -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appTypeName -Version $v1
Expand All @@ -117,9 +121,10 @@ function Test-ManagedAppTypeVersion
Assert-HashtableEqual $appTypeVersion.Tags $appTypeVersionFromGet.Tags

# Test noop
$appTypeVersionNoop = $appTypeVersion | Set-AzServiceFabricManagedClusterApplicationTypeVersion
$appTypeVersionNoop = $appTypeVersion | Set-AzServiceFabricManagedClusterApplicationTypeVersion -PackageUrl $packageV1 -Verbose
Assert-AreEqual "Succeeded" $appTypeVersionNoop.ProvisioningState
Assert-AreEqualObjectProperties $appTypeVersion $appTypeVersionNoop
Assert-AreEqual $appTypeVersion.Id $appTypeVersionFromGet.Id
Assert-HashtableEqual $appTypeVersion.Tags $appTypeVersionFromGet.Tags

$removeResponse = Remove-AzServiceFabricManagedClusterApplicationTypeVersion -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appTypeName -Version $v1 -Force -PassThru -Verbose
Assert-True { $removeResponse }
Expand All @@ -137,11 +142,13 @@ function Test-ManagedApp
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-ManagedApp"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

Expand Down Expand Up @@ -207,11 +214,13 @@ function Test-ManagedService
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-ManagedService"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

Expand Down
34 changes: 17 additions & 17 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ function Test-CreateBasicCluster
{
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-Create-BasicCluster"}

$tags = @{"test"="tag"}
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Expand Down Expand Up @@ -52,17 +52,17 @@ function Test-CreateBasicCluster

function Test-NodeTypeOperations
{
#$resourceGroupName = "sfmcps-rg-" + (getAssetname)
#$clusterName = "sfmcps-" + (getAssetname)
$resourceGroupName = "sfmcps-rg-node-ops"
$clusterName = "sfmcps-node-ops"
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-NodeTypeOperations"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
Expand Down Expand Up @@ -101,17 +101,17 @@ function Test-NodeTypeOperations

function Test-CertAndExtension
{
#$resourceGroupName = "sfmcps-rg-" + (getAssetname)
#$clusterName = "sfmcps-" + (getAssetname)
$resourceGroupName = "sfmcps-rg-tcl1"
$clusterName = "sfmcps-test-cluster1"
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-CertAndExtension"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState

Expand Down Expand Up @@ -157,9 +157,9 @@ function Test-AddNetworkSecurityRule
$pass = (ConvertTo-SecureString -AsPlainText -Force "TestPass1234!@#")
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-AddNetworkSecurityRule"}

$tags = @{"test"="tag"}
Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
-AdminPassword $pass -Sku Basic -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Expand Down
4 changes: 4 additions & 0 deletions src/ServiceFabric/ServiceFabric.Test/ServiceFabric.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,8 @@
<None Update="Resources\*.json" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<ItemGroup>
<None Update="PemFiles\*.*" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

</Project>
Loading
Loading