Skip to content

[PS] Add breaking change message for Autoscale submodule under Monitor module #28101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Jul 2, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review July 17, 2025 08:31
@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 08:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds breaking change annotations for the Autoscale submodule under the Monitor module. The changes primarily involve updating parameter types from arrays to lists and adding breaking change metadata to indicate this transition will occur in version 15.0.0.

  • Reorganizes the Autoscale project structure in the Monitor solution file with new GUID references
  • Adds breaking change annotations to multiple PowerShell functions for array-to-list parameter type changes
  • Updates README configuration to include breaking change directives for cmdlets and parameters

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/Monitor/Monitor/Az.Monitor.psd1 Updates generated date timestamp
src/Monitor/Monitor.sln Reorganizes Autoscale project references with new GUIDs and folder structure
src/Monitor/Autoscale.Autorest/resources/README.md Adds new documentation for the resources directory
src/Monitor/Autoscale.Autorest/generate-info.json Updates generation ID
src/Monitor/Autoscale.Autorest/docs/Az.Autoscale.md Updates module GUID
src/Monitor/Autoscale.Autorest/custom/*.ps1 Adds breaking change attributes to parameters transitioning from Array to List
src/Monitor/Autoscale.Autorest/README.md Adds comprehensive breaking change directives for cmdlets and parameters
src/Monitor/Autoscale.Autorest/Properties/AssemblyInfo.cs Adds new assembly metadata file

@YanaXu
Copy link
Contributor

YanaXu commented Jul 21, 2025

The breaking change message is not clear to me:

WARNING: Upcoming breaking changes in the cmdlet 'New-AzActivityLogAlertAlertRuleAnyOfOrLeafConditionObject' :

- The output type 'Microsoft.Azure.PowerShell.Cmdlets.Monitor.ActivityLogAlert.Models.Api20201001.AlertRuleAnyOfOrLeafCondition' is changing
- The following properties in the output type are being deprecated : '"ContainsAny","AnyOf[]"'
- The following properties are being added to the output type : '"List[ContainsAny]","List[AnyOf]"'
- This change will take effect on '11/3/2025'- The change is expected to take effect from Az version : '15.0.0'
- The change is expected to take effect from version : '7.0.0'
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.

@YanaXu
Copy link
Contributor

YanaXu commented Jul 21, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jul 21, 2025

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@JoyerJin
Copy link
Contributor Author

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@JoyerJin JoyerJin added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants