Create Az.CloudHsm Module for 2025-03-31 #27947

emmeliaAra · 2025-06-12T14:38:38Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-06-12T14:38:41Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull Request Overview

This PR scaffolds the new Az.CloudHsm PowerShell module targeting the 2025-03-31 API version.

Added autogenerated comment-based help files for core cmdlets (New, Get, Backup, Remove).
Introduced custom script implementations for each cmdlet under the custom/ folder.
Updated module packaging/configuration (AutoRest directives, AssemblyInfo.cs, .gitignore, .gitattributes, NuGet.Config).

Reviewed Changes

Copilot reviewed 82 out of 82 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/CloudHsm/CloudHsm.Autorest/docs/Remove-AzCloudHsm.md	Help content for the Remove-AzCloudHsm cmdlet
src/CloudHsm/CloudHsm.Autorest/docs/New-AzCloudHsm.md	Help content for the New-AzCloudHsm cmdlet
src/CloudHsm/CloudHsm.Autorest/docs/Get-AzCloudHsm.md	Help content for the Get-AzCloudHsm cmdlet
src/CloudHsm/CloudHsm.Autorest/docs/Backup-AzCloudHsm.md	Help content for the Backup-AzCloudHsm cmdlet
src/CloudHsm/CloudHsm.Autorest/docs/README.md	Overview of docs generation process
src/CloudHsm/CloudHsm.Autorest/custom/*.ps1	Script-based implementations of all core cmdlets
src/CloudHsm/CloudHsm.Autorest/README.md	AutoRest configuration and module-level documentation
src/CloudHsm/CloudHsm.Autorest/Properties/AssemblyInfo.cs	Assembly metadata for module versioning
src/CloudHsm/CloudHsm.Autorest/.gitignore & .gitattributes	Build and source-control settings
NuGet.Config	Added OneBranch-Consumption feed

Comments suppressed due to low confidence (1)

src/CloudHsm/CloudHsm.Autorest/docs/Get-AzCloudHsm.md:92

[nitpick] Renumber this heading to "Example 3" to avoid duplicating "Example 2" in the examples section.

### Example 2:  Get a Cloud HSM in a resource group

src/CloudHsm/CloudHsm.Autorest/docs/Remove-AzCloudHsm.md

src/CloudHsm/CloudHsm.Autorest/docs/New-AzCloudHsm.md

vidai-msft · 2025-06-13T06:10:13Z

/azp run

azure-pipelines · 2025-06-13T06:10:20Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

vidai-msft

Please remove the test stubs whose cmdlets are removed or hidden.

NuGet.Config

src/CloudHsm/CloudHsm.Autorest/test/Get-AzCloudHsm.Tests.ps1

github-actions · 2025-06-13T08:30:58Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

src/CloudHsm/CloudHsm.Autorest/docs/Az.CloudHsmCmdlet.Design.md

vidai-msft · 2025-06-14T03:24:21Z

/azp run

azure-pipelines · 2025-06-14T03:24:42Z

Azure Pipelines successfully started running 3 pipeline(s).

emmeliaAra · 2025-06-16T10:51:16Z

/azp run

azure-pipelines · 2025-06-16T10:51:28Z

Commenter does not have sufficient privileges for PR 27947 in repo Azure/azure-powershell

NuGet.Config

vidai-msft · 2025-06-16T13:26:01Z

/azp run

azure-pipelines · 2025-06-16T13:26:17Z

Azure Pipelines successfully started running 3 pipeline(s).

emmeliaAra · 2025-06-16T14:00:50Z

Hi @vidai-msft, the checks are failing with the error below. Can you please help with the steps to resolve it ?

Write-Error: Unhandled exception. System.Management.Automation.CmdletInvocationException: The member 'FormatsToProcess' in the module manifest is not valid: Cannot find path 'D:\a_work\1\s\artifacts\Debug\Az.CloudHsm\CloudHsm.Autorest/Az.CloudHsm.format.ps1xml' because it does not exist.. Verify that a valid value is specified for this field in the 'D:\a_work\1\s\artifacts\Debug\Az.CloudHsm\Az.CloudHsm.psd1' file.
---> System.ArgumentException: The member 'FormatsToProcess' in the module manifest is not valid: Cannot find path 'D:\a_work\1\s\artifacts\Debug\Az.CloudHsm\CloudHsm.Autorest/Az.CloudHsm.format.ps1xml' because it does not exist.. Verify that a valid value is specified for this field in the 'D:\a_work\1\s\artifacts\Debug\Az.CloudHsm\Az.CloudHsm.psd1' file.
at System.Management.Automation.MshCommandRuntime.ThrowTerminatingError(ErrorRecord errorRecord)
--- End of inner exception stack trace ---
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
at System.Management.Automation.Runspaces.Pipeline.Invoke()
at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection1 output, PSInvocationSettings settings) at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings) at System.Management.Automation.PowerShell.Invoke() at StaticAnalysis.BreakingChangeAnalyzer.BreakingChangeAnalyzer.Analyze(IEnumerable1 cmdletProbingDirs, Func2 directoryFilter, Func2 cmdletFilter, IEnumerable1 modulesToAnalyze) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\BreakingChangeAnalyzer.cs:line 138 at StaticAnalysis.BreakingChangeAnalyzer.BreakingChangeAnalyzer.Analyze(IEnumerable1 cmdletProbingDirs, IEnumerable`1 modulesToAnalyze) in D:\a_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\BreakingChangeAnalyzer.cs:line 66
at StaticAnalysis.Program.Main(String[] args) in D:\a_work\1\s\tools\StaticAnalysis\Program.cs:line 189
Help record Backup-AzCloudHsm has no cmdlet.
Help record Get-AzCloudHsm has no cmdlet.
Help record New-AzCloudHsm has no cmdlet.
Help record Remove-AzCloudHsm has no cmdlet.
Help record Restore-AzCloudHsm has no cmdlet.
Help record Update-AzCloudHsm has no cmdlet.

…/azure-powershell into cloudHsm-2025-03-31-v

vidai-msft · 2025-06-17T02:38:43Z

/azp run

azure-pipelines · 2025-06-17T02:38:58Z

Azure Pipelines successfully started running 3 pipeline(s).

vidai-msft · 2025-06-17T02:59:18Z

src/CloudHsm/CloudHsm.Autorest/README.md

+# - (this-folder)/relative-path-to-your-local-readme.md
+
+input-file: 
+    - $(this-folder)/../../../../azure-rest-api-specs-myFork/specification/hardwaresecuritymodules/resource-manager/Microsoft.HardwareSecurityModules/stable/2025-03-31/cloudHsm.json


$(this-folder) is pointing to a local file. This is only used for development when swagger is not ready. However, it must be updated to a remote swagger file when swagger is ready. That is also the cause why CI failed. Please update the value if swagger is ready and then try again.

github-actions · 2025-06-17T03:02:33Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

github-actions · 2025-06-17T04:28:40Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Initial commit Az.CloudHsm 2025-03-31

06b58a3

Copilot AI review requested due to automatic review settings June 12, 2025 14:38

emmeliaAra changed the title ~~Initial commit Az.CloudHsm 2025-03-31~~ Create Az.CloudHsm Module for 2025-03-31 Jun 12, 2025

This comment was marked as outdated.

Sign in to view

jkapil approved these changes Jun 12, 2025

View reviewed changes

jkapil requested a review from Copilot June 12, 2025 23:19

Copilot AI reviewed Jun 12, 2025

View reviewed changes

src/CloudHsm/CloudHsm.Autorest/docs/Remove-AzCloudHsm.md Outdated Show resolved Hide resolved

src/CloudHsm/CloudHsm.Autorest/docs/New-AzCloudHsm.md Outdated Show resolved Hide resolved

src/CloudHsm/CloudHsm.Autorest/docs/New-AzCloudHsm.md Outdated Show resolved Hide resolved

vidai-msft requested changes Jun 13, 2025

View reviewed changes

NuGet.Config Outdated Show resolved Hide resolved

src/CloudHsm/CloudHsm.Autorest/test/Get-AzCloudHsm.Tests.ps1 Outdated Show resolved Hide resolved

src/CloudHsm/CloudHsm.Autorest/test/Get-AzCloudHsm.Tests.ps1 Outdated Show resolved Hide resolved

vidai-msft added the needs-revision label Jun 13, 2025

vidai-msft requested changes Jun 13, 2025

View reviewed changes

src/CloudHsm/CloudHsm.Autorest/docs/Az.CloudHsmCmdlet.Design.md Outdated Show resolved Hide resolved

emmeliaAra added 3 commits June 13, 2025 14:28

Update module - feedback

2fde28a

Remove tests for the cmdlets that are removed or hidden.

073193d

Resolve conflict

f65fb95

emmeliaAra requested a review from vidai-msft June 13, 2025 14:12

emmeliaAra added needs-review and removed needs-revision labels Jun 13, 2025

Remove empty space

55e804d

vidai-msft requested changes Jun 16, 2025

View reviewed changes

NuGet.Config Outdated Show resolved Hide resolved

Reset NuGet Config from Main

490eac2

emmeliaAra requested a review from vidai-msft June 16, 2025 13:08

emmeliaAra added 2 commits June 16, 2025 21:50

merge with main

041133f

Merge branch 'cloudHsm-2025-03-31-v' of https://github.com/emmeliaAra…

12b0246

…/azure-powershell into cloudHsm-2025-03-31-v

vidai-msft requested changes Jun 17, 2025

View reviewed changes

vidai-msft added the Do Not Merge 🚫 label Jun 17, 2025

vidai-msft added needs-revision and removed needs-review labels Jun 17, 2025

Create Az.CloudHsm Module for 2025-03-31 #27947

Are you sure you want to change the base?

Create Az.CloudHsm Module for 2025-03-31 #27947

Uh oh!

Conversation

emmeliaAra commented Jun 12, 2025

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jun 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vidai-msft commented Jun 13, 2025

Uh oh!

azure-pipelines bot commented Jun 13, 2025

Uh oh!

vidai-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025

Uh oh!

Uh oh!

vidai-msft commented Jun 14, 2025

Uh oh!

azure-pipelines bot commented Jun 14, 2025

Uh oh!

emmeliaAra commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

Uh oh!

vidai-msft commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

emmeliaAra commented Jun 16, 2025

Uh oh!

vidai-msft commented Jun 17, 2025

Uh oh!

azure-pipelines bot commented Jun 17, 2025

Uh oh!

vidai-msft Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

Uh oh!