Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not squash][Storage] merge main change to storage preview branch #27505

Open
wants to merge 108 commits into
base: Az.Storage-preview
Choose a base branch
from

Conversation

blueww
Copy link
Member

@blueww blueww commented Apr 3, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

grizzlytheodore and others added 30 commits March 7, 2025 11:30
Co-authored-by: Mike F. Robbins <[email protected]>
… about ensuring Enhanced Policy for Trusted Launch VMs when configuring protection for Azure VMs . (Azure#27284)
@blueww blueww added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Apr 3, 2025
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link

github-actions bot commented Apr 3, 2025

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@blueww
Copy link
Member Author

blueww commented Apr 3, 2025

It looks the check on the PR is too less, only 2.
Please help to check.

@dolauli dolauli self-assigned this Apr 7, 2025
@blueww blueww changed the base branch from mergestorage to Az.Storage-preview April 7, 2025 02:28
@blueww
Copy link
Member Author

blueww commented Apr 8, 2025

@dolauli

The analysis failure looks are not related with storage code change.
Would you please help to see how to fix them?

  There are failed tasks: GenertedSdk
  Write-Error: Help record Get-AzManagedCassandraDataCenter has no cmdlet.
  Help record New-AzManagedCassandraDataCenter has no cmdlet.
  Help record Remove-AzManagedCassandraDataCenter has no cmdlet.
  Help record Update-AzManagedCassandraDataCenter has no cmdlet.
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments
  fatal: option '--ignore-matching-lines=^\s*(//|/\*.*\*/|#)' must come before non-option arguments

@dolauli
Copy link
Contributor

dolauli commented Apr 9, 2025

@blueww Would you re-sync with the latest main branch? It seems a known issue has been fixed in main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.