You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this PR is to update commands that do not return all resources after a Get call is made. Following the changes at Azure/azure-rest-api-specs#26369, new APIs are generated that support a nextLink property that facilitates the return of all pages after a Get call
SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
Should not change ChangeLog.md if no new release is required, such as fixing test case only.
Hi @mwesigwaguma, please update the changelog.md, which can be found at src/ServiceFabric/ServiceFabric/ChangeLog.md.
And can you explain will the change affect the original output? Like the output type change or something like that. If so, you should re-generate the help follow this doc
Hi @mwesigwaguma, please update the changelog.md, which can be found at src/ServiceFabric/ServiceFabric/ChangeLog.md. And can you explain will the change affect the original output? Like the output type change or something like that. If so, you should re-generate the help follow this doc
I have updated the changelog.md file. As for the output type, it is not changing. My update only fixes a pagination issue where only one page was being returned when certain commands were executed. With the fix, all all resources should be returned but the output type is not changing.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to update commands that do not return all resources after a Get call is made. Following the changes at Azure/azure-rest-api-specs#26369, new APIs are generated that support a nextLink property that facilitates the return of all pages after a Get call
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.