Authenticate with device code #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirkamara
requested changes
Oct 11, 2018
rabee333
suggested changes
Oct 11, 2018
| AuthenticationResult result = null; | ||
| ExecutorService service = null; | ||
| try { | ||
| service = Executors.newFixedThreadPool(1); |
There was a problem hiding this comment.
is not here the same as using: Executors.newSingleThreadExecutor()?
| result = futureResult.get(); | ||
|
|
||
| } finally { | ||
| assert service != null; |
There was a problem hiding this comment.
Change to if(service != null) ...
rabee333
approved these changes
Oct 11, 2018
tamirkamara
approved these changes
Oct 11, 2018
LizaShak
pushed a commit
that referenced
this pull request
Nov 13, 2018
* Split Client and Service Exceptions in Data and Ingestion modules. * Add argument validation * Fix #13: Re-Design AzureStorageHelper - make the methods non static. (#31) * Fix #13: Re-Design AzureStorageHelper - make the methods non static. * Use IngestClientImpl instead of IngestClient * Authenticate with device code (#33) * authenticate interactively using a device code * fix browser popup * fix device code auth (#37) * Adding SourceInfo interface (#39) * Add SourceInfo interface to force implementing validate() in all SourceInfo classes * Rename SourceInfo abstract class and interface names * Authenticate with certificate (#41) * support certificate authetication * add method to authenticate with certificate * add method to authenticate with certificate objects * authenticate with certificate only with objects * add unit tests for authentication with certificate * move KeyCert to tests where its only use * extract mockito version to main pom file and delete unnecessary imports * cr changes * optimize imports * use bouncycastle in test scope only * remove unnecessary imports * Add getter and setter og SourceId to SourceInfo interface * cr fixes * Update data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java Co-Authored-By: LizaShak <[email protected]> * dont wait for user input * cr changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 and #14 allowing interactive authentication with device code