Skip to content

feat: support full jvm arg override #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: support full jvm arg override #792

wants to merge 1 commit into from
+9 −0

Conversation

@YunchuWang
Copy link
Member

New app setting OVERRIDE_JVM_ARG, allowing full override of worker jvm arguments
Addressing issue like #782
{4CC2980F-3A21-46C1-8F53-A828DBEF33E3}
{257BCDBE-4B8D-4847-93C1-17520E5BA43F}

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

@hallvictoria hallvictoria Awaiting requested review from hallvictoria hallvictoria is a code owner

@ejizba ejizba Awaiting requested review from ejizba

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

@kaibocai kaibocai Awaiting requested review from kaibocai

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna

@kamperiadis kamperiadis Awaiting requested review from kamperiadis

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YunchuWang