Skip to content

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

This PR add middleware support to java worker
trying to resolve #595

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai changed the title Kaibocai/invocation pipeline middleware support to java worker Aug 24, 2022
@kaibocai kaibocai requested a review from cgillum August 24, 2022 14:03
@kaibocai
Copy link
Member Author

This PR may replace #318

@amamounelsayed amamounelsayed requested a review from trask August 25, 2022 20:59
@patriot1burke
Copy link

@kaibocai Your branch doesn't build. I think you forgot to add some files. FYI, I wanted to branch off of this and implement some of the suggestions I made above for DI hooks so I could show you what I meant. ty.

@kaibocai
Copy link
Member Author

kaibocai commented Sep 2, 2022

created new PR based on migrating java8 to java11 #641

@kaibocai Your branch doesn't build. I think you forgot to add some files. FYI, I wanted to branch off of this and implement some of the suggestions I made above for DI hooks so I could show you what I meant. ty.

Hi @patriot1burke , sorry for late reply (not seeing the notification of your comment), this PR didn't build cause we haven't update necessary dependencies, which is also required for this PR. Will make the updates asap.

Please feel free to branch off this new PR #641, which has a clear implementation.
The dependency PR is here which you can build it on you local for testing/implementing the DI hook Azure/azure-functions-java-additions#7 at

<groupId>com.microsoft.azure.functions</groupId>
, please let me know if anything else you need from myside. Appreciate your contribution!
Thank you very much.

@kaibocai kaibocai closed this Sep 2, 2022
@kaibocai kaibocai deleted the kaibocai/invocation-pipeline branch November 3, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom middleware for function triggers
2 participants