Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add APIs to execution context for middleware support #9

Closed
wants to merge 6 commits into from

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Sep 8, 2022

add APIs to execution context for middleware support

@kaibocai kaibocai marked this pull request as draft September 8, 2022 16:10
@patriot1burke
Copy link

@kaibocai If you add support for the ExecutionContext methods to the Java worker, I can test them out in the Quarkus extension I wrote to integration with azure functions.


void setMiddlewareOutput(Object value);

void setFunctionInstance(Object functionInstance);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might consider moving these middleware specific methods like setFunctionInstance to a separate interface that extends extends ExecutionContext. ExecutionContext is available to the application developer and these methods might not be something you want exposed to them. See my PR here which shows this:

#10

Copy link
Member Author

@kaibocai kaibocai Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your valuable suggestion! We will discuss it with the team.

@kaibocai
Copy link
Member Author

@kaibocai If you add support for the ExecutionContext methods to the Java worker, I can test them out in the Quarkus extension I wrote to integration with azure functions.

Hi @patriot1burke , please use this java worker and this pr core library for local testing.

mvn clean install -Dgpg.skip can install this core library to local maven repo. Thank you.

@kaibocai
Copy link
Member Author

Refer to #10 (comment).
Need to check if function instance has already been set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants