-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add APIs to execution context for middleware support #9
Conversation
@kaibocai If you add support for the ExecutionContext methods to the Java worker, I can test them out in the Quarkus extension I wrote to integration with azure functions. |
|
||
void setMiddlewareOutput(Object value); | ||
|
||
void setFunctionInstance(Object functionInstance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might consider moving these middleware specific methods like setFunctionInstance to a separate interface that extends extends ExecutionContext. ExecutionContext is available to the application developer and these methods might not be something you want exposed to them. See my PR here which shows this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your valuable suggestion! We will discuss it with the team.
Hi @patriot1burke , please use this java worker and this pr core library for local testing.
|
Refer to #10 (comment). |
add APIs to execution context for middleware support