Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generify HttpResponseMessage #3

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Generify HttpResponseMessage #3

wants to merge 2 commits into from
+19 −15

Conversation

RockyMM
Copy link

@RockyMM RockyMM commented Feb 22, 2022

Having HttpResponseMessage supporting generics would benefit developers in many ways:

  • The type-safety could be enforced
  • Simpler mocking in tests
  • Ability to reflect on functions' signatures, so to discern true object types in the responses
    • This could allow the generation of documentation with the proper data types in the responses - e.g. OpenAPI documentation could be generated by using reflection

Rade Martinović added 2 commits February 22, 2022 12:45
Adds generics to HttpResponseMessage message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
d54ded0
Nicer convention for JUnits
2077716
@ghost
Copy link

ghost commented Feb 22, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RockyMM