Fix nightly build to pull correct version from feed #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting nightly build to true for testing fixing script to see if it works fixing syntax switching back to using nightly build conditional param
aishwaryabh
force-pushed
the
aibhandari/fix-nightly-build
branch
from
966a12b to
b3cb787
Compare
| $packageDetails = Invoke-RestMethod -Uri $packageUrl -Headers $headers -Method Get | ||
| return $packageDetails.versions[0].version | ||
| } | ||
| return $null |
There was a problem hiding this comment.
Avoid duplicated feed url,
function Get-LatestPackageVersion {
param($packageName)
$feedUrl = "https://feeds.dev.azure.com/azfunc/internal/_apis/packaging/feeds/core-tools-nightly-build/packages"
$apiVersion = "7.1"
$searchUrl = "$feedUrl?packageNameQuery=$packageName&api-version=$apiVersion"
$searchResponse = Invoke-RestMethod -Uri $searchUrl -Headers $headers -Method Get
$package = $searchResponse.value | Where-Object { $_.name -eq $packageName } | Select-Object -First 1
if (!$package) {
Write-Warning "Package '$packageName' not found in the feed."
return $null
}
$packageUrl = "$feedUrl/$($package.id)?api-version=$apiVersion"
$packageDetails = Invoke-RestMethod -Uri $packageUrl -Headers $headers -Method Get
return $packageDetails.versions[0].version
}
liliankasem
reviewed
Nov 14, 2025
| feed: 'internal/core-tools-nightly-build' | ||
| definition: 'func-cli-host' | ||
| version: '$(FUNC_CLI_VERSION)' | ||
| version: '$(FUNC_CLI_HOST_VERSION)' |
Member
There was a problem hiding this comment.
Does this have its own version? I don't see us bumping this ever? I think its fine to use FUNC_CLI_VERSION for this
liliankasem
reviewed
Nov 14, 2025
| - task: PowerShell@2 | ||
| displayName: 'Get latest artifact version' | ||
| inputs: | ||
| targetType: 'inline' |
Member
There was a problem hiding this comment.
Can we move this to a script file in eng/scripts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Fixes the core-tools nightly build to correctly pull the version from the feed (even if in-proc and default versions are different)
example of feed pulling correct version: https://azfunc.visualstudio.com/internal/_build/results?buildId=247857&view=logs&j=68b07a0c-358d-5e75-20be-40071c730e07&t=b5fed0a2-4354-5cee-7064-c98b7b5a6328
Pull request checklist
release_notes.mdAdditional information
Additional PR information