Skip to content

Add explicit shell: bash to validate-go-version workflow step#8929

Closed
mikeharder with Copilot wants to merge 14 commits into
mainfrom
copilot/fix-code-review-suggestion
Closed

Add explicit shell: bash to validate-go-version workflow step#8929
mikeharder with Copilot wants to merge 14 commits into
mainfrom
copilot/fix-code-review-suggestion

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Addresses review comment r3503367385 on #8906. The "Validate Go version consistency" step relies on bash-specific features (read -d '' and process substitution < <(...)), which are not guaranteed if the default runner shell changes.

Changes

  • Add shell: bash to the Validate Go version consistency step in .github/workflows/validate-go-version.yml, making the bash dependency explicit.
      - name: Validate Go version consistency
        shell: bash
        run: |
          ...

Copilot AI and others added 2 commits July 1, 2026 20:51
…uggestion

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code based on review comment Add explicit shell: bash to validate-go-version workflow step Jul 1, 2026
Copilot AI requested a review from mikeharder July 1, 2026 20:52
@microsoft-github-policy-service microsoft-github-policy-service Bot added the no-recent-activity identity issues with no activity label Jul 9, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi @@copilot. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi @@copilot. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity identity issues with no activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants