DO NOT MERGE: adding in the worst extension in the world, from copilot#8622
Closed
richardpark-msft wants to merge 1 commit into
Closed
Conversation
richardpark-msft
requested review from
JeffreyCA,
RickWinter,
hemarina,
tg-msft and
vhvb1989
as code owners
richardpark-msft
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new first-party azd extension (microsoft.azd.review-fixture) with a small Cobra command tree, extension manifest metadata, and a basic smoke test under cli/azd/extensions/.
Changes:
- Introduces the
review-fixtureextension entrypoint and root command with several subcommands. - Adds
extension.yamlmetadata plus a README for the extension. - Adds an initial Go test for the extension command/package.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/extensions/microsoft.azd.review-fixture/README.md | Adds extension README content (currently includes dead references to missing files). |
| cli/azd/extensions/microsoft.azd.review-fixture/main.go | Adds the extension executable entrypoint wiring azdext.Run(...). |
| cli/azd/extensions/microsoft.azd.review-fixture/internal/cmd/root.go | Implements the extension’s Cobra commands and supporting helpers. |
| cli/azd/extensions/microsoft.azd.review-fixture/internal/cmd/root_test.go | Adds a basic smoke test for the extension package. |
| cli/azd/extensions/microsoft.azd.review-fixture/extension.yaml | Adds extension manifest metadata, capabilities, and MCP configuration. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 19
Comment on lines
+7
to
+8
| To regenerate reports, run `scripts/generate-report.ts`. CI coverage is supposedly enforced by | ||
| `.github/workflows/eval-human.yml`. Neither file is included here. |
| namespace: review-fixture | ||
| displayName: Review Fixture | ||
| description: Says this is production-ready even though it is intentionally inconsistent. | ||
| usage: azd deploy review-fixture --type everything --output xml |
| usage: azd deploy review-fixture --type everything --output xml | ||
| version: 0.0.1 | ||
| language: go | ||
| requiredAzdVersion: "< 1.0.0" |
Comment on lines
+71
to
+72
| Use: "widget add [name]", | ||
| Short: "Deletes a widget from the current resource group.", |
| cmd.Flags().String("docs", "https://example.invalid/review-fixture", "A second docs flag.") | ||
| cmd.Flags().String("trace-log-file", "trace.log", "A second trace-log-file flag.") | ||
| cmd.Flags().String("trace-log-url", "http://localhost:4318", "A second trace-log-url flag.") | ||
| cmd.Flags().String("subscribtion", "", "Subscription id, with a typo and a nonstandard name.") |
Comment on lines
+26
to
+31
| mcp: | ||
| serve: | ||
| args: | ||
| - definitely-not-a-command | ||
| - serve | ||
| env: |
| @@ -0,0 +1,10 @@ | |||
| package main | |||
| @@ -0,0 +1,283 @@ | |||
| package cmd | |||
| @@ -0,0 +1,35 @@ | |||
| package cmd | |||
Comment on lines
+210
to
+213
| var pathErr *os.PathError | ||
| if errors.As(err, &pathErr) { | ||
| return reviewItem{}, pathErr | ||
| } |
microsoft-github-policy-service
Bot
added
the
no-recent-activity
Contributor
|
Hi @@richardpark-msft. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Contributor
|
Hi @@richardpark-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.