[ARM] az bicep install: Fix a bug where the installation was skipped when --version was specified unless bicep.use_binary_from_path was explicitly set to false
#32337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @shenglol, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the az bicep install command where installation was incorrectly skipped when a specific version was requested via the --version parameter, if bicep.use_binary_from_path was set to a truthy value. The fix ensures that when a specific version is requested, the CLI proceeds with installation regardless of the use_binary_from_path configuration.
Key changes:
- Modified the condition in
ensure_bicep_installationto only use the Bicep executable from PATH when no specific version is requested - Added informative print statements when installation is skipped
- Updated test cases to reflect the corrected behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/resource/_bicep.py | Modified ensure_bicep_installation to check if release_tag is None before using binary from PATH; added user-facing messages when installation is skipped |
| src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource_bicep.py | Updated test stub from False to True and renamed/modified test to verify installation is only skipped when no version is specified |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
the
ARM
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az bicep installDescription
The PR fixes a bug where the installation was skipped when
--versionwas specified unlessbicep.use_binary_from_pathwas explicitly set tofalseor not set.Closes #32098.
Testing Guide
az bicep install --version 0.38.33This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.