-
Notifications
You must be signed in to change notification settings - Fork 1.5k
vmware update to 2021-12-01 API #3992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…etwork-dns-server
…thanhe-msft/azure-cli-extensions into jonathanhe/workload-network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add prefixes to some of the flattened properties.
|
@zhoxing-ms can you please review? |
|
If you want to upgrade a new version to release those changes, please modify the |
We want this merged, but we have at least one more PR before we are ready to release 4.0.0. |
…y vm/vm host delete, updated private cloud methods
|
@zhoxing-ms updated the PR based on your comments |
|
vmware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # regenerated. | ||
| # -------------------------------------------------------------------------- | ||
|
|
||
| __path__ = __import__('pkgutil').extend_path(__path__, __name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this file may be causing #4136. @jonathanhe-msft
az vmware placement-policycommand groupaz vmware vmcommand groupaz vmware private-cloud createwith new Identity parameteraz vmware private-cloud updatewith new Identity parameterThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.