Skip to content

Conversation

@jonathanhe-msft
Copy link
Contributor

@jonathanhe-msft jonathanhe-msft commented Oct 19, 2021

  • Add az vmware placement-policy command group
  • Add az vmware vm command group
  • Updated az vmware private-cloud create with new Identity parameter
  • Updated az vmware private-cloud update with new Identity parameter

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

jonathanhe-msft and others added 30 commits September 8, 2021 12:03
@jonathanhe-msft jonathanhe-msft changed the title Jonathanhe/cmk vmware update to 2021-12-01 API Oct 28, 2021
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add prefixes to some of the flattened properties.

@jonathanhe-msft jonathanhe-msft marked this pull request as ready for review November 2, 2021 15:33
@jonathanhe-msft
Copy link
Contributor Author

@zhoxing-ms can you please review?

@zhoxing-ms
Copy link
Contributor

If you want to upgrade a new version to release those changes, please modify the setup.py to update the version

@cataggar
Copy link
Member

cataggar commented Nov 9, 2021

If you want to upgrade a new version to release those changes, please modify the setup.py to update the version

We want this merged, but we have at least one more PR before we are ready to release 4.0.0.

@jonathanhe-msft
Copy link
Contributor Author

@zhoxing-ms updated the PR based on your comments

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 12, 2021

vmware

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 3a5b66d into Azure:main Nov 13, 2021
# regenerated.
# --------------------------------------------------------------------------

__path__ = __import__('pkgutil').extend_path(__path__, __name__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this file may be causing #4136. @jonathanhe-msft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants