fix: Add StringComparison to all string operations and promote CA1307/CA1310 to warning (#34, #8)

[daviburg]

Summary

Fixes #34 (CA1307/CA1310 StringComparison violations) and #8 (small code quality fixes).

CA1307/CA1310 — StringComparison (38 violations fixed)

Added explicit StringComparison.Ordinal to all .Contains(), .StartsWith(), .EndsWith(), .IndexOf(), and .Replace() calls across the server codebase. Promoted CA1307/CA1310 severity from suggestion to warning in .editorconfig so future violations are caught at build time (TreatWarningsAsErrors is enabled).

Issue #8 — Code quality fixes

• BufferManager.cs — Added namespace SdkLspServer; and changed class to internal (was public in global namespace). Updated 5 consuming handler classes to internal to match.
• DynamicValuesCacheEntry.cs — Removed unused using System.Collections.Concurrent;.
• .editorconfig — Removed non-standard guidelines = 120 key.
• SdkIndex.cs — Changed 2 bare catch (Exception e) blocks to catch (Exception ex) when (!ex.IsFatal()) matching the pattern used elsewhere in the file.

Verification

• dotnet build — zero warnings (all 38 CA1307/CA1310 violations resolved)
• dotnet test — 233 passed, 15 skipped, 0 failed (matches baseline)
• No test files modified
• No functional logic changes

[Copilot]

Pull request overview

This PR addresses analyzer enforcement for explicit string comparison across the LSP server and applies small code quality cleanups from prior review feedback.

Changes:

• Adds explicit StringComparison.Ordinal to string operations and promotes CA1307/CA1310 to warnings.
• Moves BufferManager into the SdkLspServer namespace and reduces selected handler classes from public to internal.
• Cleans up unused using/config entries and updates exception filters in SdkIndex.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.editorconfig	Promotes CA1307/CA1310 severity and removes non-standard guidelines setting.
Server/BufferManager.cs	Adds namespace and changes BufferManager to internal.
Server/SdkIndex.cs	Adds ordinal comparison and fatal-exception filtering.
Server/Store/DynamicData/DynamicValuesCacheEntry.cs	Removes unused using.
Server/Handlers/HoverHandler/HoverHandler.cs	Adds explicit string comparisons and makes handler internal.
Server/Handlers/HoverHandler/SdkDynamicOperationsDiscovery.cs	Adds explicit string comparisons.
Server/Handlers/CompletionHandler/CompletionHandler.cs	Adds explicit string comparisons and makes handler internal.
Server/Handlers/CodeLensHandler.cs	Makes handler internal.
Server/Handlers/CodeActionHandler/DynamicSchemaCodeActionHandler.cs	Adds explicit string comparison and makes handler internal.
Server/Handlers/CodeActionHandler/GenerateDynamicSchemaCommandHandler.cs	Makes command handler internal.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.