feat: Add SDK anti-pattern diagnostics (#44)

[daviburg]

Summary

Extends the LSP server with five new SDK usage anti-pattern diagnostics (CSDK401-CSDK405), with codes CSDK406-CSDK407 reserved for future use.

Diagnostics Added

Code	Severity	Description
CSDK401	Warning	[ConnectorOperation]\ operation value doesn't match any known operation (only when ConnectorName is absent; ConnectorName-present case is handled by CSDK009 in AttributeValidator)
CSDK402	Info	*Input\ type used where *Output\ is expected (wrong payload direction)
CSDK403	Warning	Catching \ConnectorException\ without checking \StatusCode\
CSDK404	Warning	Async connector method called without \�wait\
CSDK405	Warning	\CancellationToken\ available but not passed to connector API call

Implementation

• *\SdkAntiPatternValidator* - new validator registered in DI alongside existing validators
• CSDK401-403 use syntax-only analysis (fast, no compilation)
• CSDK404-405 use semantic analysis via \CompilationService\
• CSDK401 defers to AttributeValidator (CSDK009) when ConnectorName is present to avoid duplicates

Testing

• 23+ test cases in \SdkAntiPatternValidatorTests.cs\
• Build: 0 errors
• Tests: 233 passed, 15 skipped, 0 failed

Closes #44

[Copilot]

Pull request overview

Adds a new Roslyn-based diagnostic validator to the LSP server to detect common Azure Connectors SDK usage anti-patterns, expanding the existing diagnostics suite.

Changes:

• Introduces SdkAntiPatternValidator emitting diagnostics CSDK401–CSDK405 (with CSDK406–CSDK407 reserved).
• Registers the new validator in server DI so it participates in diagnostic publishing.
• Adds unit tests covering positive/negative cases and edge conditions for the new diagnostics.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
Server/Program.cs	Registers the new SdkAntiPatternValidator in DI so it runs with other validators.
Server/Diagnostics/Validators/SdkAntiPatternValidator.cs	Implements syntax + semantic checks for CSDK401–CSDK405.
Server/Diagnostics/DiagnosticCodes.cs	Adds new diagnostic code constants CSDK401–CSDK407.
Server.Tests/SdkAntiPatternValidatorTests.cs	Adds test coverage for the new validator behaviors.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

Server/Diagnostics/Validators/SdkAntiPatternValidator.cs:141

• In CSDK401, ConnectorName is mapped via sdkIndex.ConnectorNameConstants (lines 127–141), but the value is never used for any validation because the code immediately skips whenever ConnectorName is non-null. This makes the mapping logic and its associated comments/tests misleading; consider either using the resolved ConnectorName to drive connector-scoped validation / resolution checks, or removing this unused resolution block if CSDK401 intentionally never runs when ConnectorName is provided.

                    // Try connector-scoped validation first when ConnectorName is present.
                    string? connectorName = SdkAntiPatternValidator.GetConnectorNameFromAttribute(attribute);

                    // Resolve constant-style ConnectorName (e.g., "Office365" from
                    // ConnectorNames.Office365) to the canonical value ("office365")
                    // using the SDK index's ConnectorNameConstants.
                    if (connectorName is not null)
                    {
                        SdkConstant? matchedConnector = sdkIndex.ConnectorNameConstants
                            .FirstOrDefault(connector =>
                                string.Equals(connector.FieldName, connectorName, StringComparison.OrdinalIgnoreCase) ||
                                string.Equals(connector.Value, connectorName, StringComparison.OrdinalIgnoreCase));

                        if (matchedConnector is not null)
                        {
                            connectorName = matchedConnector.Value;
                        }
                    }

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.