Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secrets to use certificate for auth #758

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove secrets to use certificate for auth #758

wants to merge 3 commits into from

Conversation

neelavarshad
Copy link
Contributor

  • Removed use of secret
  • Added self signed certificate
  • Saved certificate to keyvault with cert password
  • CertificateHelper class to read certificate from keyvault

@santhoshb-msft
Copy link
Contributor

@neelavarshad this PR is still in draft, should we wait until finalized

@neelavarshad neelavarshad marked this pull request as ready for review September 9, 2024 19:38
@neelavarshad
Copy link
Contributor Author

Its ready for review. Thanks!

@santhoshb-msft
Copy link
Contributor

@v-adeadepoju approved this. will merge once 8 release is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-adeadepoju v-adeadepoju v-adeadepoju approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@v-adeadepoju v-adeadepoju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neelavarshad @santhoshb-msft @v-adeadepoju